[PATCH] Fix a use-after-free triggered by device removal

2012-09-03 Thread Bart Van Assche
If the put_device() call in scsi_request_fn() drops the sdev refcount to zero then the spin_lock() call after the put_device() call triggers a use-after-free. Avoid that by making sure that blk_cleanup_queue() can only finish after all active scsi_request_fn() calls have returned. Reported-by: Cha

[Bug 46891] scsi/bnx2fc/bnx2fc_io.c:1810: bad call to memset

2012-09-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=46891 Alan changed: What|Removed |Added CC||a...@lxorguk.ukuu.org.uk Component|Other

[Bug 46891] scsi/bnx2fc/bnx2fc_io.c:1810: bad call to memset

2012-09-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=46891 Bhanu Prakash Gollapudi changed: What|Removed |Added CC||bprak...@broadcom.com --- C

[PATCH] Fix incorrect memset in bnx2fc_parse_fcp_rsp

2012-09-03 Thread Andi Kleen
gcc 4.8 warns because the memset only clears sizeof(char *) bytes, not the whole buffer. Use the correct buffer size and clear the whole sense buffer. /backup/lsrc/git/linux-lto-2.6/drivers/scsi/bnx2fc/bnx2fc_io.c: In function 'bnx2fc_parse_fcp_rsp': /backup/lsrc/git/linux-lto-2.6/drivers/scsi/bnx

Re: [PATCH] Fix incorrect memset in bnx2fc_parse_fcp_rsp

2012-09-03 Thread Bhanu Prakash Gollapudi
On 9/3/2012 11:50 AM, Andi Kleen wrote: gcc 4.8 warns because the memset only clears sizeof(char *) bytes, not the whole buffer. Use the correct buffer size and clear the whole sense buffer. /backup/lsrc/git/linux-lto-2.6/drivers/scsi/bnx2fc/bnx2fc_io.c: In function 'bnx2fc_parse_fcp_rsp': /back

Re: [PATCH 5/5] virtio-scsi: introduce multiqueue support

2012-09-03 Thread Nicholas A. Bellinger
On Tue, 2012-08-28 at 13:54 +0200, Paolo Bonzini wrote: > This patch adds queue steering to virtio-scsi. When a target is sent > multiple requests, we always drive them to the same queue so that FIFO > processing order is kept. However, if a target was idle, we can choose > a queue arbitrarily.

Re: [PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-09-03 Thread Naresh Kumar Inna
On 8/26/2012 12:38 AM, Naresh Kumar Inna wrote: > On 8/25/2012 12:40 AM, David Miller wrote: >> From: Naresh Kumar Inna >> Date: Sat, 25 Aug 2012 00:34:35 +0530 >> >>> Thanks for reviewing. Is your comment with respect to any particular >>> module parameter[s] in this driver or all of them? >> >>

Re: [PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-09-03 Thread David Miller
From: Naresh Kumar Inna Date: Tue, 4 Sep 2012 10:43:24 +0530 > Removing all the module parameters from the driver would put us at a > disadvantage with respect to tuning the driver and hardware. I have not > not been able to find alternatives, considering every other driver uses > module paramete

Re: [PATCH 5/5] virtio-scsi: introduce multiqueue support

2012-09-03 Thread Paolo Bonzini
Il 04/09/2012 04:21, Nicholas A. Bellinger ha scritto: >> @@ -112,6 +118,9 @@ static void virtscsi_complete_cmd(struct virtio_scsi >> *vscsi, void *buf) >> struct virtio_scsi_cmd *cmd = buf; >> struct scsi_cmnd *sc = cmd->sc; >> struct virtio_scsi_cmd_resp *resp = &cmd->resp.cmd; >>