Re: [SCSI] mpt2sas T10 DIF fixes

2012-08-20 Thread Pasi Kärkkäinen
On Sun, Aug 19, 2012 at 12:38:43PM -0400, Martin K. Petersen wrote: > > "Pasi" == Pasi Kärkkäinen writes: > > Pasi> So physically the disk is using 520 bytes/sector (and needs to > Pasi> support that), but logically the HBA presents 512 bytes/sector + > Pasi> PI.. is that correct? > > Yep. T

Re: [SCSI] mpt2sas T10 DIF fixes

2012-08-20 Thread Pasi Kärkkäinen
On Mon, Aug 20, 2012 at 01:48:19PM +0300, Pasi Kärkkäinen wrote: > On Sun, Aug 19, 2012 at 12:38:43PM -0400, Martin K. Petersen wrote: > > > "Pasi" == Pasi Kärkkäinen writes: > > > > Pasi> So physically the disk is using 520 bytes/sector (and needs to > > Pasi> support that), but logically th

Using SCSI timeouts in place of ERC

2012-08-20 Thread joystick
Hello lists I am wondering what kind of support I can get from linux for "inexpensive" (SATA over SAS HBA in my case) disks on RAID ... Inexpensive non-raid-edition disks haven't got settable ERC timeout (scterc) and can take very long time to respond in case of unreadable sector However I see

Re: [patch 1/2]block: handle merged discard request

2012-08-20 Thread Mike Snitzer
On Fri, Aug 17 2012 at 11:47pm -0400, Martin K. Petersen wrote: > > "Mike" == Mike Snitzer writes: > > Mike> Could be I've wasted a few hours by rebasing these patches... > Mike> regardless, it would be great if you could share what your plans > Mike> are. > > Heh, I worked on syncing my p

Re: [patch 1/2]block: handle merged discard request

2012-08-20 Thread Christoph Hellwig
On Mon, Aug 20, 2012 at 09:57:39AM -0400, Mike Snitzer wrote: > But I haven't put my finger on _why_ a discard bio has bio->bi_io_vec > (but given my use of DM, bio comes from bio_alloc_bioset, and DM passes > original bio->bi_max_vecs for nr_iovecs). TRIM has a payload and we cheay by preallocati

[PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.

2012-08-20 Thread Richard W.M. Jones
From: "Richard W.M. Jones" The sg struct is used without being initialized. https://bugzilla.redhat.com/show_bug.cgi?id=847548 Signed-off-by: Richard W.M. Jones --- drivers/scsi/virtio_scsi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/virtio_scsi.c b/d

Re: [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.

2012-08-20 Thread Paolo Bonzini
Il 20/08/2012 16:04, Richard W.M. Jones ha scritto: > From: "Richard W.M. Jones" > > The sg struct is used without being initialized. > > https://bugzilla.redhat.com/show_bug.cgi?id=847548 > > Signed-off-by: Richard W.M. Jones > --- > drivers/scsi/virtio_scsi.c |2 +- > 1 file changed, 1

Re: [patch 1/2]block: handle merged discard request

2012-08-20 Thread Mike Snitzer
On Mon, Aug 20 2012 at 9:58am -0400, Christoph Hellwig wrote: > On Mon, Aug 20, 2012 at 09:57:39AM -0400, Mike Snitzer wrote: > > But I haven't put my finger on _why_ a discard bio has bio->bi_io_vec > > (but given my use of DM, bio comes from bio_alloc_bioset, and DM passes > > original bio->bi

Re: [patch 1/2]block: handle merged discard request

2012-08-20 Thread Christoph Hellwig
On Mon, Aug 20, 2012 at 10:12:29AM -0400, Mike Snitzer wrote: > Thought we pushed that down? Hence sd_setup_discard_cmnd's > alloc_page + blk_add_request_payload hack. Yeah, but we still need the bio_vec from early on, as it's allocated as part of the bio. -- To unsubscribe from this list: send t

[Bug 31192] ioctl SG_GET_REQUEST_TABLE returns 64-bit structure to 32-bit app.

2012-08-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=31192 Alan changed: What|Removed |Added Status|NEW |RESOLVED CC|

request size limit in scsi tape driver

2012-08-20 Thread Olaf Hering
Currently the st driver does not to break up write requests into smaller chunks to satisfy the ->max_hw_sectors limit of the underlying host driver. # modprobe -v scsi_debug ptype=1 opts=1 dev_size_mb=123 # dd if=/dev/zero of=/dev/st0 bs=$((1024*54321)) This leads to -EBUSY from this call chai

[PATCH] bfa: avoid buffer overrun for 12-byte model name

2012-08-20 Thread Jim Meyering
From: Jim Meyering we use strncpy to copy a model name of length up to 15 (16, if you count the NUL), into a buffer of size 12 (BFA_FCS_PORT_SYMBNAME_MODEL_SZ). However, strncpy does not always NUL-terminate, so whenever the original model string has strlen >= 12, the following strncat reads beyo

[PATCH v2 0/7] be2iscsi: Updates for be2iscsi driver

2012-08-20 Thread John Soni Jose
Fixes done based on the review comments on previous submission. These patches were generated against the scsi tree "scsi-misc" branch. be2iscsi: Removing the iscsi_data_pdu setting. be2iscsi: Issue MBX Cmd for login to boot target in crashdump mode be2iscsi: Added Logging mechanism for t

[PATCH v2 1/7] be2iscsi: Removing the iscsi_data_pdu setting.

2012-08-20 Thread John Soni Jose
The setting of iscsi_data_pdu is not required anymore, as this was required for BE1 adapters only. The BE1 adapter were not supported in any previous versions of the kernel. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_main.c | 12 --

[PATCH v2 2/7] be2iscsi: Issue MBX Cmd for login to boot target in crashdump mode

2012-08-20 Thread John Soni Jose
When the driver comes up in crashdump mode, it has to explicitly issue command to FW for logging to the boot target. This fix issues MBX Cmd to login to boot target in crashdump mode. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_cmds.h | 18

[PATCH v2 4/7] be2iscsi: Format the MAC_ADDR with sysfs_format_mac.

2012-08-20 Thread John Soni Jose
The MAC_ADDR stored in driver private structure is of unsigned char data type but strlcpy parameters is of signed char data type. This conversion of data types lead to change in the value.This changed value is passed to the upper layer and junk characters were displayed when "iscsiadm -m ifac

[PATCH v2 5/7] be2iscsi: Add support for configuring the VLAN on the adapter.

2012-08-20 Thread John Soni Jose
Add support for configuring the VLAN parameters on the adapter using the iscsiadm interface. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_cmds.c | 42 + drivers/scsi/be2iscsi/be_cmds.h |9 drivers/scsi/be2iscsi/

[PATCH v2 6/7] be2iscsi: Fix a kernel panic because of TCP RST/FIN received.

2012-08-20 Thread John Soni Jose
A TCP RST/FIN can be received even before the connection specific structures are initialized.This fix checks for the conn structure is intialized or not when RST/FIN is received. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_iscsi.c | 30 +++

[PATCH v2 7/7] be2iscsi: Bump the driver version.

2012-08-20 Thread John Soni Jose
Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_main.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h index 084386c..b891226 100644 --- a/drivers/scsi/be2isc

Re: [PATCH 7/7] drivers/s390/scsi/zfcp_cfdc.c: remove invalid reference to list iterator variable

2012-08-20 Thread Steffen Maier
Hi Julia, sorry for the long delay until I finally responded. Thanks a lot for your report and patch. I'll queue this and send it for v3.6rcX hopefully soon. On 07/08/2012 01:37 PM, Julia Lawall wrote: > From: Julia Lawall > > If list_for_each_entry, etc complete a traversal of the list, the ite

Re: request size limit in scsi tape driver

2012-08-20 Thread Kai Makisara
On Mon, 20 Aug 2012, Olaf Hering wrote: > > Currently the st driver does not to break up write requests into smaller > chunks to satisfy the ->max_hw_sectors limit of the underlying host driver. > > # modprobe -v scsi_debug ptype=1 opts=1 dev_size_mb=123 > # dd if=/dev/zero of=/dev/st0 bs=$((1

RE: [PATCH] bfa: avoid buffer overrun for 12-byte model name

2012-08-20 Thread Krishna Gudipati
> -Original Message- > From: Jim Meyering [mailto:j...@meyering.net] > Sent: Monday, August 20, 2012 9:55 AM > To: linux-ker...@vger.kernel.org > Cc: Jim Meyering; Jing Huang; Krishna Gudipati; James E.J. Bottomley; linux- > s...@vger.kernel.org > Subject: [PATCH] bfa: avoid buffer overrun

Re: [patch 0/5] st: Clean up and raise max device limit (v4)

2012-08-20 Thread Kai Makisara
On Sat, 18 Aug 2012, Jeff Mahoney wrote: > This patchset cleans up the SCSI tape device handling code and leverages it > to lift the limitation of the number of tape drives from the previous > arbitrary limit of 128 to the maximum supported by a device node that > creates 8 character devices per p

Re: [PATCH] bfa: avoid buffer overrun for 12-byte model name

2012-08-20 Thread Jim Meyering
Krishna Gudipati wrote: >> -Original Message- >> From: Jim Meyering [mailto:j...@meyering.net] >> Sent: Monday, August 20, 2012 9:55 AM >> To: linux-ker...@vger.kernel.org >> Cc: Jim Meyering; Jing Huang; Krishna Gudipati; James E.J. Bottomley; linux- >> s...@vger.kernel.org >> Subject: [PA

Re: [SCSI] mpt2sas T10 DIF fixes

2012-08-20 Thread Martin K. Petersen
> "Pasi" == Pasi Kärkkäinen writes: Pasi> Btw do you know the current status of T10 PI support in md/dm Pasi> raid? If I understood correctly there's some support for Pasi> raid0/raid1 implemented.. Yes. The only thing that doesn't work is RAID5/6. Pasi> Are there any docs how to enable/d

Re: [SCSI] mpt2sas T10 DIF fixes

2012-08-20 Thread Martin K. Petersen
> "Pasi" == Pasi Kärkkäinen writes: Pasi> .. and I probably need to sg_format the backing devices to enable Pasi> PI Yes. Unless the drive is already formatted with PI. The latter is becoming increasingly common as a PI-drive will work just fine in a "legacy" setup. Many current drives provi

[PATCH] iscsi: Don't disable BH on BH context

2012-08-20 Thread Ying Xue
Since we have already in BH context when iscsi_sw_tcp_write_space() is called, it's unnecessary to disable BH. Signed-off-by: Ying Xue Acked-by: Michael Christie --- drivers/scsi/iscsi_tcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/iscsi_tcp.c b/drive

Re: [SCSI] mpt2sas T10 DIF fixes

2012-08-20 Thread Pasi Kärkkäinen
On Mon, Aug 20, 2012 at 08:40:21PM -0400, Martin K. Petersen wrote: > > "Pasi" == Pasi Kärkkäinen writes: > > Pasi> Btw do you know the current status of T10 PI support in md/dm > Pasi> raid? If I understood correctly there's some support for > Pasi> raid0/raid1 implemented.. > > Yes. The o

Re: [SCSI] mpt2sas T10 DIF fixes

2012-08-20 Thread Pasi Kärkkäinen
On Mon, Aug 20, 2012 at 08:43:49PM -0400, Martin K. Petersen wrote: > > "Pasi" == Pasi Kärkkäinen writes: > > Pasi> .. and I probably need to sg_format the backing devices to enable > Pasi> PI > > Yes. Unless the drive is already formatted with PI. The latter is > becoming increasingly commo