[patch] [SCSI] bnx2fc: zero out sense buffer properly

2012-08-18 Thread Dan Carpenter
->sense_buffer used to be an array but it changed to pointer in de25deb180 "[SCSI] use dynamically allocated sense buffer". This call to memset() needs to be updated as well. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c index 73f231

Re: [patch] [SCSI] bnx2fc: zero out sense buffer properly

2012-08-18 Thread FUJITA Tomonori
On Sat, 18 Aug 2012 11:46:37 +0300 Dan Carpenter wrote: > ->sense_buffer used to be an array but it changed to pointer in > de25deb180 "[SCSI] use dynamically allocated sense buffer". This call > to memset() needs to be updated as well. > > Signed-off-by: Dan Carpenter > > diff --git a/driver

Re: [PATCH 17/18] srp_transport: Add transport layer recovery support

2012-08-18 Thread Bart Van Assche
On 07/16/12 22:28, David Dillow wrote: > On Mon, 2012-07-16 at 18:07 -0400, Mike Christie wrote: >> On 01/14/2012 05:56 AM, Bart Van Assche wrote: >>> Add the necessary functions in the SRP transport module to allow >>> an SRP initiator driver to implement transport layer recovery. >> >> I was upda

Re: [PATCH RESEND] remove the queue unlock in scsi_requset_fn

2012-08-18 Thread Bart Van Assche
On 08/16/12 07:52, Bart Van Assche wrote: > On 08/16/12 01:35, Chanho Min wrote: >>> functions will occur in line. I also don't see why the sdev reference >>> couldn't drop to zero here. >> scsi_request_fn is called under the lock of request_queue->queue_lock. >> If we drop the sdev reference to z

drivers/scsi/ipr.c:8448:2-19: alloc with no test

2012-08-18 Thread Fengguang Wu
Hi Brian, FYI, coccinelle warns about drivers/scsi/ipr.c:8448:2-19: alloc with no test, possible model on line 8457 vi +8448 drivers/scsi/ipr.c 8443 if (ioa_cfg->sis64) { 8444 ioa_cfg->target_ids = kzalloc(sizeof(unsigned long) * 8445

Re: [PATCH] target: Remove unused se_cmd.cmd_spdtl

2012-08-18 Thread Roland Dreier
On Fri, Aug 17, 2012 at 6:02 PM, Nicholas A. Bellinger wrote: > No, or at least that is not what happens anymore with current target > core + iscsi-target code.. > > The se_cmd->data_length re-assignment here is what will be used by > iscsi-target fabric code for all iSCSI descriptor related alloc

[patch 5/5] [PATCH 5/5] st: raise device limit

2012-08-18 Thread Jeff Mahoney
The device limit of 128 tape drives was established in 2003 as a significant increase from the 8 tape drives allowed previously. We're seeing customer sites that between a large number of drives and multipath are discovering more than 128 devices and running into problems. Now that we're not stuc

[patch 0/5] st: Clean up and raise max device limit (v4)

2012-08-18 Thread Jeff Mahoney
This patchset cleans up the SCSI tape device handling code and leverages it to lift the limitation of the number of tape drives from the previous arbitrary limit of 128 to the maximum supported by a device node that creates 8 character devices per physical device. Since minors are 20 bits, that mea

[patch 2/5] [PATCH 2/5] st: clean up dev cleanup in st_probe

2012-08-18 Thread Jeff Mahoney
st_probe leaves a cdev pointer hanging around that is compared during the error path and freed later. There's no need for the pointer to hang around at all. So we free it immediately and simplify the error handling. Reviewed-by: Lee Duncan Signed-off-by: Jeff Mahoney --- drivers/scsi/st.c | 1

[patch 1/5] [PATCH 1/5] st: Use static class attributes

2012-08-18 Thread Jeff Mahoney
st currently sets up and tears down class attributes manually for every tape drive in the system. This patch uses a statically defined class with class attributes to let the device core do it for us. Reviewed-by: Lee Duncan Signed-off-by: Jeff Mahoney --- drivers/scsi/st.c | 74 ++

[patch 3/5] [PATCH 3/5] st: get rid of scsi_tapes array

2012-08-18 Thread Jeff Mahoney
st currently allocates an array to store pointers to all of the scsi_tape objects. It's used to discover available indexes to use as the base for the minor number selection and later to look up scsi_tape devices for character devices. We switch to using an IDR for minor selection and a pointer fro

[patch 4/5] [PATCH 4/5] st: clean up device file creation and removal

2012-08-18 Thread Jeff Mahoney
This patch cleans up the st device file creation and removal. Reviewed-by: Lee Duncan Signed-off-by: Jeff Mahoney --- drivers/scsi/st.c | 195 -- drivers/scsi/st.h |1 2 files changed, 91 insertions(+), 105 deletions(-) --- a/drivers/sc

Re: [GIT PULL] tcm_vhost: Initial merge of vhost level target fabric driver

2012-08-18 Thread Michael S. Tsirkin
Hi Nicholas, I just noticed this problem in the interface: +#include + +/* + * Used by QEMU userspace to ensure a consistent vhost-scsi ABI. + * + * ABI Rev 0: July 2012 version starting point for v3.6-rc merge candidate + + *RFC-v2 vhost-scsi userspace. Add GET_ABI_VERSION ioctl usa

Re: [PATCH] target: Remove unused se_cmd.cmd_spdtl

2012-08-18 Thread Nicholas A. Bellinger
On Sat, 2012-08-18 at 10:13 -0700, Roland Dreier wrote: > On Fri, Aug 17, 2012 at 6:02 PM, Nicholas A. Bellinger > wrote: > > No, or at least that is not what happens anymore with current target > > core + iscsi-target code.. > > > > The se_cmd->data_length re-assignment here is what will be used

Re: [GIT PULL] tcm_vhost: Initial merge of vhost level target fabric driver

2012-08-18 Thread Nicholas A. Bellinger
On Sat, 2012-08-18 at 23:04 +0300, Michael S. Tsirkin wrote: > Hi Nicholas, > I just noticed this problem in the interface: > > +#include > + > +/* > + * Used by QEMU userspace to ensure a consistent vhost-scsi ABI. > + * > + * ABI Rev 0: July 2012 version starting point for v3.6-rc merge > candi

Re: Odd behavior of a "SAS-2" backplane with SGPIO commands

2012-08-18 Thread Rich
I actually have a lot of information I can share about this since I wrote this email. To be brief, the sas2ircu toolset works perfectly fine with IT mode HBAs - just not with passive backplanes AFAICS [e.g. the 846A, versus the 846EL2]. Also, the bug I'm experiencing is not present with the SAS23

Re: Odd behavior of a "SAS-2" backplane with SGPIO commands

2012-08-18 Thread Pasi Kärkkäinen
On Tue, Jul 03, 2012 at 09:54:58PM -0400, Rich wrote: > [My apologies if this is the wrong mailing list for this, but it > seemed to be the most relevant. Please direct me elsewhere and discard > if this is OT.] > This is a perfectly fine list, hopefully :) > Hi all, > Hello, > I've been beati