Re: [PATCH RESEND] remove the queue unlock in scsi_requset_fn

2012-08-16 Thread Bart Van Assche
On 08/16/12 01:35, Chanho Min wrote: >> functions will occur in line. I also don't see why the sdev reference >> couldn't drop to zero here. > scsi_request_fn is called under the lock of request_queue->queue_lock. > If we drop the sdev reference to zero here, > scsi_device_dev_release_usercontext

Re: [PATCH RESEND] remove the queue unlock in scsi_requset_fn

2012-08-16 Thread James Bottomley
On Thu, 2012-08-16 at 10:35 +0900, Chanho Min wrote: > > functions will occur in line. I also don't see why the sdev reference > > couldn't drop to zero here. > scsi_request_fn is called under the lock of request_queue->queue_lock. > If we drop the sdev reference to zero here, > scsi_device_dev_re

Re: [PATCH RESEND] remove the queue unlock in scsi_requset_fn

2012-08-16 Thread James Bottomley
On Thu, 2012-08-16 at 07:52 +, Bart Van Assche wrote: > On 08/16/12 01:35, Chanho Min wrote: > >> functions will occur in line. I also don't see why the sdev reference > >> couldn't drop to zero here. > > scsi_request_fn is called under the lock of request_queue->queue_lock. > > If we drop the

Re: areca [17d3:1320] controller not working with linux 3.5 and mvsas?!

2012-08-16 Thread Jelle de Jong
Hi Jack. On 16/08/12 03:07, Jack Wang wrote: > Seems the all idenfy to the disk failed, > And all phy add to port-0:0 looks stange. # ARC-1320ix-16 logs with a clean rmmod mvsas and modprobe mvsas http://paste.debian.net/183845/ I tried to get the older working Areca 1300ix-16 controller but sad

RE areca [17d3:1320] controller not working with linux 3.5 and mvsas?!

2012-08-16 Thread Jack Wang
Jelle, Xiangliang is current Marvell developer who maintain mvsas, he may gave you suggestion for fix this. Best regards! Jack > > Hi Jack. > > On 16/08/12 03:07, Jack Wang wrote: > > Seems the all idenfy to the disk failed, > > And all phy add to port-0:0 looks stange. > > # ARC-1320ix-16 lo

[patch] [SCSI] mvsas: fix a && vs & bug

2012-08-16 Thread Dan Carpenter
The "1 << (slot_idx % 32)" condition is always true. The intent was to test a bit field here using bitwise AND. We do the test correctly a few lines later in the do while loop. Signed-off-by: Dan Carpenter --- Static checker fix. Untested. Would apply to the -stable kernel. diff --git a/driv

[Bug 46031] New: kswapd0 moving to uninterruptible sleep (STAT D)

2012-08-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=46031 Summary: kswapd0 moving to uninterruptible sleep (STAT D) Product: IO/Storage Version: 2.5 Kernel Version: 3.5.2 Platform: All OS/Version: Linux Tree: Mainline Status:

[Bug 46031] kswapd0 moving to uninterruptible sleep (STAT D)

2012-08-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=46031 --- Comment #1 from Markus Hetzmannseder 2012-08-16 12:44:35 --- Full kern.log is to big for attachment, you can find it under: http://oban.stoch.uni-linz.ac.at/kern.log -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=e

Re: [Bug 46031] New: kswapd0 moving to uninterruptible sleep (STAT D)

2012-08-16 Thread James Bottomley
[Cc of more relevant fs lists added] On Thu, 2012-08-16 at 12:40 +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=46031 > >Summary: kswapd0 moving to uninterruptible sleep (STAT D) >Product: IO/Storage >Version: 2.5

[Bug 46031] kswapd0 moving to uninterruptible sleep (STAT D)

2012-08-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=46031 --- Comment #2 from Anonymous Emailer 2012-08-16 12:46:19 --- Reply-To: james.bottom...@hansenpartnership.com [Cc of more relevant fs lists added] On Thu, 2012-08-16 at 12:40 +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzi

[RFC] MAINTAINERS: Update SCSI git trees

2012-08-16 Thread Steffen Maier
In http://marc.info/?l=linux-scsi&m=133517794218707&w=2 James wrote on 2012-04-23: > Just to let you know that SCSI is moving on to a single tree model > from now on. The new tree is > > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git > > And the branch for next is for-next. > > Could y

[PATCH] [trivial] target: Fix typo in drivers/target

2012-08-16 Thread Masanari Iida
Correct spelling typo in printk and comment within drivers/target. Signed-off-by: Masanari Iida --- drivers/target/target_core_alua.c | 2 +- drivers/target/target_core_configfs.c | 2 +- drivers/target/target_core_device.c | 6 +++--- drivers/target/target_core_fabric_lib.c | 8

[PATCH] scsi_debug: Fix off-by-one bug when unmapping region

2012-08-16 Thread Lukas Czerner
Currently it is possible to unmap one more block than user requested to due to the off-by-one error in unmap_region(). This is probably due to the fact that the end variable despite its name actually points to the last block to unmap + 1. However in the condition it is handled as the last block of

Re: [PATCH] scsi: return TARGET_ERROR when a device has been disconnected

2012-08-16 Thread Michael Christie
On Aug 16, 2012, at 1:40 AM, Hannes Reinecke wrote: > When we receive a sense code of > NOT READY, LOGICAL UNIT NOT SUPPORTED > the device has been disconnected and any retry on other paths > would be pointless. So return TARGET_ERROR here. What target is this with? What about {ILLEGAL_REQUEST

Re: [PATCH] scsi: return TARGET_ERROR when a device has been disconnected

2012-08-16 Thread Hannes Reinecke
On 08/16/2012 04:53 PM, Michael Christie wrote: > > On Aug 16, 2012, at 1:40 AM, Hannes Reinecke wrote: > >> When we receive a sense code of >> NOT READY, LOGICAL UNIT NOT SUPPORTED >> the device has been disconnected and any retry on other paths >> would be pointless. So return TARGET_ERROR her

Re: [patch] [SCSI] mvsas: fix a && vs & bug

2012-08-16 Thread Jeff Garzik
On 08/16/2012 07:04 AM, Dan Carpenter wrote: The "1 << (slot_idx % 32)" condition is always true. The intent was to test a bit field here using bitwise AND. We do the test correctly a few lines later in the do while loop. Signed-off-by: Dan Carpenter Acked-by: Jeff Garzik -- To unsubscr

Re: 'Device not ready' issue on mpt2sas since 3.1.10

2012-08-16 Thread Robert Trace
On 07/25/2012 03:55 PM, James Bottomley wrote: > > Well, reading it, so do I. Unfortunately, we get to deal with the world > as it is rather than as we would wish it to be. We likely have this > problem with a lot of USB SATLs as well ... Has this patch made it into the main git trees yet? I h

Re: [PATCH] scsi/ibmvscsi: /sys/class/scsi_host/hostX/config doesn't show any information

2012-08-16 Thread Robert Jennings
On Sun, Jul 29, 2012 at 8:33 PM, Benjamin Herrenschmidt wrote: > n Wed, 2012-07-18 at 18:49 +0200, o...@aepfle.de wrote: >> From: Linda Xie >> >> Expected result: >> It should show something like this: >> x1521p4:~ # cat /sys/class/scsi_host/host1/config >> PARTITIONNAME='x1521p4' >> NWSDNAME='X1

Re: 'Device not ready' issue on mpt2sas since 3.1.10

2012-08-16 Thread Matthias Prager
Am 16.08.2012 20:26, schrieb Robert Trace: > On 07/25/2012 03:55 PM, James Bottomley wrote: >> >> Well, reading it, so do I. Unfortunately, we get to deal with the world >> as it is rather than as we would wish it to be. We likely have this >> problem with a lot of USB SATLs as well ... > > Has

Re: 'Device not ready' issue on mpt2sas since 3.1.10

2012-08-16 Thread Robert Trace
On 08/16/2012 04:24 PM, Matthias Prager wrote: > > Not yet, but it is in James scsi misc tree and last I heard was > scheduled for inclusion in the 3.6 kernel. Close enough. :-) I didn't track the changes on the SCSI tree and I just wanted to make sure that it didn't slip through the cracks. Th

[ANNOUNCE] target-pending tree updated to v3.6-rc2

2012-08-16 Thread Nicholas A. Bellinger
Hi all, With the release of v3.6-rc2 this afternoon, the target-pending.git tree now has been updated using the freshly cut -rc2 as it's new HEAD. Patches destined into for-3.7 code are now being added into for-next for linux-next build testing. Also, thanks go out to MST, Stefan, and Paolo who m

Re: [ANNOUNCE] target-pending tree updated to v3.6-rc2

2012-08-16 Thread Nicholas A. Bellinger
On Thu, 2012-08-16 at 19:43 -0700, Nicholas A. Bellinger wrote: > Hi all, > > With the release of v3.6-rc2 this afternoon, the target-pending.git tree > now has been updated using the freshly cut -rc2 as it's new HEAD. > Patches destined into for-3.7 code are now being added into for-next for > li