[PATCH 0/7] Updates for be2iscsi driver

2012-08-13 Thread John Soni Jose
Patches to update the be2iscsi driver. These patches were generated against the scsi tree "scsi-misc" branch. Removing the iscsi_data_pdu setting. Issue MBX Cmd for login to boot target in crashdump mode Added Logging mechanism for the driver. Format the MAC_ADDR with sysfs_format_mac.

[PATCH 1/7] Removing the iscsi_data_pdu setting.

2012-08-13 Thread John Soni Jose
The setting of iscsi_data_pdu is not required anymore, as this was required for BE1 adapters only. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_main.c | 12 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/drivers/

[PATCH 2/7] Issue MBX Cmd for login to boot target in crashdump mode

2012-08-13 Thread John Soni Jose
When the driver comes up in crashdump mode, it has to explicitly issue command to FW for logging to the boot target. This fix issues MBX Cmd to login to boot target in crashdump mode. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_cmds.h | 18

[PATCH 4/7] Format the MAC_ADDR with sysfs_format_mac.

2012-08-13 Thread John Soni Jose
The MAC_ADDR stored in driver private structure is of unsigned char data type but strlcpy parameters is of signed char data type. This conversion of data types lead to change in the value.This changed value is passed to the upper layer and junk characters were displayed when "iscsiadm -m ifac

[PATCH 5/7] Add support for configuring the VLAN on the adapter.

2012-08-13 Thread John Soni Jose
Add support for configuring the VLAN parameters on the adapter using the iscsiadm interface. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_cmds.c | 43 + drivers/scsi/be2iscsi/be_cmds.h |9 drivers/scsi/be2iscsi/

[PATCH 6/7] Fix a kernel panic because of TCP RST/FIN received.

2012-08-13 Thread John Soni Jose
A TCP RST/FIN can be received even before the connection specific structures are initialized.This fix checks for the conn structure is intialized or not when RST/FIN is received. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_iscsi.c | 51 +++

[PATCH 7/7] Bump the driver version.

2012-08-13 Thread John Soni Jose
Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_main.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h index 152c86f..eae15d4 100644 --- a/drivers/scsi/be2isc

[Bug 16558] iSCSI Connection / Stability Problems

2012-08-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=16558 Alan changed: What|Removed |Added Status|NEW |RESOLVED CC|

[Bug 17551] mpt2sas -- spurious hotplug event causes drive to drop out of JBOD array

2012-08-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=17551 Alan changed: What|Removed |Added Status|NEW |RESOLVED CC|

[Bug 17822] drivers/scsi/ipr.c implicit declaration of function 'writeq'

2012-08-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=17822 Alan changed: What|Removed |Added Status|NEW |RESOLVED CC|

Re: [RFC - PATCH 0/3] SCSI: Initiator based LUN Masking - SCSI mid-layer

2012-08-13 Thread Steffen Maier
Hi Krishna, On 08/11/2012 04:35 AM, kgudi...@brocade.com wrote: The following RFC patch-set adds Initiator based LUN Masking support to SCSI mid-layer and tries to address the feedback we have received to have LUN Masking feature in the SCSI mid-layer and made available

[PATCH] libiscsi: avoid unnecessary multiple NULL assignments

2012-08-13 Thread Masatake YAMATO
In iscsi_free_task, NULL is assigned to task->sc twice: before and after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded with session->lock, so multiple NULL assignments cause no trouble. But people reading the source code may be confused. The second NULL assignment comes from c

Re: FC_PORTSPEED semantics confusion and zfcp regression

2012-08-13 Thread Steffen Maier
Hi Neerav, thanks very much for your quick reply! On 08/09/2012 09:29 PM, Parikh, Neerav wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Steffen Maier Sent: Thursday, August 09, 2012 9:15 AM Lately, commit a9277

Re: [PATCH][SCSI] remove the queue unlock in scsi_requset_fn

2012-08-13 Thread Bart Van Assche
On 08/10/12 03:22, Chanho Min wrote: > We don't need to unlock the queue before put_device in scsi_request_fn() It looks like there is a typo in the patch subject ? Also, you can omit "[SCSI]" from the patch subject - AFAIK James has a script that inserts that text automatically. Bart. -- To uns

[PATCH v2] be2iscsi: cleanup format strings

2012-08-13 Thread Masatake YAMATO
In format strings for printk in be2iscsi, concatenations of constant c strings are used widely. However, the log output is a bit hard to read because whitespaces are missed in the constant c strings like: SE_DEBUG(DBG_LVL_1, "CQ Error %d, reset" "received/sent on CID 0x

Re: [PATCH 1/7] Removing the iscsi_data_pdu setting.

2012-08-13 Thread Michael Christie
On Aug 13, 2012, at 5:29 AM, John Soni Jose wrote: > The setting of iscsi_data_pdu is not required anymore, > as this was required for BE1 adapters only. > Were those released and supported by the upstream kernel in previous kernels? -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] libiscsi: avoid unnecessary multiple NULL assignments

2012-08-13 Thread Mike Christie
On 08/13/2012 06:59 AM, Masatake YAMATO wrote: > In iscsi_free_task, NULL is assigned to task->sc twice: before and > after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded > with session->lock, so multiple NULL assignments cause no trouble. But > people reading the source code ma

Re: [PATCH 2/7] Issue MBX Cmd for login to boot target in crashdump mode

2012-08-13 Thread Mike Christie
On 08/13/2012 05:29 AM, John Soni Jose wrote: > When the driver comes up in crashdump mode, it has to explicitly > issue command to FW for logging to the boot target. This fix issues > MBX Cmd to login to boot target in crashdump mode. > > Signed-off-by: John Soni Jose > Signed-off-by: Jayamoh

Re: [PATCH 5/7] Add support for configuring the VLAN on the adapter.

2012-08-13 Thread Mike Christie
On 08/13/2012 05:30 AM, John Soni Jose wrote: > > +/** > + * beiscsi_set_vlan_attrib : Set the VLAN priority > + * @shost : Scsi_Host pointer for the function. extra space. > + case ISCSI_NET_PARAM_VLAN_ID: > + if (if_info.vlan_priority == BEISCSI_VLAN_DISABLE) > +

RE: [RFC - PATCH 0/3] SCSI: Initiator based LUN Masking - SCSI mid-layer

2012-08-13 Thread Krishna Gudipati
Hi Steffen, Thanks for reviewing the design, please find my responses in line with tag [KRISHNA]. Thanks, Krishna. > From: Steffen Maier [mailto:ma...@linux.vnet.ibm.com] > On 08/11/2012 04:35 AM, kgudi...@brocade.com wrote: > > (LUN masked = LUN to be made visible) > > This terminology defini