Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-08 Thread Bart Van Assche
On 08/08/12 03:42, Chanho Min wrote: > Thank you for the explanation. It look correct. Let's check one more thing. > What If __scsi_remove_device doesn't release device? : reference count > is more than 2. > So We lost starved_list but device is exist. Is there any issue about this? As far as I ca

[PATCH 1/2] scsi: Use GFP_ATOMIC in kzalloc().

2012-08-08 Thread Vladimir Gratinskiy
Calling memory allocation function from the context of interrupt: request_irq(mhba->pdev->irq, mvumi_isr_handler, IRQF_SHARED, "mvumi", mhba); Function mvumi_isr_handler() calls mvumi_handshake(mhba) that calls mvumi_init_data(mhba). In mvumi_init_data() there is function mvumi_alloc_mem_resource(m

[PATCH] scsi_dh_rdac: Add empty set_params function to scsi_dh_rdac

2012-08-08 Thread Moger, Babu
This patch adds empty set_params function to scsi_dh_rdac. This patch is required for the following features to work properly. 1. add retain_attached_hw_handler feature http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=a58a935d5a1b2ad267017a68c3a1bca26226cc76 2. add scsi_d

Re: scsi_dh_rdac: Add empty set_params function to scsi_dh_rdac

2012-08-08 Thread Mike Snitzer
On Wed, Aug 08 2012 at 12:10pm -0400, Moger, Babu wrote: > This patch adds empty set_params function to scsi_dh_rdac. > > This patch is required for the following features to work properly. > 1. add retain_attached_hw_handler feature > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux

RE: scsi_dh_rdac: Add empty set_params function to scsi_dh_rdac

2012-08-08 Thread Moger, Babu
> -Original Message- > From: Mike Snitzer [mailto:snit...@redhat.com] > Sent: Wednesday, August 08, 2012 2:31 PM > To: Moger, Babu > Cc: linux-scsi; device-mapper development (dm-de...@redhat.com) > Subject: Re: scsi_dh_rdac: Add empty set_params function to scsi_dh_rdac > > On Wed, Aug 08