[patch] target: NULL dereference on error path

2012-07-20 Thread Dan Carpenter
We called destroy_workqueue(dev->tmr_wq) before ->tmr_wq was allocated which leads to an oops. Signed-off-by: Dan Carpenter diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 7647eca..0eaae23 100644 --- a/drivers/target/target_core_transport.c +++

[patch] [SCSI] aic79xx: NULL dereference in debug code

2012-07-20 Thread Dan Carpenter
"ahd" can be NULL here and it gets dereferenced inside the call to ahd_name(). Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c index 25417d0..5db8925 100644 --- a/drivers/scsi/aic7xxx/aic79xx_core.c +++ b/drivers/scsi/aic7xxx/a

Re: [RFC-v3 4/4] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-20 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 02:20:58PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2012-07-18 at 19:09 +0300, Michael S. Tsirkin wrote: > > On Wed, Jul 18, 2012 at 12:59:32AM +, Nicholas A. Bellinger wrote: > > > > > > > > > Changelog v2 -> v3: > > > > > > Unlock on error in tcm_vhost_drop

[Bug 16070] Fail to issue Start/Stop Unit

2012-07-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=16070 Alan changed: What|Removed |Added Status|NEW |RESOLVED CC|

Re: [patch] [SCSI] aic79xx: NULL dereference in debug code

2012-07-20 Thread Hannes Reinecke
On 07/20/2012 01:30 PM, Dan Carpenter wrote: > "ahd" can be NULL here and it gets dereferenced inside the call to > ahd_name(). > > Signed-off-by: Dan Carpenter > Acked-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de

[PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-07-20 Thread Paolo Bonzini
These commands cannot be issued right now without giving CAP_SYS_RAWIO to the process who wishes to send them. These commands can be useful also to non-privileged programs who have access to the block devices. For example a virtual machine monitor needs them to forward trim/discard to host disks.

Re: [RFC-v3 4/4] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-20 Thread Nicholas A. Bellinger
On Fri, 2012-07-20 at 15:03 +0300, Michael S. Tsirkin wrote: > On Wed, Jul 18, 2012 at 02:20:58PM -0700, Nicholas A. Bellinger wrote: > > On Wed, 2012-07-18 at 19:09 +0300, Michael S. Tsirkin wrote: > > > On Wed, Jul 18, 2012 at 12:59:32AM +, Nicholas A. Bellinger wrote: > > > > > > > > > >

Re: [RFC-v3 4/4] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-20 Thread Nicholas A. Bellinger
On Fri, 2012-07-20 at 11:00 -0700, Nicholas A. Bellinger wrote: > On Fri, 2012-07-20 at 15:03 +0300, Michael S. Tsirkin wrote: > > On Wed, Jul 18, 2012 at 02:20:58PM -0700, Nicholas A. Bellinger wrote: > > > On Wed, 2012-07-18 at 19:09 +0300, Michael S. Tsirkin wrote: > > > > On Wed, Jul 18, 2012 a

Re: [patch] target: NULL dereference on error path

2012-07-20 Thread Nicholas A. Bellinger
On Fri, 2012-07-20 at 10:07 +0300, Dan Carpenter wrote: > We called destroy_workqueue(dev->tmr_wq) before ->tmr_wq was allocated > which leads to an oops. > > Signed-off-by: Dan Carpenter > Looks good. Applied to for-next w/ a comment pointing to: commit af8772926f019b7bddd7477b8de5f3b0f12ba

[PATCH] [RFC] [SCSI] mpt fusion: add support for 0x1000/0x0055

2012-07-20 Thread Jiri Kosina
The device identifies itself as 0d:05.0 SCSI storage controller: LSI Logic / Symbios Logic SAS1068 PCI-X Fusion-MPT SAS (rev 01) Subsystem: NEC Corporation SAS1068 and seems to be functionally compatible with 0x0054 PID. The request for support of this device has been raised on mailinglists sev

Re: question about path_id of scsi hard disk

2012-07-20 Thread James Bottomley
On Fri, 2012-07-20 at 16:24 +0800, gaoqiang wrote: > I'm using udev to manage my hard disks. but I'm confusing > about the "PATH_ID" > > gaoqiang@h150:~$/lib/udev/path_id /block/sda > ID_PATH=pci-:01:00.0-scsi-0:0:0:0 > > the path_id is about disk or about disk slot ? Neither: it's pci func

[PATCH] tmscsim: spin_unlock_irq in interrupt handler fix

2012-07-20 Thread Denis Efremov
The replacement of spin_lock_irq/spin_unlock_irq pair in interrupt handler by spin_lock_irqsave/spin_lock_irqrestore pair. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Denis Efremov --- drivers/scsi/tmscsim.c |5 +++-- 1 files changed, 3 insertions(+), 2 del

[RFC-v4 0/3] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-20 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi MST, Greg-KH & Co, The following is -v4 of the in-flight TCM vhost fabric driver for-3.6 code. This series has been rebased into target-pending.git/for-next-merge this evening, and the changelog over the last days from v3 -> v4 has been: *) Rename vhost_vring_tar

[RFC-v4 1/3] vhost: Separate vhost-net features from vhost features

2012-07-20 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi In order for other vhost devices to use the VHOST_FEATURES bits the vhost-net specific bits need to be moved to their own VHOST_NET_FEATURES constant. (Asias: Update drivers/vhost/test.c to use VHOST_NET_FEATURES) Signed-off-by: Stefan Hajnoczi Cc: Zhi Yong Wu Cc: Michae

[RFC-v4 2/3] vhost: make vhost work queue visible

2012-07-20 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi The vhost work queue allows processing to be done in vhost worker thread context, which uses the owner process mm. Access to the vring and guest memory is typically only possible from vhost worker context so it is useful to allow work to be queued directly by users. Curren

[RFC-v4 3/3] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-20 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds the initial code for tcm_vhost, a Vhost level TCM fabric driver for virtio SCSI initiators into KVM guest. This code is currently up and running on v3.5-rc2 host+guest along with the virtio-scsi vdev->scan() patch to allow a proper scsi_scan_host() to occ