Re: [PATCH RESEND 0/3] scsi: fix internal write cache issue on usb hdd.

2012-07-17 Thread James Bottomley
On Mon, 2012-07-16 at 16:48 -0700, Greg KH wrote: > On Sat, Jul 07, 2012 at 11:04:45PM -0400, Namjae Jeon wrote: > > From: Namjae Jeon > > > > The numbers of USB HDDs(All USB HDD I checked) does not respond > > correctly to scsi mode sense command for retrieving the write cache > > page status. E

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread James Bottomley
On Mon, 2012-07-16 at 19:20 +0200, Paolo Bonzini wrote: > Il 16/07/2012 18:18, James Bottomley ha scritto: > >> > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c > >> > index b583277..6d8ca08 100644 > >> > --- a/drivers/scsi/scsi_lib.c > >> > +++ b/drivers/scsi/scsi_lib.c > >> > @@ -

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread Paolo Bonzini
Il 17/07/2012 09:45, James Bottomley ha scritto: > On Mon, 2012-07-16 at 19:20 +0200, Paolo Bonzini wrote: >> Il 16/07/2012 18:18, James Bottomley ha scritto: > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c > index b583277..6d8ca08 100644 > --- a/drivers/scsi/scsi_lib.c

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread James Bottomley
On Tue, 2012-07-17 at 10:34 +0200, Paolo Bonzini wrote: > Il 17/07/2012 09:45, James Bottomley ha scritto: > > On Mon, 2012-07-16 at 19:20 +0200, Paolo Bonzini wrote: > >> Il 16/07/2012 18:18, James Bottomley ha scritto: > > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c > >

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread Paolo Bonzini
Il 17/07/2012 10:40, James Bottomley ha scritto: >> > >> > It's not specific to virtio-scsi, in fact I expect that virtio-scsi will >> > be almost always used with non-removable disks. >> > >> > However, QEMU's SCSI target is not used just for virtio-scsi (for >> > example it can be used for USB

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread James Bottomley
On Tue, 2012-07-17 at 10:54 +0200, Paolo Bonzini wrote: > Il 17/07/2012 10:40, James Bottomley ha scritto: > >> > > >> > It's not specific to virtio-scsi, in fact I expect that virtio-scsi will > >> > be almost always used with non-removable disks. > >> > > >> > However, QEMU's SCSI target is not

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread Paolo Bonzini
Il 17/07/2012 11:11, James Bottomley ha scritto: > We don't do stuff just because the standards allows it; just the > opposite: we try to use the smallest implementations from the standards > we can get away with just because the more things we do, the more > exceptions and broken devices we come a

[PATCH] [scsi] mpt2sas: Description Patch

2012-07-17 Thread sreekanth.reddy
Please consider this patch set for next kernel release. Signed-off-by: Sreekanth Reddy --- [PATCH 01/09] [SCSI] mpt2sas : 2012 source code copyright. [PATCH 02/09] [SCSI] mpt2sas : To include more Intel Branding. [PATCH 03/09] [SCSI] mpt2sas : Fix for Driver oops, when loading driver with max_q

[PATCH 01/09] [SCSI] mpt2sas : 2012 source code copyright

2012-07-17 Thread sreekanth.reddy
2012 source code copyright - The Copyright String in all the drivers sources were changed to 2012 Signed-off-by: Sreekanth Reddy --- diff --git a/drivers/scsi/mpt2sas/Kconfig b/drivers/scsi/mpt2sas/Kconfig index bbb7e4b..39f08dd 100644 --- a/drivers/scsi/mpt2sas/Kconfig +++ b/drivers/sc

[PATCH 02/09] [SCSI] mpt2sas : To include more Intel Branding

2012-07-17 Thread sreekanth.reddy
Updating the customer branding string for "SSD 910 Series" controller Signed-off-by: Sreekanth Reddy --- diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c index e68deff..ffa32ad 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_base.c +++ b/drivers/scsi/mpt2sas/mpt2

[PATCH 04/09] [SCSI] mpt2sas : Provide sysfs attribute to report Backup Rail Monitor Status

2012-07-17 Thread sreekanth.reddy
A new sysfs shost attribute called "BMR_status" is implemented to report Backup Rail Monitor status. This attribute is located in the path /sys/class/scsi_host/host#/BMR_status when reading this adapter attribute, then driver will output the state of GPIO[24]. It returns "0" if BMR is hea

[PATCH 05/09] [SCSI] mpt2sas : Fix for max_sectors warning message is stating the incorrect range

2012-07-17 Thread sreekanth.reddy
When specifying the command line option "max_sectors" less than 64, then warning message should provide correct upper boundary value 32767 instead of 8192. Signed-off-by: Sreekanth Reddy --- diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c index 0f4f971..

[PATCH 06/09] [SCSI] mpt2sas : MPI next revision header update

2012-07-17 Thread sreekanth.reddy
MPI 2.0 Rev V(2.0.14) specification Changeset in MPI 2.0 Rev V(2.0.14) specification 1) Bumped MPI2_HEADER_VERSION_UNIT. 2) Added a product specific range to event values. 3) Added clarification to Direct-Attached SAS PHY Power condition. 4) Updated timing r

[PATCH 07/09] [SCSI] mpt2sas : Fix for staged device discovery functionality of driver not working

2012-07-17 Thread sreekanth.reddy
This patch provides a command line option to disable "Port enable" during the driver load. The objective of this command line option is to load the driver and do all the necessary initialization excluding port enable(i.e. delay device discovery) Signed-off-by: Sreekanth Reddy --- diff --git a/d

[PATCH 08/09] [SCSI] mpt2sas : Fix for With post diag reset same set of device gets added, removed and then again gets added with new target ids

2012-07-17 Thread sreekanth.reddy
When device discovery is disabled during driver load time using module parameter "disable_discovery=1" and when diag reset is issued then from logs, it is observed that the devices get added, removed and then added with new target ids. So, inorder to limit this turn-off the code which is deleting

[PATCH 09/09] [SCSI] mpt2sas : Bump driver vesion to 14.100.00.00

2012-07-17 Thread sreekanth.reddy
Bump driver version to 14.100.00.00 Signed-off-by: Sreekanth Reddy --- diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.h b/drivers/scsi/mpt2sas/mpt2sas_base.h index dd05d24..e7e517a 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_base.h +++ b/drivers/scsi/mpt2sas/mpt2sas_base.h @@ -69,8 +69,8 @@ #def

[PATCH 03/09] [SCSI] mpt2sas : Fix for Driver oops, when loading driver with max_queue_depth command line option to a very small value

2012-07-17 Thread sreekanth.reddy
If the specified max_queue_depth setting is less than the expected number of internal commands, then driver will calculate the queue depth size to a negitive number. This negitive number is actually a very large number because variable is unsigned 16bit integer. So, the driver will ask for a very l

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread James Bottomley
On Tue, 2012-07-17 at 11:28 +0200, Paolo Bonzini wrote: > Il 17/07/2012 11:11, James Bottomley ha scritto: > > We don't do stuff just because the standards allows it; just the > > opposite: we try to use the smallest implementations from the standards > > we can get away with just because the more

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread Paolo Bonzini
Il 17/07/2012 14:21, James Bottomley ha scritto: >> Yes, I realize failing only on specific sense codes as I did it in the >> patch is not going to work. However, the other way round is not >> problematic (explicitly allow some sense codes, fail on all others). > > Heh, I once thought that, but t

Re: [PATCH 1/3] ipr: Reduce queuecommand lock time

2012-07-17 Thread Brian King
On 07/16/2012 09:03 PM, Matthew Wilcox wrote: > On Mon, Jul 16, 2012 at 03:48:08PM -0500, Brian King wrote: >> +static int ipr_queuecommand(struct Scsi_Host *shost, >> +struct scsi_cmnd *scsi_cmd) >> { >> struct ipr_ioa_cfg *ioa_cfg; >> struct ipr_resource_entry *

[PATCHv2 1/3] ipr: Reduce queuecommand lock time

2012-07-17 Thread Brian King
Reduce the amount of time the host lock is held in queuecommand for improved performance. Signed-off-by: Brian King --- drivers/scsi/ipr.c | 90 + 1 file changed, 63 insertions(+), 27 deletions(-) diff -puN drivers/scsi/ipr.c~ipr_reduce_lo

[PATCHv2 2/3] ipr: Reduce interrupt lock time

2012-07-17 Thread Brian King
Reduce the amount of time the host lock is held in the interrupt handler for improved performance. Signed-off-by: Brian King --- drivers/scsi/ipr.c | 60 - drivers/scsi/ipr.h |1 2 files changed, 47 insertions(+), 14 deletions(-) diff

Re: [PATCH 13/15] ib_srp: Allow SRP disconnect through sysfs

2012-07-17 Thread bart
> On 03/25/2012 09:01 AM, Bart Van Assche wrote: >> +static void srp_rport_delete(struct srp_rport *rport) >> +{ >> +struct srp_target_port *target = rport->lld_data; >> + >> +BUG_ON(!target); >> + > > I don't think this null check is needed, because below you set the > lld_data before you

[PATCHv2 3/3] ipr: Driver version 2.5.4

2012-07-17 Thread Brian King
Bump driver version. Signed-off-by: Brian King --- drivers/scsi/ipr.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/scsi/ipr.h~ipr_version_2_5_4 drivers/scsi/ipr.h --- linux-2.6/drivers/scsi/ipr.h~ipr_version_2_5_4 2012-07-11 16:40:34.0 -0500 +++

Re: [PATCH 17/18] srp_transport: Add transport layer recovery support

2012-07-17 Thread bart
> On Mon, 2012-07-16 at 18:07 -0400, Mike Christie wrote: >> On 01/14/2012 05:56 AM, Bart Van Assche wrote: >> > Add the necessary functions in the SRP transport module to allow >> > an SRP initiator driver to implement transport layer recovery. >> >> I was updating my iscsi dev loss patch when I s

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread James Bottomley
On Tue, 2012-07-17 at 14:31 +0200, Paolo Bonzini wrote: > Il 17/07/2012 14:21, James Bottomley ha scritto: > >> Yes, I realize failing only on specific sense codes as I did it in the > >> patch is not going to work. However, the other way round is not > >> problematic (explicitly allow some sense

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-17 Thread Michael S. Tsirkin
On Wed, Jul 11, 2012 at 09:15:00PM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi folks, > > The following is a RFC-v2 series of tcm_vhost target fabric driver code > currently in-flight for-3.6 mainline code. > > After last week's developments along with the help of some

Re: [PATCH RESEND 0/5] Add vhost-blk support

2012-07-17 Thread Michael S. Tsirkin
On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote: > > Hi folks, > > [I am resending to fix the broken thread in the previous one.] > > This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk > device accelerator. Compared to userspace virtio-blk implementation, vhost-bl

Re: [PATCH RESEND 0/3] scsi: fix internal write cache issue on usb hdd.

2012-07-17 Thread Greg KH
On Tue, Jul 17, 2012 at 08:19:14AM +0100, James Bottomley wrote: > On Mon, 2012-07-16 at 16:48 -0700, Greg KH wrote: > > On Sat, Jul 07, 2012 at 11:04:45PM -0400, Namjae Jeon wrote: > > > From: Namjae Jeon > > > > > > The numbers of USB HDDs(All USB HDD I checked) does not respond > > > correctly

Re: [PATCH 5/7] target: Check sess_tearing_down in target_get_sess_cmd()

2012-07-17 Thread Roland Dreier
On Mon, Jul 16, 2012 at 6:56 PM, Nicholas A. Bellinger wrote: >> Do you have a plan for how to handle this? Do we really want to plumb >> through another callback to tell the fabric driver to free the command >> in this case? > I need to think more about this ahead of changing it back again for-

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread Christoph Hellwig
On Tue, Jul 17, 2012 at 10:11:57AM +0100, James Bottomley wrote: > There's no such thing in the market today as a removable disk that's > resizeable. Removable disks are for things like backup cartridges and > ageing jazz drives. Worse: most removeable devices today are USB card > readers whose s

Re: [PATCH 5/7] target: Check sess_tearing_down in target_get_sess_cmd()

2012-07-17 Thread Christoph Hellwig
On Tue, Jul 17, 2012 at 09:34:49AM -0700, Roland Dreier wrote: > Sleeping on things, I now feel pretty strongly that having target_submit_cmd > return an error value for "immediate" errors where the command does not > make it into the target core is the right approach. I think it is. When I tried

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread Paolo Bonzini
Il 17/07/2012 18:36, Christoph Hellwig ha scritto: >> > There's no such thing in the market today as a removable disk that's >> > resizeable. Removable disks are for things like backup cartridges and >> > ageing jazz drives. Worse: most removeable devices today are USB card >> > readers whose sta

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread Christoph Hellwig
On Tue, Jul 17, 2012 at 06:47:15PM +0200, Paolo Bonzini wrote: > Il 17/07/2012 18:36, Christoph Hellwig ha scritto: > >> > There's no such thing in the market today as a removable disk that's > >> > resizeable. Removable disks are for things like backup cartridges and > >> > ageing jazz drives. W

Re: 'Device not ready' issue on mpt2sas since 3.1.10

2012-07-17 Thread Tejun Heo
Hello, On Wed, Jul 11, 2012 at 03:48:00PM +0200, Matthias Prager wrote: > I just tested kernel version 3.4.4 without commit > 85ef06d1d252f6a2e73b678591ab71caad4667bb and it also works fine (beware > of commit 62d3c5439c534b0e6c653fc63e6d8c67be3a57b1 as it conflicts with > reverting 85ef06d1d252f6

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread Mike Christie
On 07/17/2012 10:47 AM, Paolo Bonzini wrote: > Il 17/07/2012 18:36, Christoph Hellwig ha scritto: There's no such thing in the market today as a removable disk that's resizeable. Removable disks are for things like backup cartridges and ageing jazz drives. Worse: most removeable de

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread Mike Christie
On 07/17/2012 12:45 PM, Mike Christie wrote: > On 07/17/2012 10:47 AM, Paolo Bonzini wrote: >> Il 17/07/2012 18:36, Christoph Hellwig ha scritto: > There's no such thing in the market today as a removable disk that's > resizeable. Removable disks are for things like backup cartridges and >

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-17 Thread Anthony Liguori
On 07/17/2012 10:05 AM, Michael S. Tsirkin wrote: On Wed, Jul 11, 2012 at 09:15:00PM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger Hi folks, The following is a RFC-v2 series of tcm_vhost target fabric driver code currently in-flight for-3.6 mainline code. After last week's deve

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-17 Thread Michael S. Tsirkin
On Tue, Jul 17, 2012 at 01:55:42PM -0500, Anthony Liguori wrote: > On 07/17/2012 10:05 AM, Michael S. Tsirkin wrote: > >On Wed, Jul 11, 2012 at 09:15:00PM +, Nicholas A. Bellinger wrote: > >>From: Nicholas Bellinger > >> > >>Hi folks, > >> > >>The following is a RFC-v2 series of tcm_vhost targe

Re: [PATCH 5/7] target: Check sess_tearing_down in target_get_sess_cmd()

2012-07-17 Thread Andy Grover
On 07/17/2012 09:39 AM, Christoph Hellwig wrote: > On Tue, Jul 17, 2012 at 09:34:49AM -0700, Roland Dreier wrote: >> Sleeping on things, I now feel pretty strongly that having target_submit_cmd >> return an error value for "immediate" errors where the command does not >> make it into the target cor

Re: 'Device not ready' issue on mpt2sas since 3.1.10

2012-07-17 Thread Matthias Prager
Hello Tejun, Am 17.07.2012 20:09, schrieb Tejun Heo: > Hello, > > On Wed, Jul 11, 2012 at 03:48:00PM +0200, Matthias Prager wrote: >> I'm trying to understand why this commit leads to the issue of i/o >> failing on spun down drives, in hopes of being able to fix it. Meanwhile >> maybe Tejun Heo (

Re: 'Device not ready' issue on mpt2sas since 3.1.10

2012-07-17 Thread Tejun Heo
Hello, On Tue, Jul 17, 2012 at 09:39:41PM +0200, Matthias Prager wrote: > I could not however reproduce the issue on any other device than a LSI > SAS controller (using SATA disks) - on a regular ICH10 using AHCI and a > SATA drive I don't see these i/o errors. But since I'm experiencing > these i

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread Paolo Bonzini
Il 17/07/2012 20:49, Mike Christie ha scritto: > > Not sure if we are talking about the same thing. > > > > So can virtio-scsi send a UA with asc/ascq that indicates the lun > > changed size? Other drivers do this. I updated Hannes's patches the > > other day to support UAs like those in userspace

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-17 Thread Nicholas A. Bellinger
On Tue, 2012-07-17 at 18:05 +0300, Michael S. Tsirkin wrote: > On Wed, Jul 11, 2012 at 09:15:00PM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Hi folks, > > > > The following is a RFC-v2 series of tcm_vhost target fabric driver code > > currently in-flight for-3.6 mai

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-17 Thread Michael S. Tsirkin
On Tue, Jul 17, 2012 at 02:17:22PM -0700, Nicholas A. Bellinger wrote: > On Tue, 2012-07-17 at 18:05 +0300, Michael S. Tsirkin wrote: > > On Wed, Jul 11, 2012 at 09:15:00PM +, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger > > > > > > Hi folks, > > > > > > The following is a RFC

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-17 Thread Nicholas A. Bellinger
On Tue, 2012-07-17 at 13:55 -0500, Anthony Liguori wrote: > On 07/17/2012 10:05 AM, Michael S. Tsirkin wrote: > > On Wed, Jul 11, 2012 at 09:15:00PM +, Nicholas A. Bellinger wrote: > > > > It still seems not 100% clear whether this driver will have major > > userspace using it. And if not, i

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-17 Thread Michael S. Tsirkin
On Tue, Jul 17, 2012 at 02:17:22PM -0700, Nicholas A. Bellinger wrote: > Wrt to staging, I'd like to avoid mucking with staging because: > > *) The code has been posted for review > *) The code has been converted to use the latest target-core primitives > *) The code does not require cleanups betw

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

2012-07-17 Thread James Bottomley
On Tue, 2012-07-17 at 12:36 -0400, Christoph Hellwig wrote: > On Tue, Jul 17, 2012 at 10:11:57AM +0100, James Bottomley wrote: > > There's no such thing in the market today as a removable disk that's > > resizeable. Removable disks are for things like backup cartridges and > > ageing jazz drives.

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-17 Thread Nicholas A. Bellinger
On Wed, 2012-07-18 at 00:34 +0300, Michael S. Tsirkin wrote: > On Tue, Jul 17, 2012 at 02:17:22PM -0700, Nicholas A. Bellinger wrote: > > On Tue, 2012-07-17 at 18:05 +0300, Michael S. Tsirkin wrote: > > > On Wed, Jul 11, 2012 at 09:15:00PM +, Nicholas A. Bellinger wrote: > > > > From: Nicholas

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-17 Thread Nicholas A. Bellinger
On Wed, 2012-07-18 at 00:58 +0300, Michael S. Tsirkin wrote: > On Tue, Jul 17, 2012 at 02:17:22PM -0700, Nicholas A. Bellinger wrote: > > Wrt to staging, I'd like to avoid mucking with staging because: > > > > *) The code has been posted for review > > *) The code has been converted to use the lat

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-17 Thread Michael S. Tsirkin
On Tue, Jul 17, 2012 at 03:02:08PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2012-07-18 at 00:34 +0300, Michael S. Tsirkin wrote: > > On Tue, Jul 17, 2012 at 02:17:22PM -0700, Nicholas A. Bellinger wrote: > > > On Tue, 2012-07-17 at 18:05 +0300, Michael S. Tsirkin wrote: > > > > On Wed, Jul 11,

Re: [Bug 44771] [REGRESSION] a7a20d103994fd760766e6c9d494daa569cbfe06 makes kernel 3.5 unbootable on an Intel chipset based motherboard

2012-07-17 Thread James Bottomley
On Tue, 2012-07-17 at 12:51 -0700, Linus Torvalds wrote: > Wrong people cc'd, it looks like. > > Guys, commit a7a20d103994 ("sd: limit the scope of the async probe > domain") is causing boot problems. It's timing-dependent and > apparently sometimes works, which makes sense with that commit. > >

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-17 Thread Nicholas A. Bellinger
On Wed, 2012-07-18 at 01:18 +0300, Michael S. Tsirkin wrote: > On Tue, Jul 17, 2012 at 03:02:08PM -0700, Nicholas A. Bellinger wrote: > > On Wed, 2012-07-18 at 00:34 +0300, Michael S. Tsirkin wrote: > > > On Tue, Jul 17, 2012 at 02:17:22PM -0700, Nicholas A. Bellinger wrote: > > > > On Tue, 2012-07

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-17 Thread Michael S. Tsirkin
On Tue, Jul 17, 2012 at 03:37:20PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2012-07-18 at 01:18 +0300, Michael S. Tsirkin wrote: > > On Tue, Jul 17, 2012 at 03:02:08PM -0700, Nicholas A. Bellinger wrote: > > > On Wed, 2012-07-18 at 00:34 +0300, Michael S. Tsirkin wrote: > > > > On Tue, Jul 17,

Re: [PATCH 5/7] target: Check sess_tearing_down in target_get_sess_cmd()

2012-07-17 Thread Nicholas A. Bellinger
On Tue, 2012-07-17 at 09:34 -0700, Roland Dreier wrote: > On Mon, Jul 16, 2012 at 6:56 PM, Nicholas A. Bellinger > wrote: > >> Do you have a plan for how to handle this? Do we really want to plumb > >> through another callback to tell the fabric driver to free the command > >> in this case? > >

[PATCH] target: Allow for target_submit_cmd() returning errors

2012-07-17 Thread Nicholas A. Bellinger
From: Roland Dreier We want it to be possible for target_submit_cmd() to return errors up to its fabric module callers. For now just update the prototype to return an int, and update all callers to handle non-zero return values as an error. This is immediately useful for tcm_qla2xxx to fix a lo

Re: [PATCH] target: Allow for target_submit_cmd() returning errors

2012-07-17 Thread Nicholas A. Bellinger
On Tue, 2012-07-17 at 23:37 +, Nicholas A. Bellinger wrote: > From: Roland Dreier > > We want it to be possible for target_submit_cmd() to return errors up > to its fabric module callers. For now just update the prototype to > return an int, and update all callers to handle non-zero return v

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-17 Thread Nicholas A. Bellinger
On Wed, 2012-07-18 at 02:11 +0300, Michael S. Tsirkin wrote: > On Tue, Jul 17, 2012 at 03:37:20PM -0700, Nicholas A. Bellinger wrote: > > On Wed, 2012-07-18 at 01:18 +0300, Michael S. Tsirkin wrote: > > > On Tue, Jul 17, 2012 at 03:02:08PM -0700, Nicholas A. Bellinger wrote: > > > > On Wed, 2012-07

[RFC-v3 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-17 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi folks, The following is the RFC-v3 series of tcm_vhost target fabric driver code currently in-flight for-3.6 mainline code. With the merge window opening soon, the tcm_vhost code has started seeing time in linux-next. The v2 -> v3 changelog from the last week is cur

[RFC-v3 1/4] vhost: Separate vhost-net features from vhost features

2012-07-17 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi In order for other vhost devices to use the VHOST_FEATURES bits the vhost-net specific bits need to be moved to their own VHOST_NET_FEATURES constant. (Asias: Update drivers/vhost/test.c to use VHOST_NET_FEATURES) Signed-off-by: Stefan Hajnoczi Cc: Zhi Yong Wu Cc: Michae

[RFC-v3 2/4] vhost: make vhost work queue visible

2012-07-17 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi The vhost work queue allows processing to be done in vhost worker thread context, which uses the owner process mm. Access to the vring and guest memory is typically only possible from vhost worker context so it is useful to allow work to be queued directly by users. Curren

[RFC-v3 3/4] vhost: Add vhost_scsi specific defines

2012-07-17 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds the initial vhost_scsi_ioctl() callers for VHOST_SCSI_SET_ENDPOINT and VHOST_SCSI_CLEAR_ENDPOINT respectively, and also adds struct vhost_vring_target that is used by tcm_vhost code when locating target ports during qemu setup. Signed-off-by: Stefan Haj

[RFC-v3 4/4] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-17 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds the initial code for tcm_vhost, a Vhost level TCM fabric driver for virtio SCSI initiators into KVM guest. This code is currently up and running on v3.5-rc2 host+guest along with the virtio-scsi vdev->scan() patch to allow a proper scsi_scan_host() to occ

[PATCH 0/5] megaraid_sas: Updates for scsi for-next

2012-07-17 Thread adam radford
James/linux-scsi, The following patch series for megaraid_sas brings the driver up to v6.18-rc1: 1. Fix Copyright dates. 2. Add throttlequeuedepth module parameter. 3. Add resetwaittime module parameter. 4. Move poll_aen_lock initializer. 5. Version and Changelog update. -Adam -- To unsubscribe

[PATCH 1/5] megaraid_sas: Fix Copyright dates

2012-07-17 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas fixes the Copyright dates. Signed-off-by: Adam Radford diff -Naur scsi/drivers/scsi/megaraid/megaraid_sas_base.c scsi.new/drivers/scsi/megaraid/megaraid_sas_base.c --- scsi/drivers/scsi/megaraid/megaraid_sas_base.c 2012-07-17 14:06:30.

[PATCH 2/5] megaraid_sas: Add throttlequeuedepth module parameter

2012-07-17 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas adds a throttlequeuedepth module parameter. This allows a user to adjust the queue depth of the adapter when throttled due to I/O timeout. Signed-off-by: Adam Radford diff -Naur scsi/drivers/scsi/megaraid/megaraid_sas_base.c scsi.new/drive

[PATCH 3/5] megaraid_sas: Add resetwaittime module parameter

2012-07-17 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas adds support for a resetwaittime module parameter. This allows a user to adjust the wait time in seconds after I/O timeout before resetting the adapter. Signed-off-by: Adam Radford diff -Naur scsi/drivers/scsi/megaraid/megaraid_sas_base.c

[PATCH 4/5] megaraid_sas: Move poll_aen_lock initializer

2012-07-17 Thread adam radford
Cc: stable James/linux-scsi, The following patch from Kashyap Desai for megaraid_sas moves the poll_aen_lock initializer from megasas_probe_one() to megasas_init(). This prevents a crash when a user loads the driver and tries to issue a poll() system call on the ioctl interface with no adapters p

[PATCH 5/5] megaraid_sas: Version and Changelog update

2012-07-17 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas updates the driver version and Documentation/scsi/ChangeLog.megaraid_sas files. Signed-off-by: Adam Radford diff -Naur scsi/Documentation/scsi/ChangeLog.megaraid_sas scsi.new/Documentation/scsi/ChangeLog.megaraid_sas --- scsi/Documentation/

Re: [PATCH RESEND 0/5] Add vhost-blk support

2012-07-17 Thread Asias He
On 07/17/2012 11:09 PM, Michael S. Tsirkin wrote: On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote: Hi folks, [I am resending to fix the broken thread in the previous one.] This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk device accelerator. Compared to usersp

[MINI SUMMIT] SCSI core performance

2012-07-17 Thread Nicholas A. Bellinger
Hi KS-PCs, I'd like to propose a SCSI performance mini-summit to see how interested folks are in helping address the long-term issues that SCSI core is currently facing wrt to multi-lun per host and heavy small block random I/O workloads. I know this would probably be better suited for LSF (for t