[GIT PULL] SCSI fixes for 3.5-rc6

2012-07-11 Thread James Bottomley
This is a set of three fixes for data corruption (libsas task file), oops causing (NULL in scsi_cmd_to_driver) and driver failure (bnx2i). The oops caused by the NULL in scsi_cmd_to_driver() manifests in scsi_eh_send_cmd() and has been seen by several people now. The patch is available here: git:

Re: [dm-devel] [RESEND PATCH 2/3] dm mpath: add 'default_hw_handler' feature

2012-07-11 Thread Alasdair G Kergon
On Wed, Jun 27, 2012 at 08:16:55AM +0200, Hannes Reinecke wrote: > On 06/26/2012 08:32 PM, Mike Snitzer wrote: > > When specifying the feature 'default_hw_handler' multipath will use > > the currently attached hardware handler instead of trying to attach the > > one specified during table load. If

Re: [PATCH 1/1] [SCSI] tcm_qla2xxx: Remove duplicate header file inclusion

2012-07-11 Thread Sachin Kamat
Any comments about this patch? On 22/06/2012, Sachin Kamat wrote: > ctype.h and string.h header files were included more than once. > > Signed-off-by: Sachin Kamat > --- > drivers/scsi/qla2xxx/tcm_qla2xxx.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/s

[PATCH] libfcoe: fix section mismatches

2012-07-11 Thread Heiko Carstens
Fix this warning: WARNING: drivers/scsi/fcoe/libfcoe.o(.init.text+0x7c): Section mismatch in reference from the function init_module() to the function .exit.text:fcoe_transport_exit() libfcoe_init() calls fcoe_transport_exit() which is annotated with __exit which puts it into the exit section.

Re: 'Device not ready' issue on mpt2sas since 3.1.10

2012-07-11 Thread Matthias Prager
Am 11.07.2012 01:27, schrieb Robert Trace: > On 07/09/2012 09:51 PM, Robert Trace wrote: >> >> Huh.. I just retested this and I'm seeing really random behavior. > > Ok, with a refined test I've been able to reliably reproduce this and I > bisected it back to commit 85ef06d1d252f6a2e73b678591ab71c

Re: [PATCH RESUBMIT 2/3] qla2xxx: remove unnecessary reads of PCI_CAP_ID_EXP

2012-07-11 Thread Chad Dupuis
On Tue, 10 Jul 2012, Jon Mason wrote: The PCIE capability offset is saved during PCI bus walking. It will remove an unnecessary search in the PCI configuration space if this value is referenced instead of reacquiring it. Also, pci_is_pcie is a better way of determining if the device is PCIE o

Re: [PATCH RESUBMIT 1/3] qla4xxx: remove unnecessary read of PCI_CAP_ID_EXP

2012-07-11 Thread Vikas Chaudhary
-Original Message- From: Jon Mason To: James Bottomley Cc: scsi , Ravi Anand , Vikas , Dept-Eng iSCSI Driver Subject: [PATCH RESUBMIT 1/3] qla4xxx: remove unnecessary read of PCI_CAP_ID_EXP >The PCIE capability offset is saved during PCI bus walking. It will >remove an unnecessary se

Re: [RESEND PATCH 2/3] dm mpath: add 'default_hw_handler' feature

2012-07-11 Thread Mike Snitzer
On Wed, Jul 11 2012 at 6:27am -0400, Alasdair G Kergon wrote: > On Wed, Jun 27, 2012 at 08:16:55AM +0200, Hannes Reinecke wrote: > > On 06/26/2012 08:32 PM, Mike Snitzer wrote: > > > When specifying the feature 'default_hw_handler' multipath will use > > > the currently attached hardware handler

Re: 'Device not ready' issue on mpt2sas since 3.1.10

2012-07-11 Thread Matthias Prager
I just tested kernel version 3.4.4 without commit 85ef06d1d252f6a2e73b678591ab71caad4667bb and it also works fine (beware of commit 62d3c5439c534b0e6c653fc63e6d8c67be3a57b1 as it conflicts with reverting 85ef06d1d252f6a2e73b678591ab71caad4667bb). I'm trying to understand why this commit leads to t

[PATCH 1/1] aacraid: Series 7 Async. (performance) mode support

2012-07-11 Thread Mahesh Rajashekhara
- Series 7 Async. (performance) mode support added - New scatter/gather list format for Series 7 - Driver converts s/g list to a firmware suitable list for best performance on Series 7, this can be disabled with driver parameter "aac_convert_sgl" for testing purposes - New container read/write c

[Bug 15721] mptsas cannot dectect hotplugged harddisks occasionally

2012-07-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=15721 Alan changed: What|Removed |Added Status|NEW |RESOLVED CC|

Re: [dm-devel] [RESEND PATCH 3/3] dm mpath: add ability to disable partition creation

2012-07-11 Thread Alasdair G Kergon
On Tue, Jun 26, 2012 at 02:32:05PM -0400, Mike Snitzer wrote: > The new 'no_partitions' feature serves as a notifier to kpartx to _not_ > create partitions on these multipath devices. This isn't really multipath-specific so doesn't belong in the target. It could go into dm core, but we already ha

Re: [PATCH RESEND 3/3] usb: storage: update usb devices for write cache quirk in quirk list.

2012-07-11 Thread Amit Sahrawat
Hi James, Please have a look at the patchset and share your opinion. If there is anything more to it - please let us know. Thanks & Regards, Amit Sahrawat On Sun, Jul 8, 2012 at 8:35 AM, Namjae Jeon wrote: > From: Namjae Jeon > > Update information of Seagate Portable HDD and WD My Passport HD

Re: [PATCH v4] virtio-scsi: hotplug support for virtio-scsi

2012-07-11 Thread James Bottomley
On Thu, 2012-07-05 at 11:19 +0200, Paolo Bonzini wrote: > Il 05/07/2012 11:06, Cong Meng ha scritto: > > This patch implements the hotplug support for virtio-scsi. > > When there is a device attached/detached, the virtio-scsi driver will be > > signaled via event virtual queue and it will add/remov

[PATCH] bfa: squelch lockdep complaint with a spin_lock_init

2012-07-11 Thread Kyle McMartin
Spotted this while looking at another issue... INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. Pid: 298, comm: udevd Not tainted 3.3.0 #1 Call Trace: [] __lock_acquire+0x1363/0x1bb0 [] ? __slab_alloc+0

Re: [PATCH] virtio-scsi: Add vdrv->scan for post VIRTIO_CONFIG_S_DRIVER_OK LUN scanning

2012-07-11 Thread James Bottomley
On Fri, 2012-07-06 at 20:15 +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch changes virtio-scsi to use a new virtio_driver->scan() callback > so that scsi_scan_host() can be properly invoked once virtio_dev_probe() has > set add_status(dev, VIRTIO_CONFIG_S_DRIVER_OK)

Re: [PATCH v3 3/5] st: get rid of scsi_tapes array

2012-07-11 Thread Lee Duncan
Kai: Your added patch looks great, and I see you fixed the documentation as well. Thanks for your help. On 07/02/2012 05:16 PM, Lee Duncan wrote: > > On 07/01/2012 01:57 AM, Kai Makisara wrote: >> On Mon, 21 May 2012, Lee Duncan wrote: >> >>> From: Jeff Mahoney >>> >>> st currently allocates a

RE: [PATCH] bfa: squelch lockdep complaint with a spin_lock_init

2012-07-11 Thread Krishna Gudipati
-Original Message- From: Kyle McMartin [mailto:kmcma...@redhat.com] Sent: Wednesday, July 11, 2012 9:43 AM To: linux-scsi@vger.kernel.org Cc: hua...@brocade.com; Krishna Gudipati Subject: [PATCH] bfa: squelch lockdep complaint with a spin_lock_init Spotted this while looking at another is

[RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-11 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi folks, The following is a RFC-v2 series of tcm_vhost target fabric driver code currently in-flight for-3.6 mainline code. After last week's developments along with the help of some new folks, the changelog v1 -> v2 so far looks like: *) Fix drivers/vhost/test.c to u

[RFC-v2 1/4] vhost: Separate vhost-net features from vhost features

2012-07-11 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi In order for other vhost devices to use the VHOST_FEATURES bits the vhost-net specific bits need to be moved to their own VHOST_NET_FEATURES constant. (Asias: Update drivers/vhost/test.c to use VHOST_NET_FEATURES) Signed-off-by: Stefan Hajnoczi Cc: Zhi Yong Wu Cc: Michae

[RFC-v2 2/4] vhost: make vhost work queue visible

2012-07-11 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi The vhost work queue allows processing to be done in vhost worker thread context, which uses the owner process mm. Access to the vring and guest memory is typically only possible from vhost worker context so it is useful to allow work to be queued directly by users. Curren

[RFC-v2 3/4] vhost: Add vhost_scsi specific defines

2012-07-11 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds the initial vhost_scsi_ioctl() callers for VHOST_SCSI_SET_ENDPOINT and VHOST_SCSI_CLEAR_ENDPOINT respectively, and also adds struct vhost_vring_target that is used by tcm_vhost code when locating target ports during qemu setup. Signed-off-by: Stefan Haj

[RFC-v2 4/4] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-11 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds the initial code for tcm_vhost, a Vhost level TCM fabric driver for virtio SCSI initiators into KVM guest. This code is currently up and running on v3.5-rc2 host+guest along with the virtio-scsi vdev->scan() patch to allow a proper scsi_scan_host() to occ

[PATCH-v2] virtio-scsi: Add vdrv->scan for post VIRTIO_CONFIG_S_DRIVER_OK LUN scanning

2012-07-11 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch changes virtio-scsi to use a new virtio_driver->scan() callback so that scsi_scan_host() can be properly invoked once virtio_dev_probe() has set add_status(dev, VIRTIO_CONFIG_S_DRIVER_OK) to signal active virtio-ring operation, instead of from within virtscsi_p

Re: [PATCH] virtio-scsi: Add vdrv->scan for post VIRTIO_CONFIG_S_DRIVER_OK LUN scanning

2012-07-11 Thread Nicholas A. Bellinger
On Wed, 2012-07-11 at 19:37 +0100, James Bottomley wrote: > On Fri, 2012-07-06 at 20:15 +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch changes virtio-scsi to use a new virtio_driver->scan() callback > > so that scsi_scan_host() can be properly invoked once vir

Re: [PATCH 1/1] [SCSI] tcm_qla2xxx: Remove duplicate header file inclusion

2012-07-11 Thread Nicholas A. Bellinger
On Wed, 2012-07-11 at 16:23 +0530, Sachin Kamat wrote: > Any comments about this patch? > Hi Sachin, Applied to target-pending.git/for-next, + queued up for-3.6. Thanks! --nab > On 22/06/2012, Sachin Kamat wrote: > > ctype.h and string.h header files were included more than once. > > > > Sig

[GIT PATCH 0/4] isci update for 3.6

2012-07-11 Thread Dan Williams
James, This is the backlog of the libsas indepedent driver changes for 3.6. Just a small collection of fixlets. Please pull, thanks. -- Dan The following changes since commit f8f5701bdaf9134b1f90e5044a82c66324d2073f: Linux 3.5-rc1 (2012-06-02 18:29:26 -0700) are available in the git repos

[PATCH 1/4] isci: fix isci_pci_probe() generates warning on efi failure path

2012-07-11 Thread Dan Williams
The oem parameter image embedded in the efi variable is at an offset from the start of the variable. However, in the failure path we try to free the 'orom' pointer which is only valid when the paramaters are being read from the legacy option-rom space. Since failure to load the oem parameters is

[PATCH 2/4] isci: fix COMSAS negation timout workaround for WD SAS drives

2012-07-11 Thread Dan Williams
From: Dave Maurer The following patch is a fix for the WD workaround COMSAS negation timeout change. This patch disables the OOB SM when the OOB is placed in reset, which allows the updated COMSAS negation timeout value to take effect. Cc: Dan Thompson Reported-by: Dan Thompson Signed-off-by:

[PATCH 4/4] isci: add a couple __iomem annotations

2012-07-11 Thread Dan Williams
From: Dan Carpenter These are __iomem. Sparse complains if we don't have that. drivers/scsi/isci/phy.c +149 70: warning: incorrect type in initializer (different address spaces) Signed-off-by: Dan Carpenter Signed-off-by: Dan Williams --- drivers/scsi/isci/host.c |2 +- drivers/

[PATCH 3/4] isci: make function declaration match implementation

2012-07-11 Thread Dan Williams
From: Dan Carpenter Sparse complains that we redeclare this with a different type, because in the .c file we use an enum and in the .h file we declare the parameter as a u32. Probably it's best to use an enum in both places. Signed-off-by: Dan Carpenter Signed-off-by: Dan Williams --- driver