Re: [PATCH v2] use dynamically allocated sense buffer

2008-01-17 Thread FUJITA Tomonori
On Wed, 16 Jan 2008 14:35:50 +0200 Benny Halevy <[EMAIL PROTECTED]> wrote: > On Jan. 15, 2008, 17:20 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Tue, 2008-01-15 at 18:23 +0900, FUJITA Tomonori wrote: > >> This is the second version of > >> > >> http://marc.info/?l=linux-scsi&m=1199336

Performance of SCST versus STGT

2008-01-17 Thread Bart Van Assche
Hello, I have performed a test to compare the performance of SCST and STGT. Apparently the SCST target implementation performed far better than the STGT target implementation. This makes me wonder whether this is due to the design of SCST or whether STGT's performance can be improved to the level

Re: Performance of SCST versus STGT

2008-01-17 Thread Vladislav Bolkhovitin
FUJITA Tomonori wrote: On Thu, 17 Jan 2008 10:27:08 +0100 "Bart Van Assche" <[EMAIL PROTECTED]> wrote: Hello, I have performed a test to compare the performance of SCST and STGT. Apparently the SCST target implementation performed far better than the STGT target implementation. This makes me

Re: Performance of SCST versus STGT

2008-01-17 Thread FUJITA Tomonori
On Thu, 17 Jan 2008 10:27:08 +0100 "Bart Van Assche" <[EMAIL PROTECTED]> wrote: > Hello, > > I have performed a test to compare the performance of SCST and STGT. > Apparently the SCST target implementation performed far better than > the STGT target implementation. This makes me wonder whether th

Re: Performance of SCST versus STGT

2008-01-17 Thread FUJITA Tomonori
On Thu, 17 Jan 2008 12:48:28 +0300 Vladislav Bolkhovitin <[EMAIL PROTECTED]> wrote: > FUJITA Tomonori wrote: > > On Thu, 17 Jan 2008 10:27:08 +0100 > > "Bart Van Assche" <[EMAIL PROTECTED]> wrote: > > > > > >>Hello, > >> > >>I have performed a test to compare the performance of SCST and STGT. >

Re: Performance of SCST versus STGT

2008-01-17 Thread Vladislav Bolkhovitin
FUJITA Tomonori wrote: On Thu, 17 Jan 2008 12:48:28 +0300 Vladislav Bolkhovitin <[EMAIL PROTECTED]> wrote: FUJITA Tomonori wrote: On Thu, 17 Jan 2008 10:27:08 +0100 "Bart Van Assche" <[EMAIL PROTECTED]> wrote: Hello, I have performed a test to compare the performance of SCST and STGT. A

Re: Forcing use of sd driver on Suse 10.3 (2.6.22)

2008-01-17 Thread Bill Adair
On Mon, 2008-01-14 at 19:31 +0100, Stefan Richter wrote: > Bill Adair wrote: > > Is there any way under Linux of forcing use of the sd driver for a > > device on the bus instead of sg? > > The INQUIRY data which the SCSI core gets from the device have to > indicate that the device implements SBC

[PATCH] atp870u: don't zero out sense_buffer in queuecommand

2008-01-17 Thread FUJITA Tomonori
LLDs don't need to zero out scsi_cmnd::sense_buffer in queuecommand since scsi-ml does. This is a preparation of the future changes to allocate the sense_buffer only when necessary. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/atp870u.c |1 - 1 files changed, 0 insertio

Re: [Stgt-devel] Performance of SCST versus STGT

2008-01-17 Thread Robin Humble
On Thu, Jan 17, 2008 at 01:34:46PM +0300, Vladislav Bolkhovitin wrote: >Hmm, I can't find which IB hardware did he use and it's declared Gbps >speed. He declared only "Mellanox 4X SDR, switch". What does it mean? SDR is 10Gbit carrier, at most about ~900MB/s data rate. DDR is 20Gbit carrier, at

Re: [Scst-devel] [Stgt-devel] Performance of SCST versus STGT

2008-01-17 Thread Vladislav Bolkhovitin
Robin Humble wrote: On Thu, Jan 17, 2008 at 01:34:46PM +0300, Vladislav Bolkhovitin wrote: Hmm, I can't find which IB hardware did he use and it's declared Gbps speed. He declared only "Mellanox 4X SDR, switch". What does it mean? SDR is 10Gbit carrier, at most about ~900MB/s data rate. DDR

Re: Performance of SCST versus STGT

2008-01-17 Thread Erez Zilber
FUJITA Tomonori wrote: > On Thu, 17 Jan 2008 12:48:28 +0300 > Vladislav Bolkhovitin <[EMAIL PROTECTED]> wrote: > > >> FUJITA Tomonori wrote: >> >>> On Thu, 17 Jan 2008 10:27:08 +0100 >>> "Bart Van Assche" <[EMAIL PROTECTED]> wrote: >>> >>> >>> Hello, I have performed a

Re: [Stgt-devel] Performance of SCST versus STGT

2008-01-17 Thread Bart Van Assche
On Jan 17, 2008 1:29 PM, Robin Humble <[EMAIL PROTECTED]> wrote: > was iscsiadm was pointed at the IP of the IPoIB interface on the target? I > think tgtd requires that. > > how about setting the transport to be iser with eg. > iscsiadm --mode node --targetname --portal :3260 --op > update -n

Re: Performance of SCST versus STGT

2008-01-17 Thread Erez Zilber
>> We didn't run any real performance test with tgt, so I don't have >> numbers yet. I know that Pete got ~900 MB/sec by hacking sgp_dd, so all >> data was read/written to the same block (so it was all done in the >> cache). Pete - am I right? >> >> As already mentioned, he got that with IB SDR ca

Re: 2.6.24-rc8-mm1 Build Failure on scsi driver

2008-01-17 Thread Kamalesh Babulal
Hi Andrew, The kernel build fails with following error drivers/scsi/aha152x.o: In function `aha152x_host_reset_host': /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:1324: multiple definition of `aha152x_host_reset_host' drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.

Re: [PATCH v2] use dynamically allocated sense buffer

2008-01-17 Thread James Bottomley
On Thu, 2008-01-17 at 18:13 +0900, FUJITA Tomonori wrote: > On Wed, 16 Jan 2008 14:35:50 +0200 > Benny Halevy <[EMAIL PROTECTED]> wrote: > > > On Jan. 15, 2008, 17:20 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Tue, 2008-01-15 at 18:23 +0900, FUJITA Tomonori wrote: > > >> This is t

Re: Newer kernel not detecting devices?

2008-01-17 Thread James Bottomley
On Thu, 2008-01-17 at 14:37 +, David wrote: > I have here a server with an LSI SCSI card. On one channel is a tape > changer, on the other an external RAID5 box with a number of disks in. > All worked fine until a recent upgrade and now the disk array is not > recognised. > > The dis

Re: Performance of SCST versus STGT

2008-01-17 Thread Vladislav Bolkhovitin
Erez Zilber wrote: FUJITA Tomonori wrote: On Thu, 17 Jan 2008 12:48:28 +0300 Vladislav Bolkhovitin <[EMAIL PROTECTED]> wrote: FUJITA Tomonori wrote: On Thu, 17 Jan 2008 10:27:08 +0100 "Bart Van Assche" <[EMAIL PROTECTED]> wrote: Hello, I have performed a test to compare th

Newer kernel not detecting devices?

2008-01-17 Thread David
I have here a server with an LSI SCSI card. On one channel is a tape changer, on the other an external RAID5 box with a number of disks in. All worked fine until a recent upgrade and now the disk array is not recognised. The disk array is still recognised on machine startup in the SCSI ca

Re: Forcing use of sd driver on Suse 10.3 (2.6.22)

2008-01-17 Thread James Bottomley
On Thu, 2008-01-17 at 10:53 +, Bill Adair wrote: > On Mon, 2008-01-14 at 19:31 +0100, Stefan Richter wrote: > > Bill Adair wrote: > > > Is there any way under Linux of forcing use of the sd driver for a > > > device on the bus instead of sg? > > > > The INQUIRY data which the SCSI core gets f

[PATCH 8/8] Change SG_ALL to mean "any size"

2008-01-17 Thread Boaz Harrosh
Change the definition of SG_ALL from 255, which was the biggest possible scatter list array in 32 bit ARCHs (minus one who knows why), to be ~0. Which means that LLD has no size limit on number of scatter-list array and the actual size will be determined by upper layers. Also SG_NONE is

[PATCH 7/8] a100u2w: advansys: initio: Wrong use of SG_ALL

2008-01-17 Thread Boaz Harrosh
These drivers used the SG_ALL constant, But actually meant some other define. Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/a100u2w.c |3 +-- drivers/scsi/advansys.c |8 +++- drivers/scsi/initio.c |2 +- 3 files changed, 5 insertions(+), 8 deletions(-)

[PATCH 5/8] arm/scsi: Not sg-chain ready

2008-01-17 Thread Boaz Harrosh
arm-scsi core is not sg-chain ready, so maximum scatterlist supported is SCSI_MAX_SG_SEGMENTS. Define it so, in core, and let all drivers use it for the sg_tablesize in host templates. Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/arm/acornscsi.c |2 +- drivers/scsi/

[PATCH 4/8] wd33c93: Not sg-chain ready

2008-01-17 Thread Boaz Harrosh
wd33c93 core is not sg-chain ready, so maximum scatterlist supported is SCSI_MAX_SG_SEGMENTS. Define it so, in core, and let all drivers use it for the sg_tablesize in host templates. Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/a2091.c |2 +- drivers/scsi/a3000.c

[PATCH 3/8] NCR5380: Not sg-chain ready

2008-01-17 Thread Boaz Harrosh
NCR5380 core is not sg-chain ready, so maximum scatterlist supported is SCSI_MAX_SG_SEGMENTS. Define it so, in core, and let all drivers use it for the sg_tablesize in host templates. Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/NCR5380.h |3 +++ drivers/scsi/

[PATCH 2/8] scsi-drivers Don't use SG_ALL as allocation size

2008-01-17 Thread Boaz Harrosh
below list of drivers have used SG_ALL as a size to preallocate maximum possible command's sg-count. This is no longer possible since the maximum is not set at compile time but as a run time configuration. A better schema can be advised with a more dynamic allocation. Perhaps from a k

[PATCH 1/8] firewire: ieee1394: Move away from SG_ALL

2008-01-17 Thread Boaz Harrosh
SG_ALL wants to be ~0 meaning "any future size". Below group of drivers preallocate a scatter list buffer of max_size, so set that size to be 255 (Like before). A better schema can be advised with a more dynamic allocation. Perhaps from a kmem_cache. List of drivers/files: dr

[patch 0/8] Change SG_ALL to mean "any size"

2008-01-17 Thread Boaz Harrosh
I have scanned through the scsi tree and checked all places that used SG_ALL. Those drivers that where not ready for SG_ALL to mean "any size" where changed to what ever is appropriate for this driver. Mainly 3 groups. Those that meant SG_ALL == 255: [PATCH 1/8] firewire: ieee1394: Move away f

scsi: Drivers not ready for sg-chaining

2008-01-17 Thread Boaz Harrosh
All below drivers are not sg-chain ready do to incomplete software. Once fixed they can move back to SG_ALL. For now they are stuck on SCSI_MAX_SG_SEGMENTS. Affected drivers/files: drivers/scsi/aha152x.c drivers/scsi/esp_scsi.[ch] drivers/scsi/imm.c drivers

Re: [PATCH 2/8] scsi-drivers Don't use SG_ALL as allocation size

2008-01-17 Thread Andrew Vasquez
On Thu, 17 Jan 2008, Boaz Harrosh wrote: > below list of drivers have used SG_ALL as a size to > preallocate maximum possible command's sg-count. > This is no longer possible since the maximum is not > set at compile time but as a run time configuration. > > A better schema can be advis

[PATCH 1/2] aacraid: driver features flags

2008-01-17 Thread Salyzyn, Mark
Feature enhancement, adding a 'flags' entry that will reside in the host controller's tree, with a newline separated list of arbitrary ascii named features that indicate whether the combination of driver and controller has support for said feature. Breaking from the one-line output typical of sy

Re: [PATCH 0/14] qla2xxx: updates for 2.6.24 [8.02.00-k7].

2008-01-17 Thread Andrew Vasquez
On Thu, 17 Jan 2008, James Bottomley wrote: > On Thu, 2008-01-17 at 09:33 -0800, Andrew Vasquez wrote: > > On Thu, 17 Jan 2008, Andrew Vasquez wrote: > > > > > This patchset updates the qla2xxx driver to 8.02.00-k7. > > ... > > > > > > BTW: Small typo in the subject, it's obvious these patches

Re: [PATCH 1/8] firewire: ieee1394: Move away from SG_ALL

2008-01-17 Thread Stefan Richter
Boaz Harrosh wrote: > SG_ALL wants to be ~0 meaning "any future size". > Below group of drivers preallocate a scatter list > buffer of max_size, so set that size to be 255 (Like before). > > A better schema can be advised with a more dynamic allocation. > Perhaps from a kmem_cache. > >

Re: [patch 0/8] Change SG_ALL to mean "any size"

2008-01-17 Thread Stefan Richter
Boaz Harrosh wrote: > Those that meant SG_ALL == 255: > > [PATCH 1/8] firewire: ieee1394: Move away from SG_ALL They simply mean SG_ALL == something, as long as it isn't unreasonably small or large. -- Stefan Richter -=-==--- ---= =---= http://arcgraph.de/sr/ - To unsubscribe from this lis

Re: [PATCH 0/14] qla2xxx: updates for 2.6.24 [8.02.00-k7].

2008-01-17 Thread James Bottomley
On Thu, 2008-01-17 at 09:33 -0800, Andrew Vasquez wrote: > On Thu, 17 Jan 2008, Andrew Vasquez wrote: > > > This patchset updates the qla2xxx driver to 8.02.00-k7. > ... > > > BTW: Small typo in the subject, it's obvious these patches aren't for > 2.6.24, instead, meant for the next merge wind

Re: [PATCH 2/8] scsi-drivers Don't use SG_ALL as allocation size

2008-01-17 Thread Boaz Harrosh
On Thu, Jan 17 2008 at 19:47 +0200, Andrew Vasquez <[EMAIL PROTECTED]> wrote: > On Thu, 17 Jan 2008, Boaz Harrosh wrote: > >> below list of drivers have used SG_ALL as a size to >> preallocate maximum possible command's sg-count. >> This is no longer possible since the maximum is not >> se

[PATCH] qla2xxx: Trace-Control naming cleanups.

2008-01-17 Thread Andrew Vasquez
In preparation for FCE (Fibre Channel Event) tracing support. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_def.h |3 -- drivers/scsi/qla2xxx/qla_fw.h |7 + drivers/scsi/qla2xxx/qla_gbl.h |4 ++- drivers/scsi/qla2xxx/qla_init.c |5 +-- driv

[PATCH] qla2xxx: Issue correct MBC_INITIALIZE_FIRMWARE command.

2008-01-17 Thread Andrew Vasquez
From: Seokmann Ju <[EMAIL PROTECTED]> There is a case where 54xx HBA loads MID firmware as it use 24xx firmware. In this case, the driver should issue MBC_MID_INITIALIZE FIRMWARE even though the HBA doesn't support NPIV. This patch make changes in the driver so that could behave accordingly. Sig

[PATCH] qla2xxx: Code cleanups.

2008-01-17 Thread Andrew Vasquez
From: Adrian Bunk <[EMAIL PROTECTED]> - make the following needlessly global code static: - qla_attr.c: qla24xx_vport_delete() - qla_attr.c: qla24xx_vport_disable() - qla_mid.c: qla24xx_allocate_vp_id() - qla_mid.c: qla24xx_find_vhost_by_name() - qla_mid.c: qla2x00_do_dpc_vp() - qla_os

[PATCH] qla2xxx: Add a filter to compare port_name against the physical on vport creation.

2008-01-17 Thread Andrew Vasquez
From: Seokmann Ju <[EMAIL PROTECTED]> During vport creation, there was a possibility to get create a vport with same port_name as pport. A new filter has added to compare given port_name with the port_name of the pport. Signed-Off-by: Seokmann Ju <[EMAIL PROTECTED]> Signed-off-by: Andrew Vasquez

[PATCH] qla2xxx: Restrict MSI/MSI-X enablement on select ISP2432-type HBAs.

2008-01-17 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_isr.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index 5d2dc92..22216fe 100644 --- a/drivers/scsi/qla2xxx/qla_isr

Re: [PATCH 2/8 ver2] scsi-drivers Don't use SG_ALL as allocation size

2008-01-17 Thread Boaz Harrosh
Subject: [PATCH] scsi-drivers Don't use SG_ALL as allocation size below list of drivers have used SG_ALL as a size to preallocate maximum possible command's sg-count. This is no longer possible since the maximum is not set at compile time but as a run time configuration. A better schema

Re: [PATCH 2/8] scsi-drivers Don't use SG_ALL as allocation size

2008-01-17 Thread Andrew Vasquez
On Thu, 17 Jan 2008, Boaz Harrosh wrote: > > I don't forsee any issues with maintaining SG_ALL (~0) usage within > > qla2xxx and qla4xxx, as the number of unused entries on the HBA's > > request-queue shall ultimately be the rate-limiting factor. > > > > -- > Please forgive me I have forgot to pu

[PATCH] qla2xxx: Wait for FLASH write-protection to complete after a write.

2008-01-17 Thread Andrew Vasquez
Some flash parts have a slow enable write-protection (WP) operation whereby subsequent FLASH accesses would fail if the WP operation had not completed. Software now polls the SPI's status-register for WP completion. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_s

[PATCH] qla2xxx: Retrieve additional HBA port statistics from recent ISPs.

2008-01-17 Thread Andrew Vasquez
HBAs supporting these additional counters include ISP24xx and ISP25xx type boards. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_attr.c | 44 -- drivers/scsi/qla2xxx/qla_def.h | 22 ++--- drivers/scsi/qla2xxx/qla_gbl.h |7 ++- drivers

[PATCH] qla2xxx: Consolidate duplicate sense-data handling codes.

2008-01-17 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_isr.c | 85 ++- 1 files changed, 31 insertions(+), 54 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index 53cbaff..5d2dc92 100644 --- a/

[PATCH] qla2xxx: Fix for 32-bit platforms with 64-bit resources.

2008-01-17 Thread Andrew Vasquez
The driver stores the contents of PCI resources into unsigned long's before ioremapping. This breaks on 32-bit platforms which support 64-bit MMIO resources. Correct code by removing the temporary variables used during MMIO PIO mapping and using resource_size_t where applicable. Also correct a sm

[PATCH 2/2] aacraid: add Voodoo Lite class of cards.

2008-01-17 Thread Salyzyn, Mark
The cards being added are supported in a limited sense already through family matching, but we needed to add some functionality to the driver to expose selectively the physical drives. These Physical drives are specifically marked to not be part of any array and thus are declared JBODs (Just a B

[PATCH] qla2xxx: Don't schedule the DPC routine to perform an issue-lip request.

2008-01-17 Thread Andrew Vasquez
As the driver depends on the DPC routine to handle bottom-half loop resynchronization in order to recover from the issue-lip request. The issue_lip call is sleeping context capable, so just issue the reset function there. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx

[PATCH] qla2xxx: Correct late-memset() of EFT buffer.

2008-01-17 Thread Andrew Vasquez
Original code would clear the buffer after the firmware had already been initialized to use the buffer, thus potentially and inadvertantly clearing data previously DMA'd by the firmware. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_init.c |2 +- 1 files chang

[PATCH] qla2xxx: Update version number to 8.02.00-k7.

2008-01-17 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 6e3dc40..2c2f6b4 100644 --- a/drivers/scsi/qla2xxx/qla_v

[PATCH] qla2xxx: Use completion routines.

2008-01-17 Thread Andrew Vasquez
From: Marcus Barrow <[EMAIL PROTECTED]> Instead of abusing the semaphore interfaces for mailbox command completions. Additional cleanups and Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_def.h |4 +- drivers/scsi/qla2xxx/qla_gbl.h |2 - drivers/scsi/qla2x

[PATCH] qla2xxx: Add Fibre Channel Event (FCE) tracing support.

2008-01-17 Thread Andrew Vasquez
FCE support enables the firmware to record FC extended link services and basic link services frames which have been transmitted and received by the ISP. This allows for a limited view of the FC traffic through the ISP without using a FC analyzer. This can be useful in situations where a physical

Re: 2.6.24-rc8-mm1 Build Failure on scsi driver

2008-01-17 Thread Andrew Morton
On Thu, 17 Jan 2008 21:45:39 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > Hi Andrew, > > The kernel build fails with following error > > drivers/scsi/aha152x.o: In function `aha152x_host_reset_host': > /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:1324: multiple > definiti

Re: [PATCH 0/14] qla2xxx: updates for 2.6.24 [8.02.00-k7].

2008-01-17 Thread Andrew Vasquez
On Thu, 17 Jan 2008, Andrew Vasquez wrote: > This patchset updates the qla2xxx driver to 8.02.00-k7. ... BTW: Small typo in the subject, it's obvious these patches aren't for 2.6.24, instead, meant for the next merge window of 2.6.25... - To unsubscribe from this list: send the line "unsubscrib

Re: Performance of SCST versus STGT

2008-01-17 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Thu, 17 Jan 2008 19:05 +0900: > On Thu, 17 Jan 2008 12:48:28 +0300 > Vladislav Bolkhovitin <[EMAIL PROTECTED]> wrote: > > > FUJITA Tomonori wrote: > > > On Thu, 17 Jan 2008 10:27:08 +0100 > > > "Bart Van Assche" <[EMAIL PROTECTED]> wrote: > > > > > > > > >>Hello, > > >

[PATCH 0/14] qla2xxx: updates for 2.6.24 [8.02.00-k7].

2008-01-17 Thread Andrew Vasquez
This patchset updates the qla2xxx driver to 8.02.00-k7. drivers/scsi/qla2xxx/Makefile |2 +- drivers/scsi/qla2xxx/qla_attr.c| 52 +++-- drivers/scsi/qla2xxx/qla_dbg.c | 37 ++-- drivers/scsi/qla2xxx/qla_dbg.h | 19 ++ drivers/scsi/qla2xxx/qla_def.h | 42 +++-- dri

[PATCH] SCSI st : convert to unlocked_ioctl

2008-01-17 Thread Kai Makisara
007 Kai Makisara + Copyright 1992 - 2008 Kai Makisara email [EMAIL PROTECTED] Some small formal changes - aeb, 950809 @@ -17,7 +17,7 @@ Last modified: 18-JAN-1998 Richard Gooch <[EMAIL PROTECTED]> Devfs support */ -static const char *verstr = "20070203"; +static const char *

Re: [PATCH v2] use dynamically allocated sense buffer

2008-01-17 Thread FUJITA Tomonori
On Thu, 17 Jan 2008 09:58:11 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > On Thu, 2008-01-17 at 18:13 +0900, FUJITA Tomonori wrote: > > On Wed, 16 Jan 2008 14:35:50 +0200 > > Benny Halevy <[EMAIL PROTECTED]> wrote: > > > > > On Jan. 15, 2008, 17:20 +0200, James Bottomley <[EMAIL PROTECTE

[PATCH] aha152x: fix isa/pcmcia compile problem

2008-01-17 Thread Tejun Heo
aha152x.c is built twice - once for the isa driver and once for the PCMCIA one. Through #ifdefs, the compiled codes are slightly different; thus, global symbols need to be given different names depending on which flavor is being built. This patch adds GLOBAL() macro to aha152x.h which changes the

Re: [PATCH] firewire: fw-sbp2: prepare for s/g chaining

2008-01-17 Thread FUJITA Tomonori
On Tue, 15 Jan 2008 21:10:50 +0100 (CET) Stefan Richter <[EMAIL PROTECTED]> wrote: > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > --- > > Replacement of patch "firewire: fw-sbp2: enable s/g chaining". > > It's the same, minus '+ .use_sg_chaining = ENABLE_SG_CHAINING,' hunk > to prevent co

Re: [PATCH] aha152x: fix isa/pcmcia compile problem

2008-01-17 Thread Kamalesh Babulal
On Fri, Jan 18, 2008 at 09:53:16AM +0900, Tejun Heo wrote: > aha152x.c is built twice - once for the isa driver and once for the > PCMCIA one. Through #ifdefs, the compiled codes are slightly > different; thus, global symbols need to be given different names > depending on which flavor is being bu

Re: 2.6.24-rc8-mm1 Build Failure on scsi driver

2008-01-17 Thread Kamalesh Babulal
Andrew Morton wrote: > On Thu, 17 Jan 2008 21:45:39 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > >> Hi Andrew, >> >> The kernel build fails with following error >> >> drivers/scsi/aha152x.o: In function `aha152x_host_reset_host': >> /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x

[PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-17 Thread Tejun Heo
aha152x.c and fdomain are built twice - once for the isa driver and once for the PCMCIA one. Through #ifdefs, the compiled codes are slightly different; thus, global symbols need to be given different names depending on which flavor is being built. This patch adds GLOBAL() macro to aha152x.h and

Re: 2.6.24-rc8-mm1 Build Failure on scsi driver

2008-01-17 Thread Andrew Morton
On Fri, 18 Jan 2008 12:07:27 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > Hi Andrew, > > Patch from Tejun Heo fixes the aha152x.c build failure, and following second > part > of the build failure, is still occurring. > > drivers/scsi/fdomain.o:(.data+0x0): multiple definition of > `fdom

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-17 Thread Kamalesh Babulal
On Fri, Jan 18, 2008 at 04:20:40PM +0900, Tejun Heo wrote: > aha152x.c and fdomain are built twice - once for the isa driver and > once for the PCMCIA one. Through #ifdefs, the compiled codes are > slightly different; thus, global symbols need to be given different > names depending on which flavo