Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-07 Thread Rusty Russell
On Monday 07 January 2008 17:37:41 Tejun Heo wrote: > Rusty Russell wrote: > > Hi Tejun, > > > >Nice try! Even ignoring the ugliness of undoing such an operation if > > the caller doesn't expect you to mangle their chains, consider a > > one-element sg array. :( > > Heh heh, that can be dealt

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread Greg KH
On Mon, Jan 07, 2008 at 10:09:44AM +0800, Dave Young wrote: > > Thanks for your comment, I rewrite it for 2.6.24-rc7 as a all-in-one > patch, please see following. Drop i2c maintainer and list in cc > because there's no changes about i2c in this patch: > > Convert semaphore to mutex in struct cla

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-07 Thread Tejun Heo
Rusty Russell wrote: > On Monday 07 January 2008 17:37:41 Tejun Heo wrote: >> Rusty Russell wrote: >>> Hi Tejun, >>> >>>Nice try! Even ignoring the ugliness of undoing such an operation if >>> the caller doesn't expect you to mangle their chains, consider a >>> one-element sg array. :( >> Heh

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread David Brownell
On Monday 07 January 2008, Greg KH wrote: > Most of the non-driver core code should be converted to not use the > lock in the class at all.  They should use a local lock instead. Or better yet, that yet-to-be-written class_for_each_instance() iterator ... :) - To unsubscribe from this list: send

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread Dave Young
On Jan 7, 2008 4:45 PM, Greg KH <[EMAIL PROTECTED]> wrote: > On Mon, Jan 07, 2008 at 10:09:44AM +0800, Dave Young wrote: > > > > Thanks for your comment, I rewrite it for 2.6.24-rc7 as a all-in-one > > patch, please see following. Drop i2c maintainer and list in cc > > because there's no changes ab

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-07 Thread Herbert Xu
Tejun Heo <[EMAIL PROTECTED]> wrote: > > /me agrees. As long as this can be made sane using one unified > interface, I don't care whether it's sg_ring, table or dish. Give us sg_annulus :) On a more serious note, having played with SG chaining for a couple of years in the crypto layer, I must sa

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread Stefan Richter
David Brownell wrote: > On Monday 07 January 2008, Greg KH wrote: >> Most of the non-driver core code should be converted to not use the >> lock in the class at all. They should use a local lock instead. > > Or better yet, that yet-to-be-written class_for_each_instance() > iterator ... :) By far

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2008-01-07 Thread Boaz Harrosh
On Mon, Jan 07 2008 at 8:53 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > On Sun, 23 Dec 2007 13:09:05 +0200 > Boaz Harrosh <[EMAIL PROTECTED]> wrote: > >> On Fri, Dec 21 2007 at 4:30 +0200, Benjamin Herrenschmidt <[EMAIL >> PROTECTED]> wrote: >>> The sense buffer ins scsi_cmnd can nowadays

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread Jarek Poplawski
On Mon, Jan 07, 2008 at 02:23:33PM +0100, Stefan Richter wrote: > David Brownell wrote: > > On Monday 07 January 2008, Greg KH wrote: > >> Most of the non-driver core code should be converted to not use the > >> lock in the class at all. They should use a local lock instead. > > > > Or better yet

Multipath failover handling (Was: Re: 2.6.24-rc3-mm1)

2008-01-07 Thread Hannes Reinecke
James Bottomley wrote: > On Fri, 2007-12-14 at 10:00 +0100, Hannes Reinecke wrote: >> James Bottomley wrote: >>> On Mon, 2007-11-26 at 22:15 -0800, Andrew Morton wrote: OK, thanks. I'll assume that James and Hannes have this in hand (or will have, by mid-week) and I won't do anything her

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-07 Thread James Bottomley
On Mon, 2008-01-07 at 15:38 +1100, Rusty Russell wrote: > On Sunday 06 January 2008 02:31:12 James Bottomley wrote: > > On Wed, 2007-12-19 at 17:31 +1100, Rusty Russell wrote: > > > This patch series is the start of my attempt to simplify and make > > > explicit the chained scatterlist logic. > > >

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread Greg KH
On Mon, Jan 07, 2008 at 02:23:33PM +0100, Stefan Richter wrote: > David Brownell wrote: > > On Monday 07 January 2008, Greg KH wrote: > >> Most of the non-driver core code should be converted to not use the > >> lock in the class at all. They should use a local lock instead. > > > > Or better yet

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread Stefan Richter
Jarek Poplawski wrote: >> David Brownell wrote: >> > On Monday 07 January 2008, Greg KH wrote: >> >> Most of the non-driver core code should be converted to not use the >> >> lock in the class at all. They should use a local lock instead. >> > >> > Or better yet, that yet-to-be-written class_for_

[patch 0/1] Resend of zfcp adapter statistics

2008-01-07 Thread Christof Schmitt
James, this is the extension for zfcp that adds some statistics retrieved from the FCP adapter. This version already includes the fixes and applies on top of the other patches on scsi-misc. Like Swen mentioned before, this adds new data attributes that only refer to one Linux system. Similar look

[patch 1/1] zfcp: Add some statistics provided by the FCP adapter to the sysfs

2008-01-07 Thread Christof Schmitt
From: Swen Schillig <[EMAIL PROTECTED]> The new statistics from the FCP adapter provide informations about the virtual adapter (subchannel). In order to collect this information the zFCP driver is extended on one side to query the adapter and on the other side summarize certain values which can th

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread Stefan Richter
Greg KH wrote: > On Mon, Jan 07, 2008 at 02:23:33PM +0100, Stefan Richter wrote: >> David Brownell wrote: >> > On Monday 07 January 2008, Greg KH wrote: >> >> Most of the non-driver core code should be converted to not use the >> >> lock in the class at all. They should use a local lock instead. >

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread Greg KH
On Mon, Jan 07, 2008 at 06:13:37PM +0100, Stefan Richter wrote: > It's already in the driver core to the most part. It remains to be seen > what is less complicated in the end: Transparent mutex-protected list > accesses provided by driver core (requires the iterator), or all the > necessary lock

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread Alan Stern
On Mon, 7 Jan 2008, Stefan Richter wrote: > Semi off-topic: What about struct device.sem? Is there any chance to > rip this out of the driver core and let drivers serialize everything? I > suppose not... There isn't. The core uses that lock. Alan Stern - To unsubscribe from this list: send

Re: Multipath failover handling (Was: Re: 2.6.24-rc3-mm1)

2008-01-07 Thread James Bottomley
On Mon, 2008-01-07 at 15:05 +0100, Hannes Reinecke wrote: > James Bottomley wrote: > > On Fri, 2007-12-14 at 10:00 +0100, Hannes Reinecke wrote: > >> James Bottomley wrote: > >>> On Mon, 2007-11-26 at 22:15 -0800, Andrew Morton wrote: > OK, thanks. I'll assume that James and Hannes have this

Re: Multipath failover handling (Was: Re: 2.6.24-rc3-mm1)

2008-01-07 Thread Mike Christie
James Bottomley wrote: However, there's still devloss_tmo to consider ... even in multipath, I don't think you want to signal path failure until devloss_tmo has fired otherwise you'll get too many transient up/down events which damage performance if the array has an expensive failover model. Ye

[RFC] Implementation of SCSI dynamic power management

2008-01-07 Thread Alan Stern
This patch is a first pass at SCSI dynamic (or runtime) PM. The new code is enabled by a Kconfig option, CONFIG_SCSI_DYNAMIC_PM, in the top SCSI menu. If the option isn't selected then the overhead is essentially zero (in a few places code that was in-line gets moved out-of-line, but not in a

[RFC] Autosuspend for usb-storage (based on SCSI dynamic PM)

2008-01-07 Thread Alan Stern
This patch implements autosuspend and autoresume for usb-storage. It is based on the SCSI Dynamic PM patch just posted on linux-scsi and linux-pm. Note: For testing, you will have to set the power/level attribute (and possibly also power/autosuspend) for both the SCSI device and the USB devic

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-07 Thread Oliver Neukum
Am Montag, 7. Januar 2008 20:42:23 schrieb Alan Stern: > When all the devices under a host are suspended, the LLD is informed > (via a new "autosuspend" method in the host template) so that it can That is most certainly a mistake. Is there a good reason to not modify to extend suspend() to take a

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-07 Thread Alan Stern
On Mon, 7 Jan 2008, Oliver Neukum wrote: > Am Montag, 7. Januar 2008 20:42:23 schrieb Alan Stern: > > When all the devices under a host are suspended, the LLD is informed > > (via a new "autosuspend" method in the host template) so that it can > > That is most certainly a mistake. Why? > Is th

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-07 Thread Oliver Neukum
Am Montag, 7. Januar 2008 22:34:52 schrieb Alan Stern: > On Mon, 7 Jan 2008, Oliver Neukum wrote: > > > Am Montag, 7. Januar 2008 20:42:23 schrieb Alan Stern: > > > When all the devices under a host are suspended, the LLD is informed > > > (via a new "autosuspend" method in the host template) so

[PATCH] sym8xx_2: Fixes call to wait_for_completion_timeout() with NULL argument

2008-01-07 Thread Krzysztof Helt
From: Krzysztof Helt <[EMAIL PROTECTED]> This patch fixes call to wait_for_completion_timeout() with NULL argument. Signed-off-by: Krzysztof Helt <[EMAIL PROTECTED]> --- diff -urp linux-ref/drivers/scsi/sym53c8xx_2/sym_glue.c linux-new/drivers/scsi/sym53c8xx_2/sym_glue.c --- linux-ref/drivers/

Re: [PATCH] sym8xx_2: Fixes call to wait_for_completion_timeout() with NULL argument

2008-01-07 Thread James Bottomley
On Mon, 2008-01-07 at 22:56 +0100, Krzysztof Helt wrote: > From: Krzysztof Helt <[EMAIL PROTECTED]> > > This patch fixes call to wait_for_completion_timeout() > with NULL argument. That doesn't seem to be at all what your patch is doing. I can't see any case in the old code where wait_for_compl

[PATCH] fix scsi_setup_command_freelist failure path race

2008-01-07 Thread FUJITA Tomonori
Looks like that host_cmd_pool_mutex are necessary here. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/scsi.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index ebc0193..54ff611 100644 --- a/drivers/scs

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2008-01-07 Thread FUJITA Tomonori
On Mon, 07 Jan 2008 15:25:36 +0200 Boaz Harrosh <[EMAIL PROTECTED]> wrote: > On Mon, Jan 07 2008 at 8:53 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > On Sun, 23 Dec 2007 13:09:05 +0200 > > Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > > >> On Fri, Dec 21 2007 at 4:30 +0200, Benjamin Herren

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-07 Thread Rusty Russell
On Tuesday 08 January 2008 02:48:23 James Bottomley wrote: > We're always open to new APIs (or more powerful and expanded old ones). > The way we've been doing the sg_chain conversion is to slide API layers > into the drivers so sg_chain becomes a simple API flip when we turn it > on. Unfortunatel

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-07 Thread Alan Stern
On Mon, 7 Jan 2008, Oliver Neukum wrote: > Am Montag, 7. Januar 2008 22:34:52 schrieb Alan Stern: > > On Mon, 7 Jan 2008, Oliver Neukum wrote: > > > > > Am Montag, 7. Januar 2008 20:42:23 schrieb Alan Stern: > > > > When all the devices under a host are suspended, the LLD is informed > > > > (vi

Re: [PATCH] sym8xx_2: kill compilation warning

2008-01-07 Thread Krzysztof Helt
On Mon, 07 Jan 2008 16:39:35 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > On Mon, 2008-01-07 at 22:56 +0100, Krzysztof Helt wrote: > > From: Krzysztof Helt <[EMAIL PROTECTED]> > > > > This patch fixes call to wait_for_completion_timeout() > > with NULL argument. > > That doesn't seem to

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread Dave Young
On Jan 8, 2008 1:20 AM, Greg KH <[EMAIL PROTECTED]> wrote: > On Mon, Jan 07, 2008 at 06:13:37PM +0100, Stefan Richter wrote: > > It's already in the driver core to the most part. It remains to be seen > > what is less complicated in the end: Transparent mutex-protected list > > accesses provided