Re: [PATCH] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-01-03 Thread FUJITA Tomonori
On Mon, 31 Dec 2007 15:56:08 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > ATA requires that all DMA transfers begin and end on word boundaries. > Because of this, a large amount of machinery grew up in ide to adjust > scatterlists on this basis. However, as of 2.5, the block layer has a > d

advansys broken (at least) on ARM and MIPS

2008-01-03 Thread Martin Michlmayr
Commit 9d511a4b29de6764931343d03e493f2e04df0271 removed the "depends on BROKEN || X86_32" line from advansys' Kconfig entry. I'm not sure that was such a great idea - the module doesn't compile at least on ARM and MIPS: ARM: CC [M] drivers/scsi/advansys.o drivers/scsi/advansys.c:71:2: warning

[PATCH 1/3] scsi: Convert everyone to scsi_sglist and scsi_sg_count

2008-01-03 Thread Rusty Russell
This patch simply converts direct uses of ->use_sg and ->request_buffer to use the wrapper macros. This removes the assumption that the sg list is overloaded on request_buffer, and that there's an explicit use_sg field. The ->request_buffer assumption is explicit in scsi_debug.c's paranoid checki

[PATCH 2/3] usb_storage: usb_stor_bulk_transfer_sg cleanup

2008-01-03 Thread Rusty Russell
usb_stor_bulk_transfer_sg() assumes buf is a scatterlist array if use_sg is non-NULL. Change it to an explicit sg arg, instead, to allow the callers to change to scsi_sglist(). Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 09247461cfda drivers/usb/storage/freecom.c --- a/drivers/usb/s

[PATCH 3/3] scsi: convert core to sg_ring

2008-01-03 Thread Rusty Russell
A 'struct sg_ring *sg' element is added to struct scsi_cmd, and the use_sg and __use_sg fields are removed. If this field is null, request_buffer point to the data (as was previously indicated by use_sg == 0). To ease transition, scsi_sglist() is now a backwards-compat routine which chains the sg

Re: [PATCH 1/3] scsi: Convert everyone to scsi_sglist and scsi_sg_count

2008-01-03 Thread Boaz Harrosh
On Thu, Jan 03 2008 at 10:50 +0200, Rusty Russell <[EMAIL PROTECTED]> wrote: > This patch simply converts direct uses of ->use_sg and ->request_buffer to > use the wrapper macros. This removes the assumption that the sg list is > overloaded on request_buffer, and that there's an explicit use_sg fi

Re: [PATCH 0/2] sg_ring: Gentler scsi merge

2008-01-03 Thread Boaz Harrosh
On Thu, Jan 03 2008 at 9:00 +0200, Rusty Russell <[EMAIL PROTECTED]> wrote: > OK, after wading through many scsi drivers, I decided to change tack and try > to provide a transition path. This is in two stages: > > 1) These two patches. sg_ring used underneath, but if any driver asks for > scsi

RE: Open-FCoE on linux-scsi

2008-01-03 Thread FUJITA Tomonori
From: "Love, Robert W" <[EMAIL PROTECTED]> Subject: RE: Open-FCoE on linux-scsi Date: Mon, 31 Dec 2007 08:34:38 -0800 > >> Hello SCSI mailing list, > >> > >>I'd just like to introduce ourselves a bit before we get > >> started. My name is Robert Love and I'm joined by a team of engineers > >>

Re: [PATCH 2/2] use dynamically allocated sense buffer

2008-01-03 Thread FUJITA Tomonori
On Thu, 3 Jan 2008 13:56:37 +0900 FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > This removes static array sense_buffer in scsi_cmnd and uses > dynamically allocated sense_buffer (with GFP_DMA). > > scsi_add_host allocates as many buffers as > scsi_host->can_queue. __scsi_get_command attaches sense

Re: advansys broken (at least) on ARM and MIPS

2008-01-03 Thread Kyle McMartin
On Thu, Jan 03, 2008 at 08:43:53AM +0100, Martin Michlmayr wrote: > MIPS: > > Building modules, stage 2. > MODPOST 64 modules > ERROR: "free_dma" [drivers/scsi/advansys.ko] undefined! > needs to depend on GENERIC_ISA_DMA_API - To unsubscribe from this list: send the line "unsubscribe linux-s

Re: [PATCH 1/2] replace sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE

2008-01-03 Thread Boaz Harrosh
On Thu, Jan 03 2008 at 6:56 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > To remove sense_buffer array in scsi_cmnd structure, this replaces > sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE in several LLDs. > > Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> > --- > drivers/ata/libata-sc

Re: [PATCH] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-01-03 Thread James Bottomley
On Thu, 2008-01-03 at 16:58 +0900, FUJITA Tomonori wrote: > On Mon, 31 Dec 2007 15:56:08 -0600 > James Bottomley <[EMAIL PROTECTED]> wrote: > > @@ -1080,24 +1073,15 @@ extern void ata_port_pbar_desc(struct ata_port *ap, > > int bar, ssize_t offset, > > static inline struct scatterlist * > > ata

[PATCH 0/1] Remove of old NCR53C9x/esp family of drivers

2008-01-03 Thread Boaz Harrosh
James Could you at least put the following patch in scsi-pending so it can attract some acknowledgment, and retract futile attempts from people at coding these drivers. (And also git is better than me in maintaining it synced) Christoph Hellwig! I need your Recommended-by: on this. I had my r

Re: advansys broken (at least) on ARM and MIPS

2008-01-03 Thread James Bottomley
On Thu, 2008-01-03 at 08:43 +0100, Martin Michlmayr wrote: > Commit 9d511a4b29de6764931343d03e493f2e04df0271 removed the "depends > on BROKEN || X86_32" line from advansys' Kconfig entry. I'm not sure > that was such a great idea - the module doesn't compile at least on > ARM and MIPS: > > ARM:

Re: [PATCH 1/2] replace sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE

2008-01-03 Thread FUJITA Tomonori
On Thu, 03 Jan 2008 17:01:11 +0200 Boaz Harrosh <[EMAIL PROTECTED]> wrote: > On Thu, Jan 03 2008 at 6:56 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > To remove sense_buffer array in scsi_cmnd structure, this replaces > > sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE in several LLDs. > >

Re: advansys broken (at least) on ARM and MIPS

2008-01-03 Thread Martin Michlmayr
Adding Russell King to CC who can hopefully answer James' question below. * James Bottomley <[EMAIL PROTECTED]> [2008-01-03 09:21]: > On Thu, 2008-01-03 at 08:43 +0100, Martin Michlmayr wrote: > > Commit 9d511a4b29de6764931343d03e493f2e04df0271 removed the "depends > > on BROKEN || X86_32" line fr

RE: [PATCH 1/2] replace sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE

2008-01-03 Thread Salyzyn, Mark
ACK on aacraid/ips/dpt_i2o bits. Inspected others, this patch IS inert. NitMeBeingStupidAndAddingARiderToTheBill: I know it was a grep/replace. If you need to respin because of Boaz and do not mind, do not hesitate to optimize (?) and instead do: diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi

Re: advansys broken (at least) on ARM and MIPS

2008-01-03 Thread Russell King
On Thu, Jan 03, 2008 at 04:55:49PM +0100, Martin Michlmayr wrote: > Adding Russell King to CC who can hopefully answer James' question > below. > > * James Bottomley <[EMAIL PROTECTED]> [2008-01-03 09:21]: > > On Thu, 2008-01-03 at 08:43 +0100, Martin Michlmayr wrote: > > > Commit 9d511a4b29de6764

Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers

2008-01-03 Thread James Bottomley
On Thu, 2008-01-03 at 17:40 +0200, Boaz Harrosh wrote: > As recommended by Christoph Hellwig. There is no use > of Fixing these drivers, since there is a much simpler > and modern esp infrastructure with David Miller's esp_scsi > > - Remove all driver files dependent on NCR53C9x.c > d

Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers

2008-01-03 Thread Geert Uytterhoeven
On Thu, 3 Jan 2008, James Bottomley wrote: > On Thu, 2008-01-03 at 17:40 +0200, Boaz Harrosh wrote: > > As recommended by Christoph Hellwig. There is no use > > of Fixing these drivers, since there is a much simpler > > and modern esp infrastructure with David Miller's esp_scsi > > > > - Remov

Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers

2008-01-03 Thread James Bottomley
On Thu, 2008-01-03 at 20:05 +0100, Geert Uytterhoeven wrote: > On Thu, 3 Jan 2008, James Bottomley wrote: > > On Thu, 2008-01-03 at 17:40 +0200, Boaz Harrosh wrote: > > > As recommended by Christoph Hellwig. There is no use > > > of Fixing these drivers, since there is a much simpler > > > and m

RE: Open-FCoE on linux-scsi

2008-01-03 Thread Love, Robert W
>From: "Love, Robert W" <[EMAIL PROTECTED]> >Subject: RE: Open-FCoE on linux-scsi >Date: Mon, 31 Dec 2007 08:34:38 -0800 > >> >> Hello SCSI mailing list, >> >> >> >> I'd just like to introduce ourselves a bit before we get >> >> started. My name is Robert Love and I'm joined by a team of engineer

Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers

2008-01-03 Thread David Miller
From: Geert Uytterhoeven <[EMAIL PROTECTED]> Date: Thu, 3 Jan 2008 20:05:27 +0100 (CET) > On Thu, 3 Jan 2008, James Bottomley wrote: > > On Thu, 2008-01-03 at 17:40 +0200, Boaz Harrosh wrote: > > > As recommended by Christoph Hellwig. There is no use > > > of Fixing these drivers, since there is

Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers

2008-01-03 Thread Michael Schmitz
Hi all, > > Anybody who can look into converting the m68k NCR53C9x drivers and has > > hardware to test (some of) them? I don't think we can afford losing one > > third of our SCSI drivers... I can look into converting some (having worked on the m68k Mac ESP driver in the past - I do recall the M

Re: INITIO scsi driver fails to work properly

2008-01-03 Thread Filippos Papadopoulos
First of all let me wish a happy new year. I come back from the vacations and i compiled the initio driver with #define DEBUG_INTERRUPT 1 #define DEBUG_QUEUE 1 #define DEBUG_STATE 1 #define INT_DISC1 I used the sources from 2.6.24-rc6-git9 kernel. At kernel boot time the initio dr

[2.6.24-rc BUGFIX] SRP transport: only remove our own entries

2008-01-03 Thread Dave Dillow
The SCSI SRP transport class currently iterates over all children devices of the host that is being removed in srp_remove_host(). However, not all of those children were created by the SRP transport, and removing them will cause corruption and an oops when their creator tries to remove them. Signe

Re: [2.6.24-rc BUGFIX] SRP transport: only remove our own entries

2008-01-03 Thread FUJITA Tomonori
On Thu, 03 Jan 2008 21:34:49 -0500 Dave Dillow <[EMAIL PROTECTED]> wrote: > The SCSI SRP transport class currently iterates over all children > devices of the host that is being removed in srp_remove_host(). However, > not all of those children were created by the SRP transport, and > removing the

Re: [PATCH 1/3] scsi: Convert everyone to scsi_sglist and scsi_sg_count

2008-01-03 Thread Rusty Russell
On Thursday 03 January 2008 20:26:13 Boaz Harrosh wrote: > On Thu, Jan 03 2008 at 10:50 +0200, Rusty Russell <[EMAIL PROTECTED]> wrote: > > This patch simply converts direct uses of ->use_sg and ->request_buffer > > to use the wrapper macros. This removes the assumption that the sg list > > is ov