Re: Disabling dev_loss_tmo?

2007-11-14 Thread Tore Anderson
* James Smart > We had a lot of conversations on what to have the transport do after > connectivity was lost to a device. Suffice to say - the answer was to > remove the device. The dev_loss_tmo value was the compromise > between the kernel architectural position, and what FC drivers had > alway

[PATCH 0/2] Splitting sg chain allocation support from scsi

2007-11-14 Thread Jens Axboe
Hi, Currently scsi_lib.c does its own sg chain allocation and freeing, as it was proof of concept. But other drivers may want to take advantage of that feature as well. These two patches add a lib/scatterlist.c and moves most of the linux/scatterlist.h big include into that, and adds helpers for a

[PATCH 1/2] SG: Move functions to lib/scatterlist.c and add sg chaining allocator helpers

2007-11-14 Thread Jens Axboe
>From 26dcdd893e845180cc822640d36521d7cb18ce38 Mon Sep 17 00:00:00 2001 From: Jens Axboe <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 12:35:10 +0100 Subject: [PATCH] SG: Move functions to lib/scatterlist.c and add sg chaining allocator helpers Manually doing chained sg lists is not trivial, so add

[PATCH 2/2] SG: Convert SCSI to use scatterlist helpers for sg chaining

2007-11-14 Thread Jens Axboe
>From 7b2421e1c075d3c262e28d0598608141add2e7da Mon Sep 17 00:00:00 2001 From: Jens Axboe <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 12:36:47 +0100 Subject: [PATCH] SG: Convert SCSI to use scatterlist helpers for sg chaining Also change scsi_alloc_sgtable() to just return 0/failure, since it maps

Re: [PATCH 2/2] SG: Convert SCSI to use scatterlist helpers for sg chaining

2007-11-14 Thread Benny Halevy
On Nov. 14, 2007, 13:47 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote: >>From 7b2421e1c075d3c262e28d0598608141add2e7da Mon Sep 17 00:00:00 2001 > From: Jens Axboe <[EMAIL PROTECTED]> > Date: Wed, 14 Nov 2007 12:36:47 +0100 > Subject: [PATCH] SG: Convert SCSI to use scatterlist helpers for sg chaining

Re: [PATCH 2/2] SG: Convert SCSI to use scatterlist helpers for sg chaining

2007-11-14 Thread Jens Axboe
On Wed, Nov 14 2007, Benny Halevy wrote: > On Nov. 14, 2007, 13:47 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote: > >>From 7b2421e1c075d3c262e28d0598608141add2e7da Mon Sep 17 00:00:00 2001 > > From: Jens Axboe <[EMAIL PROTECTED]> > > Date: Wed, 14 Nov 2007 12:36:47 +0100 > > Subject: [PATCH] SG: Conv

Re: [2.6 patch] scsi/lpfc/: possible cleanups

2007-11-14 Thread James Smart
ACK -- james s Adrian Bunk wrote: This patch contains the following possible cleanups: - make the following needlessly global functions static: - lpfc_els.c: lpfc_register_new_vport() - lpfc_els.c: lpfc_issue_els_fdisc() - lpfc_els.c: lpfc_issue_fabric_iocb() - lpfc_els.c: lpfc_fabric_a

Re: Disabling dev_loss_tmo?

2007-11-14 Thread James Smart
Tore Anderson wrote: So basically you're forcing breakage on users to corece the DM folks to fix their end? Maybe it's time to re-think that strategy, seeing that it hasn't been fixed in such a long time it seems unlikely that they would start bothering now. SuSE and RH works around it anyway,

Re: Disabling dev_loss_tmo?

2007-11-14 Thread Tore Anderson
* James Smart > Please don't shoot the messenger. I was trying to summarize the > evolution of FC into the kernel, highlight that the DM team knew of > the issue, had higher-priority issues, and that it applies to more > than FC. Having experienced first-hand this method of getting work > done, I

Re: how to handle QUEUE_FULL/SAM_STAT_TASK_SET_FULL in userspace?

2007-11-14 Thread Chris Friesen
Moore, Eric wrote: QUEUE_FULL and SAM_STAT_TASK_SET_FULL are not errors. I consider them errors in the same way that ENOMEM or ENOBUFS (or even EAGAIN) are errors. "There is a shortage of resources and the command could not be completed, please try again later." Also, the behaviour has ch

Re: Disabling dev_loss_tmo?

2007-11-14 Thread James Smart
I've added the dm reflector to this email... Best would to have DM-multipath handle the disconnects gracefully, of course. But since it doesn't appear to be happening anytime soon: A workaround provided by the transport layer would be very welcome! I don't use iSCSI or SAS with DM so I don't

RE: [PATCH] MegaRAID SAS: Convert aen_mutex to the mutex API

2007-11-14 Thread Yang, Bo
ACK Thanks. Bo Yang -Original Message- From: Matthias Kaehlcke [mailto:[EMAIL PROTECTED] Sent: Saturday, October 27, 2007 3:49 AM To: DL-MegaRAID Linux; linux-scsi@vger.kernel.org Cc: [EMAIL PROTECTED]; Andrew Morton Subject: [PATCH] MegaRAID SAS: Convert aen_mutex to the mutex API Me

Re: [PATCH] Add missing $(obj) to aic7xxx makefile

2007-11-14 Thread Sam Ravnborg
Hi Vegard. I had to modify the patch to make it actually work reliable with "make drivers/scsi/ -j". I have applied the below to kbuild.git. linux-scsi cc'ed - please let me know if you prefer to take it via scsi tree. Sam commit c102f89b1e35c793a3483c67bce6b28a9adb7f2f Author: Vegard N

Re: [PATCH] Add missing $(obj) to aic7xxx makefile

2007-11-14 Thread Matthew Wilcox
On Wed, Nov 14, 2007 at 09:30:46PM +0100, Sam Ravnborg wrote: > I had to modify the patch to make it actually work > reliable with "make drivers/scsi/ -j". > I have applied the below to kbuild.git. > > linux-scsi cc'ed - please let me know if you prefer > to take it via scsi tree. It seems indepe

iscsi bugfixes

2007-11-14 Thread michaelc
Here are some iscsi fix patches from Tony Battersby that were floating around that should go into 2.6.24. The patches are made against scsi-rc-fixes. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:

[PATCH 1/2] iscsi_tcp: fix potential lockup with write commands

2007-11-14 Thread michaelc
From: Tony Battersby <[EMAIL PROTECTED]> There is a race condition in iscsi_tcp.c that may cause it to forget that it received a R2T from the target. This race may cause a data-out command (such as a write) to lock up. The race occurs here: static int iscsi_send_unsol_pdu(struct iscsi_conn *con

[PATCH 2/2] iscsi: return data transfer residual for data-out commands

2007-11-14 Thread michaelc
From: Tony Battersby <[EMAIL PROTECTED]> Currently, the iSCSI driver returns the data transfer residual for data-in commands (e.g. read) but not data-out commands (e.g. write). This patch makes it return the data transfer residual for both types of commands. Signed-off-by: Tony Battersby <[EMAIL

Re: [PATCH] Add missing $(obj) to aic7xxx makefile

2007-11-14 Thread Sam Ravnborg
On Wed, Nov 14, 2007 at 01:36:42PM -0700, Matthew Wilcox wrote: > On Wed, Nov 14, 2007 at 09:30:46PM +0100, Sam Ravnborg wrote: > > I had to modify the patch to make it actually work > > reliable with "make drivers/scsi/ -j". > > I have applied the below to kbuild.git. > > > > linux-scsi cc'ed - p

RE: how to handle QUEUE_FULL/SAM_STAT_TASK_SET_FULL in userspace?

2007-11-14 Thread Moore, Eric
On Wednesday, November 14, 2007 10:23 AM, Chris Friesen wrote: > > QUEUE_FULL and SAM_STAT_TASK_SET_FULL are not errors. > > I consider them errors in the same way that ENOMEM or ENOBUFS > (or even > EAGAIN) are errors. "There is a shortage of resources and > the command > could not be compl

[PATCH resend] scsi boot options: correct option name and tell where to find docs for it

2007-11-14 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Minor corrections and additions to 'scsi_logging_level', as pointed out by Chuck Ebbert. Also point out the IBM S390-tools 'scsi_logging_level' script. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- Documentation/kernel-parameters.txt |8 +++-

[PATCH resend] scsi tgt: fix build when dprintk is defined

2007-11-14 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix scsi_tgt_lib build when dprintk is defined: drivers/scsi/scsi_tgt_lib.c: In function 'scsi_tgt_cmd_destroy': drivers/scsi/scsi_tgt_lib.c:183: warning: format '%lu' expects type 'long unsigned int', but argument 6 has type 'unsigned int' drivers/scsi/scs

[PATCH] Documentation: Remove references to dead "st0x" and "tmc8xx" parms.

2007-11-14 Thread Robert P. J. Day
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- as best i can tell, those kernel parms don't exist anymore. Documentation/kernel-parameters.txt |6 -- drivers/scsi/seagate.c | 11 --- 2 files changed, 17 deletions(-) diff --git a/Documentation/kernel-p

Re: [PATCH resend] scsi tgt: fix build when dprintk is defined

2007-11-14 Thread Mike Christie
Randy Dunlap wrote: From: Randy Dunlap <[EMAIL PROTECTED]> Fix scsi_tgt_lib build when dprintk is defined: @@ -617,7 +617,7 @@ int scsi_tgt_kspace_it_nexus_rsp(int hos struct Scsi_Host *shost; int err = -EINVAL; - dprintk("%d %d %llx\n", host_no, result, (unsigned long long)

Re: [PATCH resend] scsi tgt: fix build when dprintk is defined

2007-11-14 Thread Randy Dunlap
On Wed, 14 Nov 2007 23:36:38 -0600 Mike Christie wrote: > Randy Dunlap wrote: > > From: Randy Dunlap <[EMAIL PROTECTED]> > > > > Fix scsi_tgt_lib build when dprintk is defined: > > > @@ -617,7 +617,7 @@ int scsi_tgt_kspace_it_nexus_rsp(int hos > > struct Scsi_Host *shost; > > int err = -

[patch 32/40] hptiop: avoid buffer overflow when returning sense data

2007-11-14 Thread Greg Kroah-Hartman
-stable review patch. If anyone has any objections, please let us know. -- From: HighPoint Linux Team <[EMAIL PROTECTED]> patch 0fec02c93f60fb44ba3a24a0d3e4a52521d34d3f in mainline. avoid buffer overflow when returning sense data. With current adapter firmware the driver is w