Hi James,
the FAILFAST flag is currently not honored in scsi_request_fn().
So if scsi_dispatch_cmd() returns an error or the queue is not
ready, the request will always be requeued regardless of the
FAILFAST setting.
This can result in a delayed fallback for multipathing, as
these requests will on
I'm not sure that I understand the meaning of max_sectors in
scsi_host_template. Is it the maximum data length of a single SCSI
command? Is it in bytes? What's the size of a sector?
Thanks,
--
Erez Zilber | 972-9-971-7689
Softwar
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
drivers/scsi/NCR53C9x.c |3 ++-
drivers/scsi/esp_scsi.c |3 ++-
drivers/scsi/iscsi_tcp.c |3 ++-
drivers/scsi/libiscsi.c |3 ++-
4 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/NCR53C9x.c b/dr
On Tue, Nov 06, 2007 at 10:20:46AM -0500, Robert P. J. Day wrote:
> @@ -1656,7 +1657,7 @@ static inline int reconnect_target(struct NCR_ESP *esp,
> struct ESP_regs *eregs)
> if(!(it & me))
> return -1;
> it &= ~me;
> - if(it & (it - 1))
> + if(!is_power_of_2(it))
On Tue, Nov 06, 2007 at 11:09:51AM -0500, Robert P. J. Day wrote:
> > > bits &= ~esp->scsi_id_mask;
> > > - if (!bits || (bits & (bits - 1)))
> > > + if (!is_power_of_2(bits))
> > > goto do_reset;
> >
> > Non-equivalent transform. Definitely a bug.
>
>
Boaz Harrosh [EMAIL PROTECTED] wrote:
> > +static enum scsi_eh_timer_return gdth_timed_out(struct scsi_cmnd *scp)
> > +{
> > + gdth_ha_str *ha = shost_priv(scp->device->host);
> > + struct gdth_cmndinfo *cmndinfo = gdth_get_cmndinfo(ha);
>
> a gdth_get_cmndinfo(ha) is for allocating a new cmnd
On Tue, 6 Nov 2007, Matthew Wilcox wrote:
> On Tue, Nov 06, 2007 at 10:20:46AM -0500, Robert P. J. Day wrote:
> > @@ -1656,7 +1657,7 @@ static inline int reconnect_target(struct NCR_ESP
> > *esp, struct ESP_regs *eregs)
> > if(!(it & me))
> > return -1;
> > it &= ~me;
> > -
On Tue, 6 Nov 2007, Matthew Wilcox wrote:
> On Tue, Nov 06, 2007 at 11:09:51AM -0500, Robert P. J. Day wrote:
> > > > bits &= ~esp->scsi_id_mask;
> > > > - if (!bits || (bits & (bits - 1)))
> > > > + if (!is_power_of_2(bits))
> > > >
Hannes Reinecke wrote:
Hi James,
the FAILFAST flag is currently not honored in scsi_request_fn().
So if scsi_dispatch_cmd() returns an error or the queue is not
ready, the request will always be requeued regardless of the
FAILFAST setting.
This can result in a delayed fallback for multipathing,
[1]
I propose a small change to scsi_tgt_lib.c that will make
tgt completely neutral to the scsi_data_buffer patch. And will
make it all that more ready for bidi, too. TOMO is this OK?
(Can you do without the GFP_KERNEL allocation flag? It could
make the code a bit more simple)
[2]
scsi_data_buf
- If we export scsi_init_io()/scsi_release_buffers() instead of
scsi_{alloc,free}_sgtable() from scsi_lib than tgt code is
much more insulated from scsi_lib changes. As a bonus it will
also gain bidi capability when it comes.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
driv
In preparation for bidi we abstract all IO members of scsi_cmnd,
that will need to duplicate, into a substructure.
- Group all IO members of scsi_cmnd into a scsi_data_buffer
structure.
- Adjust accessors to new members.
- scsi_{alloc,free}_sgtable receive a scsi_data_buffer instead
At the block level bidi request uses req->next_rq pointer for a second
bidi_read request.
At Scsi-midlayer a second scsi_data_buffer structure is used for the
bidi_read part. This bidi scsi_data_buffer is put on
request->next_rq->special. Struct scsi_cmnd is not changed.
- Define scsi
Erez Zilber wrote:
> I'm not sure that I understand the meaning of max_sectors in
> scsi_host_template.
Did you have a look at scsi_mid_low_api.txt?
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/scsi/scsi_mid_low_api.txt;h=6f70f2b9327e1f0db7bc05bdbf2d6ce3
Re-Sending:
James,
The current feature request is to allow the user to change "cmd_per_lun"
and "max_sectors" only during the driver loading time. I agree with you
it is very good feature to provide option to modify these during run
time. In future this may be done as required/requested for. But
On Tue, Nov 06 2007 at 20:25 +0200, Mike Christie <[EMAIL PROTECTED]> wrote:
> Boaz Harrosh wrote:
>> [1]
>> I propose a small change to scsi_tgt_lib.c that will make
>> tgt completely neutral to the scsi_data_buffer patch. And will
>> make it all that more ready for bidi, too. TOMO is this OK?
>>
Boaz Harrosh wrote:
[1]
I propose a small change to scsi_tgt_lib.c that will make
tgt completely neutral to the scsi_data_buffer patch. And will
make it all that more ready for bidi, too. TOMO is this OK?
(Can you do without the GFP_KERNEL allocation flag? It could
make the code a bit more simpl
Re-Sending:
Christoph,
The e-mail I sent out on Oct. 31st was bounced back, I re-send it again.
I see that scsi_scan_host_selected is in scsi_priv.h and currently is
not used by any other driver. The scsi_priv.h is not part of the include
dir (/include/scsi). One of the major Linux distro's do
Re-Sending:
Christoph,
Here are the clarification for the design to implement the fast_load,
cmd_per_lun and max_sectors:
The fast_load parameter is for the user to decide at driver load time if
(s)he wants to skip scan of devices in PD channels.
After driver is loaded the user cannot be permit
The following commit changed the pointer passed to request_irq(), but
failed to change the pointer passed to free_irq():
commit 99c9e0a1d6cfe1ba1169a7a81435ee85bc00e4a1
Author: Matthew Wilcox <[EMAIL PROTECTED]>
Date: Fri Oct 5 15:55:12 2007 -0400
[SCSI] sym53c8xx: Make interrupt handler ca
gdth driver is modified NOT to use scp->eh_timeout. Now, it has
eh_timed_out (gdth_timed_out) to handle command timeouts for locked
I/O's. Have not tested as I don't have needed hardware! Patch is
against 2.6.23-mm1.
Signed-off-by: Malahal Naineni <[EMAIL PROTECTED]>
diff -r dbb45a1edd2a drivers/
This patch fixes the calculation of the data transfer residual for the
case of a command that is supposed to transfer an odd number of bytes on
a wide bus but transfers nothing instead.
Signed-off-by: Tony Battersby <[EMAIL PROTECTED]>
---
--- linux-2.6.24-rc1-git15/drivers/scsi/sym53c8xx_2/sym_hi
Make the cciss driver notify the scsi mid layer of device
changes (e.g. hot pluggable tape drives mostly). Also
made it register with the scsi mid layer even if no
devices are present so adding the first device is
not different than adding 2nd or nth device.
Signed-off-by: Stephen M. Cameron <
On Sun, 2007-11-04 at 10:02 -0800, Randy Dunlap wrote:
> On Sat, 3 Nov 2007 13:30:39 -0500 Rob Landley wrote:
>
> > From: Rob Landley <[EMAIL PROTECTED]>
> >
> > Add Documentation/DocBook/scsi_midlayer.tmpl, add to Makefile, and update
> > lots of kerneldoc comments in drivers/scsi/*.
> >
> > Up
24 matches
Mail list logo
