Re: DMA API Re: Remove dma_coherent_mem interface

2007-11-01 Thread ian
On Wed, 2007-10-31 at 15:34 -0600, Matthew Wilcox wrote: > On Wed, Oct 31, 2007 at 09:03:24PM +, ian wrote: > It's been three years since this API was introduced, and the only > *merged* user is the one that James wrote. Yes I appreciate that. > Now it's in the way of some > performance im

Re: DMA API Re: Remove dma_coherent_mem interface

2007-11-01 Thread Paul Mundt
On Thu, Nov 01, 2007 at 09:48:46AM +, ian wrote: > On Wed, 2007-10-31 at 15:34 -0600, Matthew Wilcox wrote: > > It may not be significant, so it would be an easy decision to keep > > the interface. But if the decision is going to be to keep the > > interface despite the lack of users and

RE: [PATCHv2] aacraid: don't assign cpu_to_le32(constant) to u8

2007-11-01 Thread Salyzyn, Mark
ACK v2 Sincerely -- Mark Salyzyn > -Original Message- > From: Stephen Rothwell [mailto:[EMAIL PROTECTED] > Sent: Thursday, November 01, 2007 2:32 AM > To: AACRAID > Cc: linux-scsi@vger.kernel.org; LKML > Subject: [PATCHv2] aacraid: don't assign cpu_to_le32(constant) to u8 > > Noticed on

Re: [PATCHv2] aacraid: don't assign cpu_to_le32(constant) to u8

2007-11-01 Thread Andreas Schwab
Stephen Rothwell <[EMAIL PROTECTED]> writes: > diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c > index 240a0bb..3c2dbc0 100644 > --- a/drivers/scsi/aacraid/commsup.c > +++ b/drivers/scsi/aacraid/commsup.c > @@ -1339,9 +1339,9 @@ int aac_check_health(struct aac_dev * aa

Re: DMA API Re: Remove dma_coherent_mem interface

2007-11-01 Thread ian
On Thu, 2007-11-01 at 19:07 +0900, Paul Mundt wrote: > Indeed. The SH case for OHCI on MFDs is the same. So that's at least 2 > users. three if you count James SCSI card. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More ma

Re: DMA API Re: Remove dma_coherent_mem interface

2007-11-01 Thread Bernhard Walle
* ian <[EMAIL PROTECTED]> [2007-11-01 16:33]: > On Thu, 2007-11-01 at 19:07 +0900, Paul Mundt wrote: > > Indeed. The SH case for OHCI on MFDs is the same. So that's at least 2 > > users. > > three if you count James SCSI card. Four if you count http://most4linux.sourceforge.net/. Thanks, Be

[PATCH] aha152x: Use scsi_eh API for REQUEST_SENSE invocation

2007-11-01 Thread Boaz Harrosh
- Use new scsi_eh_prep/restor_cmnd() for synchronous REQUEST_SENSE invocation. Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> drivers/scsi/aha152x.c | 38 -- 1 files changed, 8 insertions(+), 30 deletions(-) diff --git a/drivers/scsi/aha152x.c b

[RFC 0/4] varlen extended and vendor-specific cdbs

2007-11-01 Thread Boaz Harrosh
This is a proposal for adding support for variable-length, extended, and vendor specific CDBs. It should now cover the entire range of the SCSI standard. This patchset extends my original submission (over a year old) in that it starts with cleaning up scsi_cmnd, hence the first patch. The other t

[PATCH 1/4] Let scsi_cmnd->cmnd use request->cmd[] buffer

2007-11-01 Thread Boaz Harrosh
- struct scsi_cmnd had a 16 bytes command buffer of its own. This is an unnecessary duplication and copy of request's cmd. It is probably left overs from the time that scsi_cmnd could function without a request attached. So clean that up. - Once above is done, few places, apart fr

[PATCH 2/4] block layer varlen-cdb

2007-11-01 Thread Boaz Harrosh
- add varlen_cdb and varlen_cdb_len to hold a large user cdb if needed. They start as empty. Allocation of buffer must be done by user and held until request execution is done. Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- block/ll_rw_blk.c |2 ++ include/linux/blkdev.h

[PATCH 3/4] scsi: varlen extended and vendor-specific cdbs

2007-11-01 Thread Boaz Harrosh
Add support for variable-length, extended, and vendor specific CDBs to scsi-ml. It is now possible for initiators and ULD's to issue these types of commands. LLDs need not change much. All they need is to raise the .max_cmd_len to the longest command they support (see iscsi patches).

[PATCH 4/4] iscsi: extended cdb support

2007-11-01 Thread Boaz Harrosh
Once varlen cdbs are supported by the block and scsi-ml layers we can apply this patch to support extended CDBs in iscsi. Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/iscsi_tcp.h |3 +- drivers/scsi/libiscsi.c| 56

Re: [PATCH 2/4] block layer varlen-cdb

2007-11-01 Thread Matthew Wilcox
On Thu, Nov 01, 2007 at 08:05:06PM +0200, Boaz Harrosh wrote: > @@ -287,8 +287,13 @@ struct request { > /* >* when request is used as a packet command carrier >*/ > - unsigned int cmd_len; > + unsigned short cmd_len; > + unsigned short varlen_cdb_len; /* length of

Re: [PATCH 1/3] debloat aic7xxx and aic79xx drivers

2007-11-01 Thread Matthew Wilcox
On Sun, Oct 14, 2007 at 04:00:10PM +0100, Denys Vlasenko wrote: > Deinlines and moves big functions from .h to .c files. > Adds prototypes for ahc_lookup_scb and ahd_lookup_scb to .h files. Adds trailing whitespace. .dotest/patch:216: * We also set the full residual flag which the Adds trai

Re: [PATCH 3/3] debloat aic7xxx and aic79xx drivers

2007-11-01 Thread Matthew Wilcox
On Sun, Oct 14, 2007 at 04:02:15PM +0100, Denys Vlasenko wrote: > Adds more consts error: patch failed: drivers/scsi/aic7xxx/aic79xx.h:1328 error: drivers/scsi/aic7xxx/aic79xx.h: patch does not apply error: patch failed: drivers/scsi/aic7xxx/aic7xxx.h:1145 error: drivers/scsi/aic7xxx/aic7xxx.h: pa

Re: [PATCH 3/3] debloat aic7xxx and aic79xx drivers

2007-11-01 Thread Randy Dunlap
On Thu, 1 Nov 2007 16:16:04 -0600 Matthew Wilcox wrote: > On Sun, Oct 14, 2007 at 04:02:15PM +0100, Denys Vlasenko wrote: > > Adds more consts > > error: patch failed: drivers/scsi/aic7xxx/aic79xx.h:1328 > error: drivers/scsi/aic7xxx/aic79xx.h: patch does not apply > error: patch failed: drivers/

Re: [PATCH 3/3] debloat aic7xxx and aic79xx drivers

2007-11-01 Thread Matthew Wilcox
On Thu, Nov 01, 2007 at 03:23:28PM -0700, Randy Dunlap wrote: > when attempting to apply to scsi-misc or linus-git or ... ? scsi-misc -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but co

Re: [PATCH 1/1] [v2] ibmvscsi: Prevent IO during partner login

2007-11-01 Thread Robert Jennings
The prior version of this patch introduced a problem for the error handler routines. Calling ibmvscsi_eh_reset_device during a initialization/login would result in the reset failing without need. To avoid failing the eh_* functions while re-attaching to the server adapter this will retry for a p

Re: [PATCH 2/4] block layer varlen-cdb

2007-11-01 Thread Benny Halevy
On Nov. 01, 2007, 20:40 +0200, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Thu, Nov 01, 2007 at 08:05:06PM +0200, Boaz Harrosh wrote: >> @@ -287,8 +287,13 @@ struct request { >> /* >> * when request is used as a packet command carrier >> */ >> -unsigned int cmd_len; >> +