Re: [PATCH] Some cosmetic changes to QlogicPTI SCSI driver

2007-08-02 Thread Boaz Harrosh
Mark Fortescue wrote: > > I must get an email client that does not mangle patches. Any > recomendations ? > If you want to use Thunderbird than you must do two things: 1. "Edit"/"Preferences"/"Composition"/"General" tab/ Wrap plain text messages at | 0 | characters. (Yes now you must f

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-02 Thread Jesper Juhl
On 02/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Thu, 2 Aug 2007 01:55:33 +0200 > Jesper Juhl <[EMAIL PROTECTED]> wrote: > [snip] > > +++ b/drivers/message/fusion/mptbase.c > > @@ -1393,18 +1393,18 @@ mpt_attach(struct pci_dev *pdev, const struct > > pci_device_id *id) > > struct p

Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

2007-08-02 Thread Boaz Harrosh
Randy Dunlap wrote: > On Wed, 01 Aug 2007 08:51:14 -0500 James Bottomley wrote: > >> On Tue, 2007-07-31 at 11:40 -0700, Randy Dunlap wrote: >>> On Tue, 31 Jul 2007 10:59:51 +0300 Boaz Harrosh wrote: >>> Randy Dunlap wrote: > Since you grok all of that (above), maybe you can help here: >>>

build #312 failed for 2.6.23-rc1-g1ed4395 in linux/drivers/scsi/advansys.c

2007-08-02 Thread Toralf Förster
Hello, the build with the attached .config failed, make ends with: ... CC [M] drivers/scsi/scsi_transport_fc.o CC [M] drivers/scsi/advansys.o drivers/scsi/advansys.c:794:2: warning: #warning this driver is still not properly converted to the DMA API drivers/scsi/advansys.c: In function 'adv

Re: build #312 failed for 2.6.23-rc1-g1ed4395 in linux/drivers/scsi/advansys.c

2007-08-02 Thread Matthew Wilcox
On Thu, Aug 02, 2007 at 01:13:45PM +0200, Toralf F?rster wrote: > Hello, > > the build with the attached .config failed, make ends with: > ... > drivers/scsi/advansys.c: In function 'advansys_board_found': > drivers/scsi/advansys.c:17781: error: implicit declaration of function > 'to_pci_dev' We

Mptlinux crashes on kernel 2.6.22.1

2007-08-02 Thread Hommel, Thomas (GE Indust, GE Fanuc)
Hello, I am trying to use a LSI53C1020 based adapter on a PowerPC board with MPC8641D processor. When initializing, the driver crashes the system with the error message below. Kernel version is 2.6.22.1, driver 3.04.04. The chip on the adapter is a 53C1020, but the driver detects a 53C1030. Has an

Re: Is there any tool can perform a READ Capacity command?

2007-08-02 Thread Martin K. Petersen
> "jidong" == jidong xiao <[EMAIL PROTECTED]> writes: jidong> I know sg_modes can help to perform a SCSI MODE SENSE command, jidong> is there any tool/command that can perform a READ Capacity jidong> command? sg_readcap -- Martin K. Petersen Oracle Linux Engineering - To unsubscribe f

Is there any tool can perform a READ Capacity command?

2007-08-02 Thread jidong xiao
I know sg_modes can help to perform a SCSI MODE SENSE command, is there any tool/command that can perform a READ Capacity command? Thanks Jason Xiao - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://

Re: Is there any tool can perform a READ Capacity command?

2007-08-02 Thread Douglas Gilbert
Martin K. Petersen wrote: >> "jidong" == jidong xiao <[EMAIL PROTECTED]> writes: > > jidong> I know sg_modes can help to perform a SCSI MODE SENSE command, > jidong> is there any tool/command that can perform a READ Capacity > jidong> command? > > sg_readcap In the sg3_utils package there is

[PATCH] block: add protocol discriminators to requests and queues

2007-08-02 Thread James Bottomley
This looks small and innocuous, but it's actually the beginning of moving the upper layer drivers into block and adding a filtering layer. The idea is that the queue contains a queue_protocol parameter which details what the device actually speaks. The requests are likewise filled in with a cmd_pr

Re: Some quick scsi documentation questions:

2007-08-02 Thread Douglas Gilbert
Rob Landley wrote: > On Thursday 26 July 2007 9:15:11 am James Bottomley wrote: >> On Wed, 2007-07-25 at 23:28 -0400, Rob Landley wrote: >>> 1) Is the summary of the scsi subsystem in appendix A of your 2002 OLS >>> paper still more or less current? (The scsi mid-layer document never >>> seems to

Re: [PATCH] block: add protocol discriminators to requests and queues

2007-08-02 Thread Matthew Wilcox
On Thu, Aug 02, 2007 at 12:47:25PM -0500, James Bottomley wrote: > This looks small and innocuous, but it's actually the beginning of > moving the upper layer drivers into block and adding a filtering layer. > The idea is that the queue contains a queue_protocol parameter which > details what the d

Re: [PATCH] block: add protocol discriminators to requests and queues

2007-08-02 Thread James Bottomley
On Thu, 2007-08-02 at 12:51 -0600, Matthew Wilcox wrote: > On Thu, Aug 02, 2007 at 12:47:25PM -0500, James Bottomley wrote: > > This looks small and innocuous, but it's actually the beginning of > > moving the upper layer drivers into block and adding a filtering layer. > > The idea is that the que

Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

2007-08-02 Thread Randy Dunlap
On Thu, 02 Aug 2007 14:26:47 +0300 Boaz Harrosh wrote: > Randy Dunlap wrote: > > On Wed, 01 Aug 2007 08:51:14 -0500 James Bottomley wrote: > > > >> On Tue, 2007-07-31 at 11:40 -0700, Randy Dunlap wrote: > >>> On Tue, 31 Jul 2007 10:59:51 +0300 Boaz Harrosh wrote: > >>> > Randy Dunlap wrote:

Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

2007-08-02 Thread James Bottomley
On Thu, 2007-08-02 at 12:09 -0700, Randy Dunlap wrote: > > 5. Now a Test Unit Ready comes in. Already a good second and more after > >the eject. The card is clearly not powered by now. > >aha152x_internal_queue should check it's own presence. and return > >appropriate value. > >Two

[PATCH 1/1] aacraid: prevent panic on adapter resource failure

2007-08-02 Thread Salyzyn, Mark
If the driver fails to allocate the contiguous (DMAable) memory for system reasons, we fail to load the instance, but then we try to free the allocation in the cleanup code and we get a panic in pci_free_consistent(). This is reported against an older kernel, hope this is relevant for latest/great

Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

2007-08-02 Thread Jürgen E . Fischer
Hi Randy, On Thu, Aug 02, 2007 at 12:09:26 -0700, Randy Dunlap wrote: > > 6. One more second passes and 2nd abort comes in. > > 7. Than a reset comes in. Here too Should driver check for hardware > >presence. > > > > since ds.c is doing: p_dev->_removed=1; > > before the shutdown. Maybe a sol

Re: Some quick scsi documentation questions:

2007-08-02 Thread Stefan Richter
> Rob Landley wrote: >> On Thursday 26 July 2007 9:15:11 am James Bottomley wrote: >>> Users have great difficulty understanding how to >>> map sg to sr (or sd), so we're trying to encourage them only to use the >>> actual device node, so /dev/sdx or /dev/srn. >> Actually, these days everybody I k

Re: Some quick scsi documentation questions:

2007-08-02 Thread Stefan Richter
> Rob Landley wrote: >> So if you don't attach an sg to every sd, then either there are holes, or >> they >> don't line up, in which case how do you tell which sg goes with a given sd? Sysfs has pointers from a SCSI logical unit device to the corresponding sd device and sg device... $ ll /sys/b

Re: [PATCH]: PCI Error Recovery: Symbios SCSI device driver

2007-08-02 Thread Linas Vepstas
On Thu, Jul 05, 2007 at 12:54:06PM -0600, Matthew Wilcox wrote: > On Thu, Jul 05, 2007 at 11:28:38AM -0700, Andrew Morton wrote: > > Well you've sent it a couple of times, and I've sent it in five more times > > over the past year. Once we were told "awaiting maintainer ack". > > > > This situati

Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

2007-08-02 Thread Randy Dunlap
On Thu, 2 Aug 2007 12:09:26 -0700 Randy Dunlap wrote: - > > diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c > > index d30a307..5fe55d0 100644 > > --- a/drivers/scsi/aha152x.c

Re: Some quick scsi documentation questions:

2007-08-02 Thread Rob Landley
On Thursday 02 August 2007 5:39:55 pm Stefan Richter wrote: > The place where these symlinks live might change in the future. See > linux-2.6.23*/Documentation/sysfs-rules.txt. I noticed this. I had a longish flamewar with Greg KH about this, which would be ongoing if he hadn't stopped replying

Re: Some quick scsi documentation questions:

2007-08-02 Thread Rob Landley
On Thursday 02 August 2007 5:19:51 pm Stefan Richter wrote: > > Rob Landley wrote: > >> On Thursday 26 July 2007 9:15:11 am James Bottomley wrote: > >>> Users have great difficulty understanding how to > >>> map sg to sr (or sd), so we're trying to encourage them only to use the > >>> actual device

Re: Some quick scsi documentation questions:

2007-08-02 Thread Rob Landley
On Thursday 02 August 2007 2:41:46 pm Douglas Gilbert wrote: > > I'm still trying to figure what the other options _are_. > > > >> James > > > > Rob > > Interesting discussion. I'm trying to pull together documentation of the scsi layer and link it into the index I'm trying to put up at http://ke