scsi/scsi_transport_iscsi.h uses struct mutex and struct list_head,
so while linux/mutex.h and linux/list.h seem to be pulled in indirectly
by one of the headers it includes, the right thing
is to include linux/mutex.h and linus/list.h directly.
Signed-off-by: Michael S. Tsirkin <[EMAIL PROTECTED]
From: Adrian Bunk <[EMAIL PROTECTED]>
Subject: 2.6.23-rc1-mm1: SCSI_SRP_ATTRS compile error
Date: Wed, 25 Jul 2007 20:06:18 +0200
> On Wed, Jul 25, 2007 at 05:36:56PM +0100, Andy Whitcroft wrote:
> > Of the machines we test releases on automatically this only compiles on
> > NUMA-Q and does not bo
Meelis Roos wrote:
Tried to compile everythin SCSI on my SBus-only sparc64, including SAS
supoort. Seems that libsas seems to depend on PCI - does it need to?
MODPOST 446 modules
ERROR: "pci_iommu_ops" [drivers/scsi/libsas/libsas.ko] undefined!
Does the attached patch fix things? 2.6.23-r
From: "Moore, Eric" <[EMAIL PROTECTED]>
Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg
Date: Wed, 25 Jul 2007 18:21:38 -0600
> > > > # ./sgv4-tools/smp_rep_manufacturer /sys/class/bsg/expander-0:1
> > > >
> > > >
> > > > I think that James tested this with aic94xx, however,
From: Boaz Harrosh <[EMAIL PROTECTED]>
Subject: [RFC 7/8] sd.c and sr.c move to scsi_sgtable implementation
Date: Thu, 05 Jul 2007 16:44:04 +0300
>
> - sd and sr would adjust IO size to align on device's block
> size. So code needs to change once we move to scsi_sgtable
> implementation
On Thu, 2007-07-26 at 05:21 -0400, Jeff Garzik wrote:
> Meelis Roos wrote:
> > Tried to compile everythin SCSI on my SBus-only sparc64, including SAS
> > supoort. Seems that libsas seems to depend on PCI - does it need to?
> >
> > MODPOST 446 modules
> > ERROR: "pci_iommu_ops" [drivers/scsi/lib
Matthew Wilcox wrote:
On Thu, Jul 26, 2007 at 03:43:39PM -0400, Jeff Garzik wrote:
+static void __devinit advansys_set_latency(struct pci_dev *pdev)
+{
+ if ((pdev->device == PCI_DEVICE_ID_ASP_1200A) ||
+ (pdev->device == PCI_DEVICE_ID_ASP_ABP940)) {
+ pci_write_con
Matthew Wilcox wrote:
@@ -18759,6 +18558,19 @@ static struct pci_device_id advansys_pci_tbl[]
__devinitdata = {
MODULE_DEVICE_TABLE(pci, advansys_pci_tbl);
+static void __devinit advansys_set_latency(struct pci_dev *pdev)
+{
+ if ((pdev->device == PCI_DEVICE_ID_ASP_1200A) ||
+
Sorry for the previous HTML-formatted e-mails. This is now corrected.
The first thing to realize is that this system only has three devices on
the actual scsi bus to this adapter:
7 - adapter card
3 - Exabyte 1x10 autoloader
6 - Exabyte VXA-2 tape drive
I only need 20 Mbps since the maximum spe
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
This is a patch to fix 'segmentation fault' issue which was initiated by
Richard Lary <[EMAIL PROTECTED]>.
Thanks again Richard.
---
>From 6abcf236b5c7fea75d7059facf77a255f02e96af Mon Sep 17 00:00:00 2001
From: Seokman
On Thu, Jul 26, 2007 at 03:43:39PM -0400, Jeff Garzik wrote:
> >+static void __devinit advansys_set_latency(struct pci_dev *pdev)
> >+{
> >+if ((pdev->device == PCI_DEVICE_ID_ASP_1200A) ||
> >+(pdev->device == PCI_DEVICE_ID_ASP_ABP940)) {
> >+pci_write_config_byte(pdev, PCI_
Matthew Wilcox wrote:
Apparently it used to be possible to call the detect method twice.
Perhaps in pre-history, but not in today's kernel...
The patch is nonetheless correct, of course...
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a
On Thu, 26 Jul 2007 15:08:39 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Matthew Wilcox wrote:
> > On Thu, Jul 26, 2007 at 02:56:33PM -0400, Jeff Garzik wrote:
> >> Matthew Wilcox wrote:
> >>> Exercise my right to change the license from dual BSD/GPL to GPL
> >> What do the other copyright hold
Matthew Wilcox wrote:
+static void __devexit advansys_remove(struct Scsi_Host *shost)
+{
+ int i;
+ scsi_remove_host(shost);
+ advansys_release(shost);
+
+ for (i = 0; i < asc_board_count; i++) {
+ if (asc_host[i] == shost) {
+ asc_host[
On Thursday, July 26, 2007 11:09 AM, FUJITA Tomonori wrote:
> For smp request/response, we use:
>
> request -> not used
> response -> not used
> dout_xferp -> pointer to a smp request frame
> din_xferp -> pointer to a smp response frame
>
>
> So we could use response field to send vendor's uniqu
Here is what I get when I apply the patch against the vanilla 2.6.22.1
source:
fea8:/usr/src/linux-2.6.22.1# patch -p1 <../new_aic_patch
patching file drivers/scsi/aic7xxx/aic79xx_osm.c
Hunk #1 FAILED at 2284.
Hunk #2 FAILED at 2368.
Hunk #3 FAILED at 2450.
Hunk #4 FAILED at 2490.
Hunk #5 FAILED a
On Thu, 2007-07-26 at 17:16 -0400, Freels, James D. wrote:
> James, I would be glad to try the fix. I can grab the changes below,
> but can you give me the patch command ? I know how to patch the
> normal kernel sources. Is this a patch for 2.6.22.1 ?
It was created against current git, but the
I'll respond to the other stuff soon, but I wanted to add:
+ for (i = 0; i < asc_board_count; i++) {
+ struct Scsi_Host *host = asc_host[i];
+ if (!host)
+ continue;
+ scsi_remove_host(host);
+ advansys_release(
On Thu, 2007-07-26 at 16:46 -0400, James Bottomley wrote:
> On Thu, 2007-07-26 at 16:00 -0400, Freels, James D. wrote:
> > 9) the output from the commands you asked for are shown below for the
> > 2.6.22.1 kernel. They indicate parity errors on the changer at scsi
> > id=3. Also, when booting up
On Thu, Jul 26, 2007 at 03:31:21PM -0400, Jeff Garzik wrote:
> 1) you should propagate pci_enable_device return value to caller on error
ok. I'll return -ENODEV if I don't get a Scsi_Host back, though.
Unless you think it's worth going through the PTR_ERR/IS_ERR/ERR_PTR
hooplah. It's not like th
Matthew Wilcox wrote:
@@ -18787,8 +18765,10 @@ advansys_pci_probe(struct pci_dev *pdev, const struct
pci_device_id *ent)
int ioport;
struct Scsi_Host *shost;
- if (pci_enable_device(pdev))
+ if (pci_request_regions(pdev, "advansys"))
goto fail;
+ if
Matthew Wilcox wrote:
+static int __devinit
+advansys_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
+{
+ int ioport;
+ struct Scsi_Host *shost;
+
+ if (pci_enable_device(pdev))
+ goto fail;
+
+ ioport = pci_resource_start(pdev, 0);
+
Matthew Wilcox wrote:
@@ -18511,13 +18493,24 @@ advansys_board_found(int iop, struct device *dev, int
bus_type)
}
if (err_code != 0)
- goto err_free_irq;
+ goto err_free_wide_mem;
ASC_DBG_PRT_SCSI_HOST(2, shost);
+ ret = scsi_add_host(shost, dev);
Matthew Wilcox wrote:
On Thu, Jul 26, 2007 at 02:56:33PM -0400, Jeff Garzik wrote:
Matthew Wilcox wrote:
Exercise my right to change the license from dual BSD/GPL to GPL
What do the other copyright holders think about this?
They're not contactable.
^^ easily
AFAIK that does n
On Thu, Jul 26, 2007 at 02:51:51PM -0400, Jeff Garzik wrote:
> Not a _bug_ per se, but the above useless patch chunk seems to have
> leaked into this patch.
Weird. Those lines are deleted later in this patch series anyway, so
I don't intend to worry about this problem unless I respin the patch
s
On Thu, 26 Jul 2007 11:51:08 -0600
Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> On Thu, Jul 26, 2007 at 06:50:44PM +0100, Alan Cox wrote:
> > -[4] __initdata = {{0, IRQ_AUTO}, {0, IRQ_AUTO},
> > -{0 ,IRQ_AUTO}, {0, IRQ_AUTO}};
> > +[4] __initdata = { {
Fair comment - fixed - will send
Matthew Wilcox wrote:
Exercise my right to change the license from dual BSD/GPL to GPL
What do the other copyright holders think about this?
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Matthew Wilcox wrote:
@@ -4653,7 +4641,7 @@ advansys_biosparam(struct scsi_device *sdev, struct
block_device *bdev,
}
static int __init advansys_detect(struct scsi_host_template *tpnt);
-static int advansys_release(struct Scsi_Host *shp);
+static int advansys_release(struct Scsi_Host *shost
- Add a pci_driver interface for the PCI advansys devices.
- For ISA/EISA/VLB devices, we still call advansys_detect and
advansys_release.
- Many functions are converted from __init to __devinit to allow hotplug
PCI to work.
- Remove some now-unused macros and struct definitions
Signed-o
Update the version to 3.4
Add my copyright
Add myself to MAINTAINERS
Exercise my right to change the license from dual BSD/GPL to GPL
Don't force the definition of CONFIG_ISA on x86
Always include pci.h
Stop including stat.h
---
MAINTAINERS |6 ++
drivers/scsi/advansys.c | 43
On Thu, Jul 26, 2007 at 02:16:27PM -0400, Jeff Garzik wrote:
> In that case, reverse what I said: the above pci_register_driver commit
> breaks non-PCI probing.
Ah yes. Fair point.
> advansys_detect/release populate legacy list, but nothing ever happens
> from there... your "Move to scsi hot
Apparently it used to be possible to call the detect method twice.
That's not possible any more with the new style init routine.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c |9 -
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/drivers/s
On Thu, Jul 26, 2007 at 12:04:46PM -0600, Matthew Wilcox wrote:
> That happened in patch 4. The function that looks for ISA and VL is still
> called advansys_detect, but I can rename it to advansys_probe_legacy if
> you want.
Um. That's patch 4/22 ... or patch 3/21. I knew I should have used
gi
Use slave_configure() to do all the work that used to be done in
AscInquiryHandling and AdvInquiryHandling. Split slave_configure into
two functions, one for wide and one for narrow controllers.
Remove some unused definitions, duplicate definitions, unnecessary
declarations, and scsireqq, cap_inf
Matthew Wilcox wrote:
On Thu, Jul 26, 2007 at 07:01:12PM +0100, Christoph Hellwig wrote:
On Thu, Jul 26, 2007 at 01:22:42PM -0400, Matthew Wilcox wrote:
- Switch from scsi_register/scsi_unregister to scsi_host_alloc,
scsi_add_host, scsi_scan_host and scsi_host_put.
- Rename the scsi_host_t
By moving a test from AscGetChipBusType into its only caller, we can delete
the whole function
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 36
1 files changed, 4 insertions(+), 32 deletions(-)
diff --git a/drivers/scsi/ad
The error handling around that part of advansys_board_found() was tricky,
so I split out that part into its own function. It's still 120 lines, but
it's somewhat easier to see what's going on. Also use GFP_KERNEL when
allocating memory during initialisation, not GFP_ATOMIC.
Signed-off-by: Matthe
Make sure the resources are reserved and released by all the callers of
advansys_board_found(). This eliminates the check_region-style race.
It also allows us to use the pci_request_regions() API.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 103 ++
Just use the Scsi_Host passed in, rather than looking through the driver's
own array of boards for one that matches it.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 38 +-
1 files changed, 13 insertions(+), 25 deletions(-)
The cfg structures are supposed to be disposable after initialisation;
with the 'dev' used for DMA mapping in there, that's not possible. Move
the dev to the board.
Also inline AscInitFromAscDvcVar into its only caller, remove some
unnecessary prototypes and sort out a few minor formatting issues
On Thu, Jul 26, 2007 at 06:50:44PM +0100, Alan Cox wrote:
> -[4] __initdata = {{0, IRQ_AUTO}, {0, IRQ_AUTO},
> -{0 ,IRQ_AUTO}, {0, IRQ_AUTO}};
> +[4] __initdata = { {
> +0, IRQ_AUTO}, {
> +0, IRQ_AUTO}, {
> +0, IRQ_AUTO}, {
> +0, IRQ_AUTO}};
> #endif
A bit bizarre. I'd expect somethi
> > Compiles fine, unfortunately I can not test kernels on this machine since I
> > have yet to dig out the reason my kernels do not boot.
>
> That's about the best we can ask for :) Thanks. I'm pretty sure you do not
> have any SAS hardware in your sparc32...
Nope, this is a differnet computer
- Remove wrappers around the PCI configuration space accessors
- Call pci_set_master() instead of poking at config space directly
- Move the latency setting into one function called for both narrow and
wide boards.
- Tidy up AdvInitGetConfig() a little.
- Delete a few unused prototypes and
Remove some useless forward declarations
Reformat some comments, debug messages, and the occasional piece of real code
Removal of unnecessary braces
Don't need to initialise share_irq
Remove duplicate setting of shost->irq
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansy
From: Mike Christie <[EMAIL PROTECTED]>
This prevents the iscsi modules from being unloaded while
there are active mounts from an iscsi target.
Signed-off-by: Olaf Kirch <[EMAIL PROTECTED]>
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/infiniband/ulp/iser/iscsi_iser.c |1 +
dr
Meelis Roos wrote:
Eliminate unnecessary PCI dependencies in libsas. It should use generic DMA
and struct device like other subsystems.
Compiles fine, unfortunately I can not test kernels on this machine
since I have yet to dig out the reason my kernels do not boot.
That's about the best we
This patch set was made over scsi-rc-fixes. It contains small fixes
and a fix for a regression that went into 2.6.23-rc1. The patches
in this patchset should be suitable for fixes going into the next 2.6.23.
Boaz and Olaf, you guys will notice I am not sending the recv or xmit
rewrite patches or
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.23rc1-mm1/drivers/scsi/dtc.c
linux-2.6.23rc1-mm1/drivers/scsi/dtc.c
--- linux.vanilla-2.6.23rc1-mm1/drivers/scsi/dtc.c 2007-07-26
15:01:45.0 +0100
+++ linux-
From: FUJITA Tomonori <[EMAIL PROTECTED]>
Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg
Date: Fri, 27 Jul 2007 02:09:05 +0900
> Use-space applications can put four memory addresses in the bsg (sg
> v4) interface: request, response, dout_xferp, and din_xferp.
>
> For scsi co
Since the AdvanSys driver hasn't had a maintainer in 6 years, I don't
think anybody's going to seriously object to me taking this on.
I present a git tree of patches:
http://git.kernel.org/?p=linux/kernel/git/willy/advansys.git;a=summary
and the broken-out version of those patches:
http://www.ke
From: "Moore, Eric" <[EMAIL PROTECTED]>
Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg
Date: Thu, 26 Jul 2007 10:32:45 -0600
> On Thursday, July 26, 2007 4:09 AM, FUJITA Tomonori wrote:
> > The SMP response's function result wasn't set correctly? bsg's
> > smp_rep_manufactur
On Tuesday, July 24, 2007 4:07 AM, Prakash, Sathya wrote:
> The patches in this patch set adds support for logging
> facility that can be used
> to debug a number of Fusion MPT related problems.
>
> The logging support can be enabled or disabled changing the kernel
> configuration flag CONFIF_F
James Bottomley wrote:
Realistically, even for parisc, I can't see anyone producing a non-PCI
SAS device (even though I'd like one).
A non-PCI device embedded on an SoC or system bus is highly -likely-, IMO.
SAS+SATA silicon (w/out firmware assist as with aic94xx) is the
direction that Marvel
On Thu, Jul 26, 2007 at 08:46:47AM -0400, James Bottomley wrote:
> On Thu, 2007-07-26 at 05:21 -0400, Jeff Garzik wrote:
> > libsas should -not- require PCI, even though aic94xx does.
>
> Realistically, even for parisc, I can't see anyone producing a non-PCI
> SAS device (even though I'd like one)
From: "Moore, Eric" <[EMAIL PROTECTED]>
Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg
Date: Thu, 26 Jul 2007 16:05:32 -0600
> On Thursday, July 26, 2007 11:09 AM, FUJITA Tomonori wrote:
> > For smp request/response, we use:
> >
> > request -> not used
> > response -> not us
Done with my review. Any patches I did not comment on can be considered
sane...
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2007-07-26 at 16:00 -0400, Freels, James D. wrote:
> 9) the output from the commands you asked for are shown below for the
> 2.6.22.1 kernel. They indicate parity errors on the changer at scsi
> id=3. Also, when booting up under 2.6.18.8, the linux media changer
> scsi device works and in
On Thu, Jul 26, 2007 at 03:08:39PM -0400, Jeff Garzik wrote:
> Matthew Wilcox wrote:
> >On Thu, Jul 26, 2007 at 02:56:33PM -0400, Jeff Garzik wrote:
> >>Matthew Wilcox wrote:
> >>>Exercise my right to change the license from dual BSD/GPL to GPL
> >>What do the other copyright holders think about th
On Thu, Jul 26, 2007 at 02:56:33PM -0400, Jeff Garzik wrote:
> Matthew Wilcox wrote:
> >Exercise my right to change the license from dual BSD/GPL to GPL
>
> What do the other copyright holders think about this?
They're not contactable.
--
"Bill, look, we understand that you're interested in sel
n_io_port isn't suitable for advansys because some of the boards have
more than 255 bytes of io port space. There's already a driver-private
replacement, asc_n_io_port, but for some reason the driver was still
setting and occasionally reporting n_io_port.
Signed-off-by: Matthew Wilcox <[EMAIL PRO
Matthew Wilcox wrote:
On Thu, Jul 26, 2007 at 12:04:46PM -0600, Matthew Wilcox wrote:
That happened in patch 4. The function that looks for ISA and VL is still
called advansys_detect, but I can rename it to advansys_probe_legacy if
you want.
git-format-patch's --start-number option. This pa
The driver kept a copy of the PCI config address; refer to the pci_dev
associated with the card instead.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 29 +
1 files changed, 9 insertions(+), 20 deletions(-)
diff --git a/drivers/scsi
Convert adv_isr_callback, adv_async_callback and asc_isr_callback into
direct calls. Remove the unused asc_exe_callback.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 50 +++---
1 files changed, 8 insertions(+), 42 delet
On Thu, 2007-07-26 at 13:46 -0400, Jeff Garzik wrote:
> Meelis Roos wrote:
> >> Eliminate unnecessary PCI dependencies in libsas. It should use generic
> >> DMA
> >> and struct device like other subsystems.
> >
> > Compiles fine, unfortunately I can not test kernels on this machine
> > since I
On Thu, Jul 26, 2007 at 07:01:12PM +0100, Christoph Hellwig wrote:
> On Thu, Jul 26, 2007 at 01:22:42PM -0400, Matthew Wilcox wrote:
> > - Switch from scsi_register/scsi_unregister to scsi_host_alloc,
> >scsi_add_host, scsi_scan_host and scsi_host_put.
> > - Rename the scsi_host_template to a
- Switch the EISA probing to the driver model.
- Factor out the guts of advansys_pci_remove() so that
advansys_eisa_remove() can use it.
- Update the FIXME now that we use the correct driver model probing API
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 1
At some point during Linux 2.1 development, ioremap() gained the ability
to handle addresses which weren't page-aligned. Also expand the CONFIG_PCI
range to encompass that entire section of wide board initialisation, since
all wide boards are PCI.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
> Eliminate unnecessary PCI dependencies in libsas. It should use generic DMA
> and struct device like other subsystems.
Compiles fine, unfortunately I can not test kernels on this machine
since I have yet to dig out the reason my kernels do not boot.
--
Meelis Roos ([EMAIL PROTECTED])
-
To un
Use memcpy to initialise eep_config instead of a loop. For
AdvInitFrom38C1600EEP where we need to modify the default EEPROM
configuration, do it after the loop, and do it using the structure
definition, not by finding the right byte. I think it was wrong for
big-endian machines.
Also delete some
From: Mike Christie <[EMAIL PROTECTED]>
When we logout we block the session since we are not taking any more
commands, but when we call remove host we want to make sure any
IO that got queued up and blocked gets failed upwards quickly, so
we unblock the session and fail it.
Signed-off-by: Mike Chr
From: Mike Christie <[EMAIL PROTECTED]>
We should not be checking the cmd windown for just handling r2t responses.
And if the window closes in on us, always have scsi-ml requeue the command
from our queuecommand function.
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/scsi/libiscsi
On Thursday, July 26, 2007 4:09 AM, FUJITA Tomonori wrote:
> The SMP response's function result wasn't set correctly? bsg's
> smp_rep_manufacturer didn't check the result so it showed garbase, I
> guess.
>
> BTW, I took the code to check the result from Doug's smp_utils and put
> bsg's smp_rep_ma
On Thu, 2007-07-26 at 10:56 -0400, Freels, James D. wrote:
> James, I have been out for a couple of days and could not try this
> yet.
>
> Presently, the system is booted up under 2.6.18.8 which is not the
> troublesome kernel.
>
> However, I tried your suggestion below, using max_width instead o
From: Boaz Harrosh <[EMAIL PROTECTED]>
Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO
sg-chaining
Date: Wed, 25 Jul 2007 22:22:20 +0300
> FUJITA Tomonori wrote:
> > From: Benny Halevy <[EMAIL PROTECTED]>
> > Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi
On Thu, 2007-07-26 at 17:37 -0400, Freels, James D. wrote:
> Here is what I get when I apply the patch against the vanilla 2.6.22.1
> source:
The reject files all have spaces instead of tabs, so it looks like your
mailer did some nefarious translation.
Try the attachment ... that usually defeats
Reading this more, this commit breaks everything AFAICS.
You still use scsi_register, which populates ->legacy_hosts list, but no
longer include scsi_module.c. Thus you alloc a bunch of scsi hosts,
and... that's it.
They are never added, nor scanned.
Take a look at my gdth conversion, 'gdt
On Thu, Jul 26, 2007 at 01:22:42PM -0400, Matthew Wilcox wrote:
> - Switch from scsi_register/scsi_unregister to scsi_host_alloc,
>scsi_add_host, scsi_scan_host and scsi_host_put.
> - Rename the scsi_host_template to advansys_template
> - Move the memory freeing on error from advansys_wide_i
- Switch from scsi_register/scsi_unregister to scsi_host_alloc,
scsi_add_host, scsi_scan_host and scsi_host_put.
- Rename the scsi_host_template to advansys_template
- Move the memory freeing on error from advansys_wide_init_chip()
back into advansys_board_found() as we need to free it if
AscCompareString() is just another name for strncmp
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 23 +++
1 files changed, 3 insertions(+), 20 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 70f6d3a..42e33e
Eliminate unnecessary PCI dependencies in libsas. It should use generic
DMA and struct device like other subsystems.
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
diff --git a/drivers/scsi/aic94xx/aic94xx_init.c
b/drivers/scsi/aic94xx/aic94xx_init.c
index ab00aec..63bcde2 100644
--- a/drive
OK. Booted up great. Found the media changer. Here is the output from
the check you asked for:
target0:0:3: Beginning Domain Validation
target0:0:3: asynchronous
target0:0:3: FAST-20 SCSI 20.0 MB/s ST (50 ns, offset 32)
target0:0:3: Domain Validation skipping write tests
target0:0:3: Ending Dom
On Thu, Jul 26, 2007 at 03:50:45PM -0400, Jeff Garzik wrote:
> Done with my review. Any patches I did not comment on can be considered
> sane...
Thanks, Jeff, that was a Herculean effort. I've gone through and
made most of your suggested changes. I'm making too many mistakes now,
so it's time
On Thu, Jul 26, 2007 at 03:49:06PM -0400, Jeff Garzik wrote:
> ancillary TODO list item: check DMA mapping functions for failure
Added to in-driver TODO list
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take
On Thu, Jul 26, 2007 at 03:38:56PM -0400, Jeff Garzik wrote:
> Matthew Wilcox wrote:
> >+static void __devexit advansys_remove(struct Scsi_Host *shost)
> >+{
> >+int i;
> >+scsi_remove_host(shost);
> >+advansys_release(shost);
> >+
> >+for (i = 0; i < asc_board_count; i++) {
> >+
Put all the error cleanup at the end of the function and goto the
correct spot.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 106 --
1 files changed, 37 insertions(+), 69 deletions(-)
diff --git a/drivers/scsi/advans
Hi all,
I am newbie on SCSI.
Seems like scsi_level comes in response to the inquiry command.
/*
* struct scsi_device::scsi_level values. For SCSI devices other than those
* prior to SCSI-2 (i.e. over 12 years old) this value is (resp[2] + 1)
* where "resp" is a byte array of the response
From: Mike Christie <[EMAIL PROTECTED]>
It was found by LSI that on setups with large amounts of memory
we were bouncing buffers when we did not need to. If the iscsi tcp
code touches the data buffer (or a helper does),
it will kmap the buffer. iscsi_tcp also does not interact with hardware,
so it
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.23rc1-mm1/drivers/scsi/t128.c
linux-2.6.23rc1-mm1/drivers/scsi/t128.c
--- linux.vanilla-2.6.23rc1-mm1/drivers/scsi/t128.c 2007-07-26
15:01:46.0 +0100
+++ linu
According to the AdvanSys driver, this device has a problem with tagged
queueing.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_devinfo.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
in
Minor unimportant cuttings from the floor bundled in with a version
stamp update. Only controversial change is the dropping of Alan Cox
copyright on the nark.c module since that file has no code written by
him in it.
This attached patch is against current scsi-misc-2.6
ObligatoryDisclaimer: Pleas
ancillary TODO list item: check DMA mapping functions for failure
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks James. It patched this time, compiled, and is now rebooting. I
have a backup running tonight at 1am. I will report back in.
This would be great if it fixes it. I also have another similar bug
with the aic79xx driver on another machine (see my other bug reports).
I wonder if this will fi
92 matches
Mail list logo
