iterations is unsigned, so it is impossible to get out of the loop
and return -ETIMEDOUT.
Signed-off-by: Bill Nottingham <[EMAIL PROTECTED]>
---
If the intention *is* to never fall out of the end of the loop, ignore
this, and just replace it with do {} while (1);.
--- drivers/scsi/qla2xxx/qla_o
On Tue, May 29, 2007 at 06:21:36PM +0200, Geert Uytterhoeven wrote:
> On Tue, 29 May 2007, Christoph Hellwig wrote:
> > > +/*
> > > + * copy data from device into scatter/gather buffer
> > > + */
> > > +static int fill_from_dev_buffer(struct scsi_cmnd *cmd, const void *buf,
> > > +
On Tue, May 29, 2007 at 01:11:41PM +0200, Geert Uytterhoeven wrote:
> > This looks very inefficient. Just set sg_tablesize of your driver
> > to 1 to avoid getting mutiple segments.
>
> The disadvantage of setting sg_tablesize = 1 is that the driver will get small
> requests (PAGE_SIZE) most of t
Thanks for finding.
Acked-by: Seokmann Ju <[EMAIL PROTECTED]>
> -Original Message-
> From: Bill Nottingham [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, May 30, 2007 1:17 AM
> To: linux-scsi@vger.kernel.org
> Cc: Linux Driver; [EMAIL PROTECTED]
> Subject: [PATCH RFC] qla2xxx: fix timeout
I believe this issue is a result of the aacraid_commit_reset patch (as
posted for scsi-misc-2.6, enclosed to permit testing) not yet propagated
to the 2.6.22-rc3 tree.
This is the adapter taking longer than 3 minutes to start after a reset.
I seriously doubt either of these patches suggested below
On Wed, 2007-05-30 at 12:13 +0200, Christoph Hellwig wrote:
>
> For any sane hypervisor or hardware the copy should be worth
> than that. Then again a sane hardware or hypervisor would support
> SG requests..
Agreed... Sony should fix that, it's a bit ridiculous.
Ben.
-
To unsubscribe from th
Douglas Gilbert wrote:
For recent versions of smartmontools version 5.37 and
MPT Fusion SAS HBAs this should work if /dev/sdc is
a SATA disk. Your HBA may need a firmware upgrade.
You might fetch sg3_utils version 1.24 and try:
sg_sat_identify /dev/sdc
That needs to work before smartctl has
Miller, Mike (OS Dev) wrote:
>
>
>> -Original Message-
>> From: Hannes Reinecke [mailto:[EMAIL PROTECTED]
>> Sent: Tuesday, May 29, 2007 7:01 AM
>> To: Miller, Mike (OS Dev); SCSI Mailing List
>> Subject: cciss broken with 2.6.22-rc2
>>
>> Hi Mike,
>>
>> with the latest git snapshot the
On Wed, May 30, 2007 at 07:44:02AM -0400, Salyzyn, Mark wrote:
> I believe this issue is a result of the aacraid_commit_reset patch (as
> posted for scsi-misc-2.6, enclosed to permit testing) not yet propagated
> to the 2.6.22-rc3 tree.
>
> This is the adapter taking longer than 3 minutes to start
This is clouding the issue, Vivek.
There should be no harm, except to time, resetting the adapter. I do
want to optimize for boot time, but do not view this as a 'bug' if the
Adapter should reset during the initialization procedure. We need
instead to harden the driver to deal with Adapters that b
Inspired by Brian King's patch to the ibmvscsi driver. Adds support for
a changeable queue depth to the aacraid driver.
This attached patch is against current scsi-misc-2.6
ObligatoryDisclaimer: Please accept my condolences regarding Outlook's
handling of patch attachments.
Signed-off-by: Mark S
On Wed, May 30, 2007 at 09:57:08AM -0400, Salyzyn, Mark wrote:
> This is clouding the issue, Vivek.
>
> There should be no harm, except to time, resetting the adapter. I do
> want to optimize for boot time, but do not view this as a 'bug' if the
> Adapter should reset during the initialization pro
Vivek Goyal [mailto:[EMAIL PROTECTED] writes:
> So most likely if we start disabling the interrupts
> in .shutdown routine we might skip resetting adapter
> on every kexec without any side affects?
Not that simple. The .shutdown would need to perform more resource
cleanups of the .remove call to p
Moves quiesce, thread and interrupt shutdown into aacraid drivers'
.shutdown handler. This fix to the aac_shutdown handler will remove the
superfluous reset of the adapter during a (clean) kexec.
This fix may mitigate the active investigation 'kexec and aacraid
broken' but it is unlikely to affect
On 5/30/07, Salyzyn, Mark <[EMAIL PROTECTED]> wrote:
Moves quiesce, thread and interrupt shutdown into aacraid drivers'
.shutdown handler. This fix to the aac_shutdown handler will remove the
superfluous reset of the adapter during a (clean) kexec.
This fix may mitigate the active investigation
Benjamin Herrenschmidt wrote:
> On Wed, 2007-05-30 at 12:13 +0200, Christoph Hellwig wrote:
>>
>> For any sane hypervisor or hardware the copy should be worth
>> than that. Then again a sane hardware or hypervisor would support
>> SG requests..
>
> Agreed... Sony should fix that, it's a bit ridi
The following patches were made against scsi-misc. They contain fixes
and features including:
- Features:
1. Export sysfs values needed for OF/BIOS assisted iscsi boot.
2. Export sysfs values needed to be able to bind sessions to
a hba/port/NIC/netdev. This is needed for software iscsi so it can
b
From: Mike Christie <[EMAIL PROTECTED]>
We are going to be adding more host level sysfs attrs and
set_params, so this patch has them take a scsi_host instead
of either a scsi_host or host no.
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/scsi/qla4xxx/ql4_os.c | 19 ++---
From: Mike Christie <[EMAIL PROTECTED]>
The iscsi class uses the set_param event to set session
and connection params. This patch adds a set_host_param
so we can set host level values.
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_transport_iscsi.c | 29
From: Mike Christie <[EMAIL PROTECTED]>
For iscsi root boot, software iscsi needs to know what the BIOS/OF
initiator used for the initiator name so this puts it in sysfs
for userspace to be able to pick up.
For hw iscsi, it is nice to see what the card is using.
This patch adds the new param, an
From: Mike Christie <[EMAIL PROTECTED]>
Export mac as hw address.
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/scsi/qla4xxx/ql4_os.c | 39 +++
1 files changed, 35 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/driv
From: Mike Christie <[EMAIL PROTECTED]>
iscsid and udev need to key off the hw address being
used so add some helpers for iser and iscsi tcp.
Also convert them.
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/infiniband/ulp/iser/iscsi_iser.c |4 +++
drivers/scsi/iscsi_tcp.c
From: Mike Christie <[EMAIL PROTECTED]>
Let's not oops when we cannot allocate a skb! Add a check
for if alloc_skb fails.
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_transport_iscsi.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/driv
From: Mike Christie <[EMAIL PROTECTED]>
Add hw address sysfs file.
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_transport_iscsi.c | 35 +--
include/scsi/iscsi_if.h |8
include/scsi/scsi_transport_iscsi.h |5 +
From: Mike Christie <[EMAIL PROTECTED]>
The attached patches add sysfs files for the chap settings
to the iscsi transport class, iscsi_tcp and ib_iser. This is
needed for software iscsi because there are times when iscsid
can die and it will need to reread the values it was using.
And it is needed
From: Mike Christie <[EMAIL PROTECTED]>
- Remove shadow of request length from struct iscsi_cmd_task.
- change all users to use scsi_cmnd->request_bufflen directly
(With bidi we will use scsi-ml API to retrieve in/out length)
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
Signed-off-by: Benny H
From: Mike Christie <[EMAIL PROTECTED]>
This patch fixes handling of expected datasn/r2tsn as received from
target. It is done according to: T10 rfc3720 section 3.2.2.3. Data Sequencing.
. unify expected datasn/r2tsn into one counter
. calculate than check expected datasn/r2tsn. On error print a
From: Mike Christie <[EMAIL PROTECTED]>
If iscsi_tcp partially sends a header, it would recalculate the
header size and readd the size of the digest (if header digests
are used).This would cause us to send sizeof(digest) extra bytes
when we sent the rest of the header.
Signed-off-by: Mike Christi
From: Mike Christie <[EMAIL PROTECTED]>
The cmdsn allocation and pdu transmit code can race, and we can end
up sending a pdu with cmdsn 10 before a pdu with 5. The target will
then fail the connection/session. This patch fixes the problem by
delaying the cmdsn allocation until we are about to send
From: Mike Christie <[EMAIL PROTECTED]>
This patch allows us to set can_queue and cmds_per_lun from userspace
when we create the session/host. From there we can set it on a per
target basis. The patch fully converts iscsi_tcp, but only hooks
up ib_iser for cmd_per_lun since it currently has a lots
From: Mike Christie <[EMAIL PROTECTED]>
Userspace will want to know what the driver/FW/HW capabilites
when it comes to some operations like if the hardware can
do discovery or if it can store iscsi info like what target
was used for boot. This patch adds some new caps so userspace
can tell if the
From: Mike Christie <[EMAIL PROTECTED]>
If we got the padding, data and header in different skbs,
we were not handling the padding correctly because we attributed it
to the data's skb. This resulted in the initiator reading from
pad bytes + skb offset instead of the correct offset.
If you could n
From: Mike Christie <[EMAIL PROTECTED]>
This patch should fix the file descriptor leak problem. A quick look
through the kernel shows that users of sockfd_lookup use sockfd_put to
release their handle. We were using sock_release which from the comments
and code look like it does not release the ge
From: Mike Christie <[EMAIL PROTECTED]>
This patch exports the local address for the session. For
qla4xxx this is the ip of the hba's port. For software
this is the src addr of the socket.
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/scsi/iscsi_tcp.c| 127
From: Mike Christie <[EMAIL PROTECTED]>
Add a slave_configure function to iSCSI TCP to remove any DMA
alignment restriction. This permits the use of direct IO from
arbitrary addresses.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/s
From: Mike Christie <[EMAIL PROTECTED]>
iSCSI must support software iscsi (iscsi_tcp, iser), hardware iscsi (qla4xxx),
and partial offload (broadcom). To be able to allow each stack or driver
or port (virtual or physical) to be able to log into the same target portal
we use the initiator tuple [[H
On Mon, May 28 2007, Andrew Patterson wrote:
> I am running into deadlock during domain validation when the request
> queue is full. I am using the MPT Fusion spi driver and have run into
> this problem with 2.6.16 and the latest scsi_misc kernels. The system
> is running a load test on a u320 pSC
On Wed, 2007-05-30 at 20:01 +0200, Jens Axboe wrote:
> On Mon, May 28 2007, Andrew Patterson wrote:
> > I am running into deadlock during domain validation when the request
> > queue is full. I am using the MPT Fusion spi driver and have run into
> > this problem with 2.6.16 and the latest scsi_mis
On Wed, May 30 2007, James Bottomley wrote:
> On Wed, 2007-05-30 at 20:01 +0200, Jens Axboe wrote:
> > On Mon, May 28 2007, Andrew Patterson wrote:
> > > I am running into deadlock during domain validation when the request
> > > queue is full. I am using the MPT Fusion spi driver and have run into
On Wed, 2007-05-30 at 20:55 +0200, Jens Axboe wrote:
> On Wed, May 30 2007, James Bottomley wrote:
> > On Wed, 2007-05-30 at 20:01 +0200, Jens Axboe wrote:
> > > On Mon, May 28 2007, Andrew Patterson wrote:
> > > > I am running into deadlock during domain validation when the request
> > > > queue i
On Wed, May 30 2007, James Bottomley wrote:
> On Wed, 2007-05-30 at 20:55 +0200, Jens Axboe wrote:
> > On Wed, May 30 2007, James Bottomley wrote:
> > > On Wed, 2007-05-30 at 20:01 +0200, Jens Axboe wrote:
> > > > On Mon, May 28 2007, Andrew Patterson wrote:
> > > > > I am running into deadlock dur
On Wed, 2007-05-30 at 21:03 +0200, Jens Axboe wrote:
> On Wed, May 30 2007, James Bottomley wrote:
> > On Wed, 2007-05-30 at 20:55 +0200, Jens Axboe wrote:
> > > On Wed, May 30 2007, James Bottomley wrote:
> > > > On Wed, 2007-05-30 at 20:01 +0200, Jens Axboe wrote:
> > > > > On Mon, May 28 2007, A
On Wed, May 30 2007, James Bottomley wrote:
> On Wed, 2007-05-30 at 21:03 +0200, Jens Axboe wrote:
> > On Wed, May 30 2007, James Bottomley wrote:
> > > On Wed, 2007-05-30 at 20:55 +0200, Jens Axboe wrote:
> > > > On Wed, May 30 2007, James Bottomley wrote:
> > > > > On Wed, 2007-05-30 at 20:01 +02
On Wed, 2007-05-30 at 21:11 +0200, Jens Axboe wrote:
> > > > > > > There's no other solution than maintaining a cached request +
> > > > > > > command
> > > > > > > for this. libata has a similar issue wrt error handling with ncq,
> > > > > > > we may
> > > > > > > need a command in error handlin
On 5/30/07, Salyzyn, Mark <[EMAIL PROTECTED]> wrote:
Vivek Goyal [mailto:[EMAIL PROTECTED] writes:
> So most likely if we start disabling the interrupts
> in .shutdown routine we might skip resetting adapter
> on every kexec without any side affects?
Not that simple. The .shutdown would need to
On 5/30/07, Salyzyn, Mark <[EMAIL PROTECTED]> wrote:
I believe this issue is a result of the aacraid_commit_reset patch (as
posted for scsi-misc-2.6, enclosed to permit testing) not yet propagated
to the 2.6.22-rc3 tree.
This is the adapter taking longer than 3 minutes to start after a reset.
I
Yinghai Lu [mailto:[EMAIL PROTECTED] writes:
> aacraid_commit_reset.patch is in the mainline already.
But aacraid_commit_reset.patch is not in 2.6.22-rc3 (to which you report
the issue). Does the aacraid_commit_reset.patch work to resolve this
issue all by itself in the kexec'd kernel? Or alternat
On 5/30/07, Salyzyn, Mark <[EMAIL PROTECTED]> wrote:
Yinghai Lu [mailto:[EMAIL PROTECTED] writes:
> aacraid_commit_reset.patch is in the mainline already.
But aacraid_commit_reset.patch is not in 2.6.22-rc3 (to which you report
the issue). Does the aacraid_commit_reset.patch work to resolve this
On 5/27/07, Stefan Richter <[EMAIL PROTECTED]> wrote:
The attribute /sys/bus/scsi/devices/*:*:*:*/ieee1394_id, as generated by
the old sbp2 driver, is typically used to create persistently named
links in /dev/disk/by-id.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
Looks good to me.
Sign
Dear Sir.
when i use the kernel 2.6.21,
althought the system can find the Raid card but
couldn't find any Hard Driver of the this card, can
you help me, how to fix it.
the raid card model is
LSI Megaraid i4 or DELL CERC ATA100/4CH
Fw version: 6.62, megaraid driver is 2.0.0.4 in kernel
On Wed, 2007-05-30 at 14:22 -0500, James Bottomley wrote:
> On Wed, 2007-05-30 at 21:11 +0200, Jens Axboe wrote:
> > > > > > > > There's no other solution than maintaining a cached request +
> > > > > > > > command
> > > > > > > > for this. libata has a similar issue wrt error handling with
> > >
On Wed, May 30 2007, Andrew Patterson wrote:
> On Wed, 2007-05-30 at 14:22 -0500, James Bottomley wrote:
> > On Wed, 2007-05-30 at 21:11 +0200, Jens Axboe wrote:
> > > > > > > > > There's no other solution than maintaining a cached request +
> > > > > > > > > command
> > > > > > > > > for this. li
52 matches
Mail list logo
