[PATCH] ieee1394: sbp2: offer SAM-conforming target port ID in sysfs

2007-05-27 Thread Stefan Richter
With "modprobe sbp2 long_ieee1394_id=y", the format of /sys/bus/scsi/devices/*:*:*:*/ieee1394_id is changed from e.g. 0001041010004beb:0:0 to 0001041010004beb:00042c:. The longer format fully conforms to object identifier sizes as per SAM(-2...4) and reflects what the SAM target port identifie

[PATCH] firewire: fw-sbp2: implement sysfs ieee1394_id

2007-05-27 Thread Stefan Richter
The attribute /sys/bus/scsi/devices/*:*:*:*/ieee1394_id, as generated by the old sbp2 driver, is typically used to create persistently named links in /dev/disk/by-id. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-device.h |1 drivers/firewire/fw-sbp2.c | 53 ++

[PATCH] SCSI/fdomain: fix PCMCIA-related warnings

2007-05-27 Thread Jeff Garzik
fdomain is one of those drivers that is compiled twice, once for PCMCIA and once for non-PCMCIA. The resultant two-driver setup leaves a bit of dead code and data in the non-PCMCIA case, which gcc complains about. Shuffle ifdefs a bit to eliminate the conditionally-dead code, and the compiler wa

[PATCH 0/5] SCSI/initio fixes, cleanups, PCI API support

2007-05-27 Thread Jeff Garzik
This patchset presents the path to PCI API support in the initio driver. But the first patch really begs the question: Has this driver really been broken since Oct 2003? If so, let's just delete it. drivers/scsi/initio.c | 206 +- drivers/scsi/

[PATCH 1/5] SCSI/initio PCI DMA fix

2007-05-27 Thread Jeff Garzik
The 'pci_dev' member of HCS is referenced during PCI DMA, but never actually assigned a value. Let's give it a useful value. Has this driver been broken since PCI DMA support was added in Oct 2003? Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> a5eec1873b5934de70c589ad0f4596f78c4d0dd3 diff --g

[PATCH 2/5] SCSI/initio pci_dev, pci_dev->irq simplifications

2007-05-27 Thread Jeff Garzik
Now that pci_dev is available in the adapter table, we can logically simplify Addi91u_into_Adapter_table(), HCS and INI_ADPT_STRUCT. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> 0151ba1cfeb6565bd1e79b5ba913423f19602d2e diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c index 8951494..d

[PATCH 3/5] SCSI/initio minor cleanups

2007-05-27 Thread Jeff Garzik
Two minor cleanups: * eliminate unused ADPT_Device struct member * eliminate redundant return statements Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> 8ce38698fb5c65128621823e34830ed6c738f3be diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c index d25a228..2bc2390 100644 --- a/drivers/

[PATCH 4/5] SCSI/initio PCI dev init factorization

2007-05-27 Thread Jeff Garzik
Factor PCI device init into separate function. No code changes, except for return value differences. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> 6714c073a9df8c923fbfc661a1f287dfd1a74852 diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c index 2bc2390..702dcf5 100644 --- a/drivers/scs

[PATCH 5/5] SCSI/initio conversion to PCI driver API

2007-05-27 Thread Jeff Garzik
Prior simplifications in this patchset now permit a minimal conversion to the new PCI API. Further improvements and simplifications are certainly possible; those should be presented in a separate patchset. DO NOT APPLY (yet). For feedback (and testers?) only. 3f42ce6a28b81cb057b2304e3aca6e873

Re: [PATCH 5/5] SCSI/initio conversion to PCI driver API

2007-05-27 Thread Jeff Garzik
Jeff Garzik wrote: Prior simplifications in this patchset now permit a minimal conversion to the new PCI API. Further improvements and simplifications are certainly possible; those should be presented in a separate patchset. DO NOT APPLY (yet). For feedback (and testers?) only. This only ap

Re: [PATCH 5/5] SCSI/initio conversion to PCI driver API

2007-05-27 Thread James Bottomley
On Sun, 2007-05-27 at 11:03 -0400, Jeff Garzik wrote: > Jeff Garzik wrote: > > Prior simplifications in this patchset now permit a minimal conversion > > to the new PCI API. > > > > Further improvements and simplifications are certainly possible; those > > should be presented in a separate patchse

Re: [PATCH 0/5] SCSI/initio fixes, cleanups, PCI API support

2007-05-27 Thread Alan Cox
On Sun, 27 May 2007 10:52:00 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > > This patchset presents the path to PCI API support in the initio driver. > > But the first patch really begs the question: Has this driver really > been broken since Oct 2003? If so, let's just delete it. Jeff. I (a

Re: [PATCH 5/5] SCSI/initio conversion to PCI driver API

2007-05-27 Thread Alan Cox
On Sun, 27 May 2007 11:03:53 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Jeff Garzik wrote: > > Prior simplifications in this patchset now permit a minimal conversion > > to the new PCI API. > > > > Further improvements and simplifications are certainly possible; those > > should be presented

Re: [PATCH 5/5] SCSI/initio conversion to PCI driver API

2007-05-27 Thread Jeff Garzik
James Bottomley wrote: On Sun, 2007-05-27 at 11:03 -0400, Jeff Garzik wrote: Jeff Garzik wrote: Prior simplifications in this patchset now permit a minimal conversion to the new PCI API. Further improvements and simplifications are certainly possible; those should be presented in a separate pa

[PATCH] Remove dead references to MODULE_PARM macro.

2007-05-27 Thread Robert P. J. Day
Remove the useless references to the obsolete MODULE_PARM macro. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- just spending a few minutes cleaning the tree of the few remaining references to MODULE_PARM. diff --git a/drivers/scsi/ibmmca.c b/drivers/scsi/ibmmca.c index 0e57fb6..09

Re: [PATCH] [scsi] Remove __GFP_DMA

2007-05-27 Thread James Bottomley
On Wed, 2007-05-23 at 20:38 +0100, Alan Cox wrote: > On Wed, 23 May 2007 15:17:08 -0400 > "Salyzyn, Mark" <[EMAIL PROTECTED]> wrote: > > > The 31 bit limit for some of these cards is a problem, we currently only > > do __GFP_DMA for bounce buffer sg elements allocated for user supplied > > referen