[PATCH 0/9] Resurrect sdev during scanning

2007-05-23 Thread Hannes Reinecke
Hi James, this is a patchset to address the outstanding 'sdev oops during scanning' issue. Problem is that any sdev in state 'SDEV_DEL' is still visible to the host until the refcount drops to zero. When a scan occurs during this time we access a half-initialized sdev and all hell breaks loose. S

[PATCH 1/9] Add scsi_destroy_device()

2007-05-23 Thread Hannes Reinecke
This patchs adds a new helper scsi_destroy_device(). It will transition and sdev into the 'SDEV_DEL' state. Signed-off-by: Hannes Reinecke <[EMAIL PROTECTED]> --- drivers/scsi/scsi_scan.c |3 +-- include/scsi/scsi_device.h |6 ++ 2 files changed, 7 insertions(+), 2 deletions(-) di

[PATCH 2/9] Improve error messages in scsi_sysfs_add_sdev()

2007-05-23 Thread Hannes Reinecke
When we fail to add a device to the driver core, only the very helpful message 'error X' is displayed. Print out some meaningful messages. Signed-off-by: Hannes Reinecke <[EMAIL PROTECTED]> --- drivers/scsi/scsi_sysfs.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 3/9] Remove stale put_device() from scsi_sysfs_add_sdev()

2007-05-23 Thread Hannes Reinecke
In one obscure error path someone decided to do a put_device() on the sdev parent. As this is the only reference to it I don't thing it makes much sense. Remove it. Signed-off-by: Hannes Reinecke <[EMAIL PROTECTED]> --- drivers/scsi/scsi_sysfs.c |1 - 1 files changed, 0 insertions(+), 1 dele

[PATCH 4/9] Free sdev class device from release function

2007-05-23 Thread Hannes Reinecke
For a clean teardown of a sdev the class device should really be freed from the sdev's release function. This way we don't have to worry about refcounting the class device structures itself. And the functions are now better aligned with the sdev state model; _scsi_remove_device() transitions the s

[PATCH 5/9] Fixup LLDDs to check for valid hostdata pointer

2007-05-23 Thread Hannes Reinecke
slave_destory() is now called asynchronously, hence we have to check if the ->hostdata pointer is valid before accessing it. Fixup all LLDDs to verify the hostdata pointer. Signed-off-by: Hannes Reinecke <[EMAIL PROTECTED]> --- drivers/message/fusion/mptscsih.c |2 ++ drivers/s390/scsi/zfc

[PATCH 6/9] Implement scsi_configure_device()

2007-05-23 Thread Hannes Reinecke
This patch implements the function scsi_configure_device(). This function elevates an sdev into SDEV_RUNNING and configures it properly so that I/O is possible on the device. Signed-off-by: Hannes Reinecke <[EMAIL PROTECTED]> --- drivers/scsi/scsi_scan.c | 62 --

[PATCH 7/9] Remove obsolete scsi_destroy_sdev() function

2007-05-23 Thread Hannes Reinecke
scsi_destroy_sdev() is now obsolete. Delete it. Signed-off-by: Hannes Reinecke <[EMAIL PROTECTED]> --- drivers/scsi/scsi_scan.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 82fad00..2653015 100644 --- a/

[PATCH 8/9] Implement scsi_resurrect_device()

2007-05-23 Thread Hannes Reinecke
This is the main part. This patch implements a function scsi_resurrect_device() which puts a sdev in state SDEV_CANCEL back into SDEV_RUNNING. So during scan any device in state SDEV_DEL (ie waiting to be deleted) will be put back into SDEV_RUNNING and normal scanning can continue on these devices

[PATCH 9/9] Leftovers

2007-05-23 Thread Hannes Reinecke
Forgot to call scsi_destroy_device() in scsi_forget_host(). Shame on me. Signed-off-by: Hannes Reinecke <[EMAIL PROTECTED]> --- drivers/scsi/scsi_scan.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 75b8a78..6a5

Re: [Stgt-devel] Question for pass-through target design

2007-05-23 Thread Vladislav Bolkhovitin
Robert Jennings wrote: What I meant that is that the kernel tgt code (scsi_tgt*) receives SCSI commands from one lld and send them to another lld instead of sending them to user space. Although the approach of passing SCSI commands from a target LLD to an initiator one without any significant i

[PATCH] Un-remove aacraid devices

2007-05-23 Thread Hannes Reinecke
Hi Mark, for some weird reason the aacraid driver insists on presenting all disks as 'removable' devices. This is gross hackery and causes userspace tools to not identify these devices as fixed disks, which most evidently they are. Please apply. Cheers, Hannes -- Dr. Hannes Reinecke

[Stgt-devel] Question about the basic concept of SCSI layer and Block layer

2007-05-23 Thread jidong xiao
Hi,All, I have a question, what's the relationship between SCSI layer and Block layer?I remember initially there are three types of device drivers, say, char device driver, block device driver, network device driver, so there is a directory "drivers/block",but recent years,most part of the code f

Re: [Stgt-devel] Question about the basic concept of SCSI layer and Block layer

2007-05-23 Thread Ming Zhang
On Wed, 2007-05-23 at 21:55 +0800, jidong xiao wrote: > Hi,All, > I have a question, what's the relationship between SCSI layer and > Block layer?I remember initially there are three types of device > drivers, say, char device driver, block device driver, network device > driver, so there is a di

Re: [PATCH 5/9] Fixup LLDDs to check for valid hostdata pointer

2007-05-23 Thread Christoph Hellwig
On Wed, May 23, 2007 at 10:55:38AM +0200, Hannes Reinecke wrote: > > slave_destory() is now called asynchronously, hence we have to > check if the ->hostdata pointer is valid before accessing it. > Fixup all LLDDs to verify the hostdata pointer. No way we're going to put this in. This just creat

Re: [PATCH] scsi_error: send the sense buffer down without copying

2007-05-23 Thread Benny Halevy
James Bottomley wrote: > Now that the block submission path correctly bounces, we can simply > use the command sense_buffer to send to retrieve sense information and > junk the unnecessary page allocation. Cool. I like that :) Benny > > James > > Index: scsi-misc-2.6/drivers/scsi/scsi_error.c

Re: [PATCH] [scsi] Remove __GFP_DMA

2007-05-23 Thread James Bottomley
On Wed, 2007-05-23 at 10:41 +0800, Aubrey Li wrote: > On 5/23/07, Christoph Lameter <[EMAIL PROTECTED]> wrote: > > On Mon, 21 May 2007, Bernhard Walle wrote: > > > > > [PATCH] [scsi] Remove __GFP_DMA > > > > > > After 821de3a27bf33f11ec878562577c586cd5f83c64, it's not necessary to > > > alloate a

Re: [patch 14/28] scsi: fix CONFIG_SCSI_WAIT_SCAN=m

2007-05-23 Thread Hugh Dickins
Regression still outstanding: ping? On Fri, 18 May 2007, Hugh Dickins wrote: > On Fri, 11 May 2007, Hugh Dickins wrote: > > On Thu, 10 May 2007, [EMAIL PROTECTED] wrote: > > > From: Hugh Dickins <[EMAIL PROTECTED]> > > > > > > CONFIG_MODULES=y > > > CONFIG_SCSI=y > > > CONFIG_SCSI_SCAN_ASYNC=y >

Re: [PATCH] [scsi] Remove __GFP_DMA

2007-05-23 Thread Robert P. J. Day
On Wed, 23 May 2007, James Bottomley wrote: > I'll defer to Mark on this one. However, please remember that you > can't just blindly remove GFP_DMA ... there are some cards which > require it. > > Aacraid is one example ... it has a set of cards that can only DMA > to 31 bits. For them, the GFP_

Re: [PATCH] [scsi] Remove __GFP_DMA

2007-05-23 Thread James Bottomley
On Wed, 2007-05-23 at 11:55 -0400, Robert P. J. Day wrote: > On Wed, 23 May 2007, James Bottomley wrote: > > > I'll defer to Mark on this one. However, please remember that you > > can't just blindly remove GFP_DMA ... there are some cards which > > require it. > > > > Aacraid is one example ...

Re: [patch 5/7] genhd: send async notification on media change

2007-05-23 Thread Kristen Carlson Accardi
On Tue, 22 May 2007 14:12:11 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 9 May 2007 16:38:35 -0700 > Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote: > > > Send an uevent to user space to indicate that a media change event has > > occurred. > > > > Signed-off-by: Kristen Carlson

RE: [PATCH] Un-remove aacraid devices

2007-05-23 Thread Salyzyn, Mark
NAK This will break all our management applications, and will not allow us to manipulate the array configurations from within Linux. This will also break online expansion of capacity. This flag has been set from the beginning to allow partition tables, capacity and device locking to be changed

Re: [patch 5/7] genhd: send async notification on media change

2007-05-23 Thread James Bottomley
On Wed, 2007-05-23 at 09:31 -0700, Kristen Carlson Accardi wrote: > On Tue, 22 May 2007 14:12:11 -0700 > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Wed, 9 May 2007 16:38:35 -0700 > > Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote: > > > > > Send an uevent to user space to indicate that

RE: [PATCH] Un-remove aacraid devices

2007-05-23 Thread James Bottomley
On Wed, 2007-05-23 at 12:35 -0400, Salyzyn, Mark wrote: > NAK > > This will break all our management applications, and will not allow us to > manipulate the array configurations from within Linux. This will also break > online expansion of capacity. > > This flag has been set from the beginning

Re: [PATCH] Un-remove aacraid devices

2007-05-23 Thread Michael Tokarev
Salyzyn, Mark wrote: > NAK > > This will break all our management applications, and will not allow us to > manipulate the array configurations from within Linux. This will also break > online expansion of capacity. > > This flag has been set from the beginning to allow partition tables, capacit

RE: [PATCH] Un-remove aacraid devices

2007-05-23 Thread Salyzyn, Mark
The applications may issue the start of an expansion, but then disappear. The Firmware is responsible for completing the job with the help of the driver. We issue a scsi_rescan_device when the job is completed, removable bit set turns off the capacity & partition table caching. We would need a sim

RE: [PATCH] Un-remove aacraid devices

2007-05-23 Thread Salyzyn, Mark
Another note, the old old aacraid driver used to report removable device in the inquiry. We found we could mitigate the devices report somewhat by reporting a fixed dfisk inquiry, but turning on the removable bit for the scsi device after the scan but before attachment by setting this in the read c

Re: [patch 5/7] genhd: send async notification on media change

2007-05-23 Thread Kristen Carlson Accardi
On Wed, 23 May 2007 12:03:55 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Wed, 2007-05-23 at 09:31 -0700, Kristen Carlson Accardi wrote: > > On Tue, 22 May 2007 14:12:11 -0700 > > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > On Wed, 9 May 2007 16:38:35 -0700 > > > Kristen Carlson A

Re: [patch 5/7] genhd: send async notification on media change

2007-05-23 Thread James Bottomley
On Wed, 2007-05-23 at 11:26 -0700, Kristen Carlson Accardi wrote: > On Wed, 23 May 2007 12:03:55 -0500 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Wed, 2007-05-23 at 09:31 -0700, Kristen Carlson Accardi wrote: > > > On Tue, 22 May 2007 14:12:11 -0700 > > > Andrew Morton <[EMAIL PROTECTED

RE: [PATCH] [scsi] Remove __GFP_DMA

2007-05-23 Thread Salyzyn, Mark
The 31 bit limit for some of these cards is a problem, we currently only do __GFP_DMA for bounce buffer sg elements allocated for user supplied references in ioctls. I figure we should be using pci_alloc_consistent calls for these allocations to more accurately acquire memory within the 31 bit lim

Re: [PATCH] [scsi] Remove __GFP_DMA

2007-05-23 Thread Alan Cox
On Wed, 23 May 2007 15:17:08 -0400 "Salyzyn, Mark" <[EMAIL PROTECTED]> wrote: > The 31 bit limit for some of these cards is a problem, we currently only > do __GFP_DMA for bounce buffer sg elements allocated for user supplied > references in ioctls. > > I figure we should be using pci_alloc_consi

Re: [patch 5/7] genhd: send async notification on media change

2007-05-23 Thread Kristen Carlson Accardi
On Wed, 23 May 2007 13:51:51 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Wed, 2007-05-23 at 11:26 -0700, Kristen Carlson Accardi wrote: > > On Wed, 23 May 2007 12:03:55 -0500 > > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > On Wed, 2007-05-23 at 09:31 -0700, Kristen Carlson Acca

Re: SMART support for SATA drives in SAS enclosures

2007-05-23 Thread Douglas Gilbert
Pim Zandbergen wrote: > Is SMART support available for SATA drives in SAS enclosures? > > I'm testing this setup > > LSI Logic SAS3800X PCI-X SAS controller (mptsas driver) > Promise V-Trak J300S SAS/SATA enclosure/expander > 12x Seagate ST3500630NS > Linux kernel 2.6.21.1 x86_64 > smartmontools-

RE: Sg_ses question

2007-05-23 Thread Haefliger, Juerg
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Douglas Gilbert > Sent: Tuesday, May 22, 2007 1:29 PM > To: Haefliger, Juerg > Cc: linux-scsi@vger.kernel.org > Subject: Re: Sg_ses question > > Haefliger, Juerg wrote: > > Hi, > > > > Not sure if thi

[patch 06/25] drivers/scsi/wd33c93.c: cleanups

2007-05-23 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - #include for getting the prototypes of {dis,en}able_irq() - make the needlessly global wd33c93_setup() static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/wd33c93.c |4 +++- 1 files

[patch 10/25] fdomain.c: get rid of unused stuff

2007-05-23 Thread akpm
From: Parag Warudkar <[EMAIL PROTECTED]> fdomain.c uses the below stuff only if PCMCIA is not defined. This causes unused variables to be defined when PCMCIA is not defined. Wrap variables and functions around #ifndef PCMCIA appropriately to avoid this. 4 less compiler warnings. Signed-off-by:

[patch 01/25] drivers/scsi/: small cleanups

2007-05-23 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> This patch contains the following cleanups: - make needlessly global functions static - every file should #include the headers containing the prototypes for it's global functions Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PRO

[patch 07/25] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver

2007-05-23 Thread akpm
From: Martin Bligh <[EMAIL PROTECTED]> Fix up compiler warnings in megaraid driver [EMAIL PROTECTED]: build fix] Signed-off-by: Martin J. Bligh <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c | 22 +++

[patch 02/25] drivers/scsi/advansys.c: cleanups

2007-05-23 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - remove the unneeded advansys.h - remove the unused advansys_setup() - make needlessly global functions static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/advansys.c | 101 +++---

[patch 04/25] drivers/scsi/NCR5380.c: Replacing yield() with a better alternative

2007-05-23 Thread akpm
From: Amol Lad <[EMAIL PROTECTED]> Replaced yield() with cond_resched() Signed-off-by: Amol Lad <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/NCR5380.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff

[patch 03/25] scsi: remove unnecessary check in drivers/scsi/sg.c

2007-05-23 Thread akpm
From: Eric Sesterhenn <[EMAIL PROTECTED]> coverity spotted this (cid #758). All callers dereference sfp, so we dont need this check. In addition to this, we dereference it earlier in the function. Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]> Cc: Douglas Gilbert <[EMAIL PROTECTED]> Cc: Jam

[patch 09/25] SCSI: Fix obvious typo "spin_lock_irqrestore()" in gdth.c

2007-05-23 Thread akpm
From: "Robert P. J. Day" <[EMAIL PROTECTED]> Fix misspelled "spin_lock_irqrestore" to read "spin_unlock_irqrestore" instead. Presumably, GDTH_RTC doesn't get used a lot. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off

[patch 05/25] sym53c8xx_2 claims cpqarray device

2007-05-23 Thread akpm
From: Chip Coldwell <[EMAIL PROTECTED]> Apropos this thread http://marc.theaimsgroup.com/?l=linux-scsi&m=115591706804045&w=2 which led to this patch http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-rc-fixes-2.6.git;a=commit;h=b2b3c121076961333977f485f0d54c22121df920 do we not also need

[AIC7xxx] tree things to report

2007-05-23 Thread Emmanuel Fusté
Hello, After one year of rest, I resurrect my old computer, install a 2.6.21 kernel and updated my Debian distro. Tree things to repport: First, a cosmetic thing: I have two scsi sync devices and two async devices. For the first ones, domain validation return the negociated speed and mode. For t

[patch 14/25] SCSI: use irq_handler_t where appropriate

2007-05-23 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/aacraid/aacraid.h |2 +- drivers/scsi/qla2xxx/qla_isr.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/scsi/

[patch 08/25] make seagate_st0x_detect() static

2007-05-23 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> seagate_st0x_detect() can become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/seagate.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/scsi/seagate.c~m

[patch 11/25] scsi: fix CONFIG_SCSI_WAIT_SCAN=m

2007-05-23 Thread akpm
From: Hugh Dickins <[EMAIL PROTECTED]> CONFIG_MODULES=y CONFIG_SCSI=y CONFIG_SCSI_SCAN_ASYNC=y CONFIG_SCSI_WAIT_SCAN=m 2.6.21-rc5-mm2 VFS panics unable to find my root on /dev/sda2, but boots okay if I change drivers/scsi/Kconfig to "default y" instead of "default m" for SCSI_WAIT_SCAN. Make sur

[patch 18/25] drivers/message/i2o/device.c: remove redundant GFP_ATOMIC from kmalloc

2007-05-23 Thread akpm
From: Satyam Sharma <[EMAIL PROTECTED]> drivers/message/i2o/device.c:i2o_parm_field_get() unnecessarily passes GFP_ATOMIC (along with GFP_KERNEL) to kmalloc() from a context that is not atomic. Remove the pointless GFP_ATOMIC. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> Signed-off-by: Andrew

[patch 19/25] drivers/scsi/aic7xxx_old.c: remove redundant GFP_ATOMIC from kmalloc

2007-05-23 Thread akpm
From: Satyam Sharma <[EMAIL PROTECTED]> drivers/scsi/aic7xxx_old.c:aic7xxx_slave_alloc() unnecessarily passes GFP_ATOMIC (along with GFP_KERNEL) to kmalloc() from a context that is not atomic. Remove the pointless GFP_ATOMIC. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> Signed-off-by: Andrew

[patch 25/25] ncr5380 warning fixes

2007-05-23 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> squish these: drivers/scsi/NCR5380.c:360: warning: 'phases' defined but not used drivers/scsi/NCR5380.c:360: warning: 'phases' defined but not used drivers/scsi/NCR5380.c:633: warning: 'NCR5380_print_options' defined but not used drivers/scsi/NCR5380.c:708

[patch 23/25] scsi: megaraid_sas: intercept cmd timeout and throttle io

2007-05-23 Thread akpm
From: Sumant Patro <[EMAIL PROTECTED]> eh_timed_out call back (megasas_reset_timer) is used to throttle io to the adapter when it is called the first time for a scmd. The MEGASAS_FW_BUSY flag is set and can_queue reduced to 16. The can_queue is restored from completion routine in following two c

[patch 24/25] scsi: remove __GFP_DMA

2007-05-23 Thread akpm
From: Bernhard Walle <[EMAIL PROTECTED]> After 821de3a27bf33f11ec878562577c586cd5f83c64, it's not necessary to allocate a DMA buffer any more in sd.c. Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Acked-by: Christoph Lameter <[EMAIL PROTECTED]> Signed-o

[patch 15/25] drivers/scsi/pcmcia/nsp_cs.c: remove kernel 2.4 code

2007-05-23 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/pcmcia/nsp_cs.c | 159 + drivers/scsi/pcmcia/nsp_cs.h |8 - 2 files changed, 5 insertions(+), 162 deletions(

[patch 21/25] scsi: fix ambiguous gdthtable definition

2007-05-23 Thread akpm
From: David Rientjes <[EMAIL PROTECTED]> Labeling a variable as __attribute_used__ is ambiguous: it means __attribute__((unused)) for gcc <3.4 and __attribute__((used)) for gcc >=3.4. There is no such thing as labeling a variable as __attribute__((used)). We assume that we're simply suppressing

[patch 17/25] drivers/scsi/nsp32.c: remove kernel 2.4 code

2007-05-23 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: GOTO Masanori <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/nsp32.c | 109 - 1 files changed, 13 insertions(+), 96 delet

[patch 22/25] Use menuconfig objects II - SCSI

2007-05-23 Thread akpm
From: Jan Engelhardt <[EMAIL PROTECTED]> Make a "menuconfig" out of the Kconfig objects "menu, ..., endmenu", so that the user can disable all the options in that menu at once instead of having to disable each option separately. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Cc: James Bottomle

[patch 13/25] PCI Error Recovery: Symbios SCSI First Failure

2007-05-23 Thread akpm
From: Linas Vepstas <[EMAIL PROTECTED]> Implement the so-called "first failure data capture" (FFDC) for the symbios PCI error recovery. After a PCI error event is reported, the driver requests that MMIO be enabled. Once enabled, it then reads and dumps assorted status registers, and concludes by

[patch 16/25] drivers/scsi/ips.c: remove kernel 2.4 code

2007-05-23 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/ips.c | 145 +-- drivers/scsi/ips.h | 44 -

[patch 12/25] PCI Error Recovery: Symbios SCSI base support

2007-05-23 Thread akpm
From: Linas Vepstas <[EMAIL PROTECTED]> Various PCI bus errors can be signaled by newer PCI controllers. This patch adds the PCI error recovery callbacks to the Symbios SCSI device driver. The patch has been tested, and appears to work well. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc:

[patch 20/25] fix for bugzilla 8426: massive slowdown on SCSI CD/DVD drive connected to mptspi driver

2007-05-23 Thread akpm
From: Doug Chapman <[EMAIL PROTECTED]> Patch for: http://bugzilla.kernel.org/show_bug.cgi?id=8426 A recent code cleanup that moved code from mptscsih to mptspi inadvertently change the order some code was called. This caused a massive slowdown (of 150x to 300x) on the CD/DVD drive on the high-en

Re: [patch 14/25] SCSI: use irq_handler_t where appropriate

2007-05-23 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/aacraid/aacraid.h |2 +- drivers/scsi/qla2xxx/qla_isr.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-

Re: [patch 14/25] SCSI: use irq_handler_t where appropriate

2007-05-23 Thread Andrew Morton
On Wed, 23 May 2007 18:07:35 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > From: Jeff Garzik <[EMAIL PROTECTED]> > > > > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> > > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> > > --- > > > > drivers/scsi/aacraid/aacraid

Re: [patch 07/25] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver

2007-05-23 Thread James Bottomley
On Wed, 2007-05-23 at 14:41 -0700, [EMAIL PROTECTED] wrote: > From: Martin Bligh <[EMAIL PROTECTED]> > > Fix up compiler warnings in megaraid driver > > [EMAIL PROTECTED]: build fix] > Signed-off-by: Martin J. Bligh <[EMAIL PROTECTED]> > Cc: James Bottomley <[EMAIL PROTECTED]> > Signed-off-by: An

Re: [patch 07/25] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver

2007-05-23 Thread Martin Bligh
James Bottomley wrote: On Wed, 2007-05-23 at 14:41 -0700, [EMAIL PROTECTED] wrote: From: Martin Bligh <[EMAIL PROTECTED]> Fix up compiler warnings in megaraid driver [EMAIL PROTECTED]: build fix] Signed-off-by: Martin J. Bligh <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-

Re: [patch 14/25] SCSI: use irq_handler_t where appropriate

2007-05-23 Thread James Bottomley
On Wed, 2007-05-23 at 18:07 -0400, Jeff Garzik wrote: > [EMAIL PROTECTED] wrote: > > From: Jeff Garzik <[EMAIL PROTECTED]> > > > > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> > > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> > > --- > > > > drivers/scsi/aacraid/aacraid.h |2 +- > > dri

Re: [patch 07/25] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver

2007-05-23 Thread James Bottomley
On Wed, 2007-05-23 at 15:54 -0700, Martin Bligh wrote: > James Bottomley wrote: > > On Wed, 2007-05-23 at 14:41 -0700, [EMAIL PROTECTED] wrote: > >> From: Martin Bligh <[EMAIL PROTECTED]> > >> > >> Fix up compiler warnings in megaraid driver > >> > >> [EMAIL PROTECTED]: build fix] > >> Signed-off-b

Re: [patch 14/25] SCSI: use irq_handler_t where appropriate

2007-05-23 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed, 23 May 2007 18:07:35 -0400 > hrm. This appears to have been sent to linux-scsi at least three times. > > If it doesn't stick, I'll go ahead and send it up myself. The latency on linux-scsi review and integration of patches is not so hot lately, o

Re: [patch 07/25] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver

2007-05-23 Thread Andrew Morton
On Wed, 23 May 2007 17:52:40 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Wed, 2007-05-23 at 14:41 -0700, [EMAIL PROTECTED] wrote: > > From: Martin Bligh <[EMAIL PROTECTED]> > > > > Fix up compiler warnings in megaraid driver > > > > [EMAIL PROTECTED]: build fix] > > Signed-off-by: Mart

[patch 1/1] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver

2007-05-23 Thread akpm
From: Martin Bligh <[EMAIL PROTECTED]> Fix up compiler warnings in megaraid driver Signed-off-by: Martin J. Bligh <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c | 10 +- 1 files changed, 5 insert

Re: [patch 02/25] drivers/scsi/advansys.c: cleanups

2007-05-23 Thread James Bottomley
On Wed, 2007-05-23 at 14:41 -0700, [EMAIL PROTECTED] wrote: > From: Adrian Bunk <[EMAIL PROTECTED]> > > - remove the unneeded advansys.h > - remove the unused advansys_setup() This isn't quite right, though, is it? advansys_setup() should be used. It looks like there was a bogus conversion away

Re: [patch 02/25] drivers/scsi/advansys.c: cleanups

2007-05-23 Thread Andrew Morton
On Wed, 23 May 2007 18:21:31 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Wed, 2007-05-23 at 14:41 -0700, [EMAIL PROTECTED] wrote: > > From: Adrian Bunk <[EMAIL PROTECTED]> > > > > - remove the unneeded advansys.h > > - remove the unused advansys_setup() > > This isn't quite right, thou

[PATCH 0/8] qla4xxx: Resubmission of patches to add IPv6 support etc

2007-05-23 Thread David C Somayajulu
This series of patches is a resubmission of the previous patch under the title "[RFC] [PATCH] qla4xxx: Updated add IPv6 and misc support bugfixes cleanup" as set of smaller patches per Mike Christie's advice/feedback. They contain the following: 1. Support for IPv6 and QLA4032. 2. Bug fixes and

[PATCH 1/8] qla4xxx: Resubmission: ql4_dbg.c remove dead code

2007-05-23 Thread David C Somayajulu
Remove dead code Signed-off-by: David Somayajulu <[EMAIL PROTECTED]> Signed-off-by: Mike Christie <[EMAIL PROTECTED]> drivers/scsi/qla4xxx/ql4_dbg.c | 174 +--- 1 files changed, 3 insertions(+), 171 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_dbg.c b/

[PATCH 2/8] qla4xxx: Resubmission: ql4_def.h log all AENs and cleanup

2007-05-23 Thread David C Somayajulu
Add support for logging all AENs and clean up Signed-off-by: David Somayajulu <[EMAIL PROTECTED]> Signed-off-by: Mike Christie <[EMAIL PROTECTED]> drivers/scsi/qla4xxx/ql4_def.h | 78 1 files changed, 39 insertions(+), 39 deletions(-) diff --git a/driv

[PATCH 3/8] qla4xxx: Resubmission: ql4_fw.h add support for qla4032

2007-05-23 Thread David C Somayajulu
Add support for QLA4032 which supports IPv6 Signed-off-by: David Somayajulu <[EMAIL PROTECTED]> Signed-off-by: Mike Christie <[EMAIL PROTECTED]> drivers/scsi/qla4xxx/ql4_fw.h | 426 + 1 files changed, 177 insertions(+), 249 deletions(-) diff --git a/driv

[PATCH 4/8] qla4xxx: Resubmission: update rev num and misc cleanup

2007-05-23 Thread David C Somayajulu
Clean up and update version number Signed-off-by: David Somayajulu <[EMAIL PROTECTED]> Signed-off-by: Mike Christie <[EMAIL PROTECTED]> drivers/scsi/qla4xxx/ql4_glbl.h|7 ++- drivers/scsi/qla4xxx/ql4_iocb.c|8 ++-- drivers/scsi/qla4xxx/ql4_nvram.c |3 +++ drivers/sc

[PATCH 4/8] qla4xxx: Resubmission: ql4_init.c bugfixes

2007-05-23 Thread David C Somayajulu
In qla4xxx_get_ddb_entry() and qla4xxx_add_device_dynamically() differentiate between a target which has been newly added vs a target which went offline temporarily and is online again. In qla4xxx_build_ddb_list() firmware ddb state needs to be updated by calling qla4xxx_get_ddb_entry(). Fix q

[PATCH 6/8] qla4xxx: Resubmission: ql4_isr.c support for new mbx cmds

2007-05-23 Thread David C Somayajulu
Add support to log all AENs and service mbx cmd completions for QLA4032 Signed-off-by: David Somayajulu <[EMAIL PROTECTED]> Signed-off-by: Mike Christie <[EMAIL PROTECTED]> drivers/scsi/qla4xxx/ql4_isr.c | 53 ++-- 1 files changed, 35 insertions(+), 18 delet

[PATCH 7/8] qla4xxx: Resubmission: ql4_mbx.c remove dead code bugfixes

2007-05-23 Thread David C Somayajulu
All all inbound mbx registers for all mbx commands. Remove dead code. Signed-off-by: David Somayajulu <[EMAIL PROTECTED]> Signed-off-by: Mike Christie <[EMAIL PROTECTED]> drivers/scsi/qla4xxx/ql4_mbx.c | 274 +++- 1 files changed, 103 insertions(+), 171 delet

[PATCH 8/8] qla4xxx: Resubmission: ql4_os.c bugfixes

2007-05-23 Thread David C Somayajulu
Free memory resources after invoking free_irq() in qla4xxx_free_adapter(). QLA4xxx has two pci functions per port (Ethernet and iSCSI). When one of these PCI functions issues a HBA reset, all other functions are notified and need to acknowledge and re-initialize. During module qla4xxx_remove_ada

Re: [PATCH 4/8] qla4xxx: Resubmission: update rev num and misc cleanup

2007-05-23 Thread David C Somayajulu
On Wed, 2007-05-23 at 17:54 -0700, David C Somayajulu wrote: Sorry I hit send before changing the subject header completely. Please disregard this one. I will resend this patch with the proper subject line. -david S. > Clean up and update version number > > Signed-off-by: David Somayajulu <[EMAI

[PATCH 5/8] qla4xxx: Resubmission: update rev num and misc cleanup

2007-05-23 Thread David C Somayajulu
Clean up and update version number Signed-off-by: David Somayajulu <[EMAIL PROTECTED]> Signed-off-by: Mike Christie <[EMAIL PROTECTED]> drivers/scsi/qla4xxx/ql4_glbl.h|7 ++- drivers/scsi/qla4xxx/ql4_iocb.c|8 ++-- drivers/scsi/qla4xxx/ql4_nvram.c |3 +++ drivers/sc

Re: [patch 02/25] drivers/scsi/advansys.c: cleanups

2007-05-23 Thread James Bottomley
On Wed, 2007-05-23 at 16:33 -0700, Andrew Morton wrote: > On Wed, 23 May 2007 18:21:31 -0500 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Wed, 2007-05-23 at 14:41 -0700, [EMAIL PROTECTED] wrote: > > > From: Adrian Bunk <[EMAIL PROTECTED]> > > > > > > - remove the unneeded advansys.h > >

Re: [PATCH] [scsi] Remove __GFP_DMA

2007-05-23 Thread Robert Hancock
Alan Cox wrote: On Wed, 23 May 2007 15:17:08 -0400 "Salyzyn, Mark" <[EMAIL PROTECTED]> wrote: The 31 bit limit for some of these cards is a problem, we currently only do __GFP_DMA for bounce buffer sg elements allocated for user supplied references in ioctls. I figure we should be using pci_al

Re: [patch 14/25] SCSI: use irq_handler_t where appropriate

2007-05-23 Thread Jeff Garzik
James Bottomley wrote: It's not a bug fix or even an enhancement. Historically, it is quite difficult to get maintainers to ack these ... particularly if you don't cc them. If neither you nor the maintainers are reading and responding to patches sent to linux-scsi, I don't think the problem i