Re: [PATCH v2] add bidi support for block pc requests

2007-05-09 Thread Boaz Harrosh
James Bottomley wrote: > I think you'll find that kzalloc comes directly out of a slab for this > size of allocation anyway ... you mean you want to see a dedicated pool > for this specific allocation? Yes, As you said below so we can always send IO for "forward progress of freeing memory". My test

[PATCH 1/2] zfcp: avoid clutter in erp_dbf

2007-05-09 Thread Swen Schillig
>From Martin Peschke <[EMAIL PROTECTED]> avoid clutter in erp_dbf cleanup zfcp_fsf_req_dismiss functions: - avoid clutter in erp_dbf (reqs_active is always 0) - fold called three-line function into calling function - add meaningful comment - coding style Signed-off-by: Martin Peschke <[EMAIL PRO

[PATCH 2/2] zfcp: IO stall after deleting and path checker changes after reenabling zfcp devices

2007-05-09 Thread Swen Schillig
From: Michael Loehr <[EMAIL PROTECTED]> IO stall after deleting and path checker changes after reenabling zfcp device Setting one zfcp device offline using chccwdev in a multipath environment and waiting will lead to IO stall on all paths. After setting the zfcp device back online using chccwdev,

Re: [PATCH v2] add bidi support for block pc requests

2007-05-09 Thread FUJITA Tomonori
From: James Bottomley <[EMAIL PROTECTED]> Subject: Re: [PATCH v2] add bidi support for block pc requests Date: Tue, 08 May 2007 15:01:37 -0500 > Roll all the required sglist definitions (request_bufflen, > request_buffer, use_sg and sglist_len) into the sgtable pools. > > We're getting very close

Re: [PATCH v2] add bidi support for block pc requests

2007-05-09 Thread FUJITA Tomonori
From: Boaz Harrosh <[EMAIL PROTECTED]> Subject: Re: [PATCH v2] add bidi support for block pc requests Date: Wed, 09 May 2007 10:46:34 +0300 > > Roll all the required sglist definitions (request_bufflen, > > request_buffer, use_sg and sglist_len) into the sgtable pools. > > > > We're getting very

Re: [PATCH v2] add bidi support for block pc requests

2007-05-09 Thread Boaz Harrosh
FUJITA Tomonori wrote: > From: Boaz Harrosh <[EMAIL PROTECTED]> > Subject: Re: [PATCH v2] add bidi support for block pc requests > Date: Wed, 09 May 2007 10:46:34 +0300 > >>> Roll all the required sglist definitions (request_bufflen, >>> request_buffer, use_sg and sglist_len) into the sgtable pool

Re: [PATCH v2] add bidi support for block pc requests

2007-05-09 Thread FUJITA Tomonori
From: Boaz Harrosh <[EMAIL PROTECTED]> Subject: Re: [PATCH v2] add bidi support for block pc requests Date: Wed, 09 May 2007 16:58:24 +0300 > FUJITA Tomonori wrote: > > From: Boaz Harrosh <[EMAIL PROTECTED]> > > Subject: Re: [PATCH v2] add bidi support for block pc requests > > Date: Wed, 09 May 2

Re: [PATCH v2] add bidi support for block pc requests

2007-05-09 Thread James Bottomley
On Wed, 2007-05-09 at 16:58 +0300, Boaz Harrosh wrote: > >> 1. An sgtable is a single allocation with an sgtable header type > >>at the begining and a veriable size array of struct scatterlist. > >>something like: > >>struct sgtable { > >>struct sgtable_header { > >>

RE: SG_IO with >4k buffer size to iscsi sg device causes "Bad page" panic

2007-05-09 Thread Qi, Yanling
> -Original Message- > From: Mike Christie [mailto:[EMAIL PROTECTED] > Qi, Yanling wrote: > Yeah, this problem should occur in the upstream open-iscsi iscsi code. > open-iscsi works very similar to linux-scsi where it just sends pages > around with sock->ops-sendpage, and it looks like sg

Re: [PATCH v2] add bidi support for block pc requests

2007-05-09 Thread Boaz Harrosh
James Bottomley wrote: > Actually, the first order of business is to use accessors on the command > pointers in the drivers to free them from the internal layout of the > structure (and where it is allocated). > Thanks! I totally second that. Let me look into my old patches and come up with all th

Re: [GIT PATCH] final SCSI updates for 2.6.21

2007-05-09 Thread Chuck Ebbert
James Bottomley wrote: > This should be the second half of the SCSI tree, mainly assorted driver > updates and fixes. The patch is available from: > Is Doug Chapman's patch for mptspi going in? http://marc.info/?l=linux-scsi&m=117857313402574&q=raw [PATCH] fix for BZ 8426 - massive slowdown on

Re: [GIT PATCH] final SCSI updates for 2.6.21

2007-05-09 Thread James Bottomley
On Wed, 2007-05-09 at 14:14 -0400, Chuck Ebbert wrote: > James Bottomley wrote: > > This should be the second half of the SCSI tree, mainly assorted driver > > updates and fixes. The patch is available from: > > > > Is Doug Chapman's patch for mptspi going in? > > http://marc.info/?l=linux-scsi

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-05-09 Thread Linas Vepstas
Hi Matthew, I had been hoping these patches might make it into 2.6.22, ... this is a nag note; please forward upstream. --linas On Fri, Apr 20, 2007 at 03:47:20PM -0500, Linas Vepstas wrote: > > Implement the so-called "first failure data capture" (FFDC) for the > symbios PCI error recovery. A

[PATCH 1/1] ipr: Proper return codes for eh_dev_reset for SATA devices

2007-05-09 Thread Brian King
Currently ipr always returns success from eh_dev_reset when called for a SATA device. If ata_do_eh is unable to recover for some reason, this can result in commands that are still outstanding when ata_do_eh returns. Change ipr to verify no commands are outstanding before returning success. Signed

Re: [patch 6/7] SCSI: save disk in scsi_device - resend

2007-05-09 Thread Kristen Carlson Accardi
On Mon, 7 May 2007 08:29:28 -0700 Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote: > On Fri, 04 May 2007 15:30:48 -0500 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Fri, 2007-05-04 at 11:17 -0700, Kristen Carlson Accardi wrote: > > > Give anyone who has access to scsi_device access to

Re: [patch 6/7] SCSI: save disk in scsi_device - resend

2007-05-09 Thread James Bottomley
On Wed, 2007-05-09 at 15:50 -0700, Kristen Carlson Accardi wrote: > interpret the lack of response to this question to mean that I can > just > decide for myself - in which case I prefer to send this as a separate > patchset after this one is integrated. Sorry ... was sidetracked getting tree int

Re: SG_IO with >4k buffer size to iscsi sg device causes "Bad page" panic

2007-05-09 Thread Herbert Xu
Qi, Yanling <[EMAIL PROTECTED]> wrote: > @@ -2571,6 +2572,13 @@ sg_page_malloc(int rqSz, int lowDma, int >resp = (char *) __get_free_pages(page_mask, order); > /* try half */ >resSz = a_size; >} > + tmppage = virt_to_page(resp); > + for( m = PAGE_

[patch 0/7] Asynchronous Notification for ATAPI devices (resend)

2007-05-09 Thread Kristen Carlson Accardi
Hi Jeff, Here are the AN patches again, they have not changed with the exception of patch #1, which does set the host flag in board_ahci and board_ahci_pi now (thanks Tejun). This patch series implements Asynchronous Notification (AN) for SATA ATAPI devices as defined in SATA 2.5 and AHCI 1.1 and

[patch 1/7] libata: check for AN support

2007-05-09 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-core.c === --- 2.6-git.orig/drivers/ata/libata-core.c

[patch 2/7] genhd: expose AN to user space

2007-05-09 Thread Kristen Carlson Accardi
Allow user space to determine if a disk supports Asynchronous Notification of media changes. This is done by adding a new sysfs file "capability_flags", which is documented in (insert file name). This sysfs file will export all disk capabilities flags to user space. We also define a new flag to

[patch 3/7] scsi: expose AN to user space

2007-05-09 Thread Kristen Carlson Accardi
Get media change notification capability from disk and pass this information to genhd by setting appropriate flag. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/scsi/sr.c === --- 2.6-git.orig/drive

[patch 5/7] genhd: send async notification on media change

2007-05-09 Thread Kristen Carlson Accardi
Send an uevent to user space to indicate that a media change event has occurred. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/block/genhd.c === --- 2.6-git.orig/block/genhd.c +++ 2.6-git/block/genhd.c @@

[patch 4/7] libata: expose AN to user space

2007-05-09 Thread Kristen Carlson Accardi
If Asynchronous Notification of media change events is supported, pass that information up to the SCSI layer. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-scsi.c === --- 2.6-git.orig/dr

[patch 6/7] SCSI: save disk in scsi_device

2007-05-09 Thread Kristen Carlson Accardi
Give anyone who has access to scsi_device access to the genhd struct as well. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/scsi/sd.c === --- 2.6-git.orig/drivers/scsi/sd.c +++ 2.6-git/drivers/scsi/

[patch 7/7] libata: send event when AN received

2007-05-09 Thread Kristen Carlson Accardi
When we get an SDB FIS with the 'N' bit set, we should send an event to user space to indicate that there has been a media change. This will be done via the block device. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/ahci.c

[PATCH 1/4] stex: fix id mapping issue

2007-05-09 Thread Ed Lin
The correct internal mapping of stex controllers should be: id:0~15, lun:0~7 (st_shasta) id:0, lun:0~127 (st_yosemite) id:0~127, lun:0 (st_vsc and st_vsc1) This patch reports the internal mapping to scsi mid layer, eliminating the translation between scsi mid layer and firmware. To achieve this

[PATCH 2/4] stex: extend hard reset wait time

2007-05-09 Thread Ed Lin
During hard bus reset of st_shasta controllers, 1 ms is not enough for 16-port controllers, although it's good for 8-port controllers. Extend the wait time to 100 ms to allow bus resets finish successfully. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers

[PATCH 3/4] stex: fix reset recovery for console device

2007-05-09 Thread Ed Lin
After reset completed, the scsi error handler sends out TEST_UNIT_READY to the device. For 'normal' devices the command will be handled by firmware. However, because the RAID console only interfaces to scsi mid layer, the firmware will not process the command for it. This will make the console to

[PATCH 4/4] stex: minor cleanup and version update

2007-05-09 Thread Ed Lin
Add debug information into abort and host_reset routine. Change ioremap to ioremap_nocache. Version updated to 3.6..1. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 47c2ef9..9ac83ab 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scs

Re: [patch 1/7] libata: check for AN support

2007-05-09 Thread Andrew Morton
On Wed, 9 May 2007 16:38:09 -0700 Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote: > /** > + * ata_dev_set_AN - Issue SET FEATURES - SATA FEATURES > + * with sector count set to indicate > + * Asynchronous Notification feature I think kenreldoc re

Re: [patch 1/7] libata: check for AN support

2007-05-09 Thread Jeff Garzik
Andrew Morton wrote: + * @dev: Device to which command will be sent + * + * Issue SET FEATURES - SATA FEATURES command to device @dev + * on port @ap. + * + * LOCKING: + * PCI/etc. bus probe sem. + * + * RETURNS: + * 0 on success, AC_ERR_* mask otherwise. + */ ooh, l

Re: [patch 1/7] libata: check for AN support

2007-05-09 Thread Andrew Morton
On Thu, 10 May 2007 01:14:38 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > >> + *@dev: Device to which command will be sent > >> + * > >> + *Issue SET FEATURES - SATA FEATURES command to device @dev > >> + *on port @ap. > >> + * > >> + *LOCKI

Re: [PATCH v2] add bidi support for block pc requests

2007-05-09 Thread FUJITA Tomonori
From: Boaz Harrosh <[EMAIL PROTECTED]> Subject: Re: [PATCH v2] add bidi support for block pc requests Date: Wed, 09 May 2007 19:54:32 +0300 > James Bottomley wrote: > > Actually, the first order of business is to use accessors on the command > > pointers in the drivers to free them from the intern