Re: [PATCH] SCSI: Remove redundant GFP_KERNEL type flag in kmalloc().

2007-05-04 Thread Andrew Morton
Please be careful to add the appropriate cc's. On Mon, 30 Apr 2007 04:37:22 -0400 (EDT) "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > > Remove the apparently redundant GFP_KERNEL type flag in the call to > kmalloc(). > > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> > > --- > > diff

Re: libata /dev/scd0 problem: mount after burn fails without eject

2007-05-04 Thread Tejun Heo
Michal Piotrowski wrote: > On 01/05/07, Mark Lord <[EMAIL PROTECTED]> wrote: >> Forwarding to linux-scsi and linux-ide mailing lists. >> >> Frank van Maarseveen wrote: >> > Tested on 2.6.20.6 and 2.6.21.1 >> > >> > I decided to swich from the old IDE drivers to libata and now there >> > seems to be

Re: [PATCH] SCSI: Remove redundant GFP_KERNEL type flag in kmalloc().

2007-05-04 Thread Robert P. J. Day
On Fri, 4 May 2007, Andrew Morton wrote: > > Please be careful to add the appropriate cc's. > > On Mon, 30 Apr 2007 04:37:22 -0400 (EDT) "Robert P. J. Day" <[EMAIL > PROTECTED]> wrote: > > > > > Remove the apparently redundant GFP_KERNEL type flag in the call to > > kmalloc(). > > > > Signed-off-

Re: libata /dev/scd0 problem: mount after burn fails without eject

2007-05-04 Thread Tejun Heo
Frank van Maarseveen wrote: > On Fri, May 04, 2007 at 10:16:32AM +0200, Tejun Heo wrote: >> Michal Piotrowski wrote: >>> On 01/05/07, Mark Lord <[EMAIL PROTECTED]> wrote: Forwarding to linux-scsi and linux-ide mailing lists. Frank van Maarseveen wrote: > Tested on 2.6.20.6 and 2.

Re: libata /dev/scd0 problem: mount after burn fails without eject

2007-05-04 Thread Frank van Maarseveen
On Fri, May 04, 2007 at 10:41:41AM +0200, Tejun Heo wrote: > Frank van Maarseveen wrote: > > On Fri, May 04, 2007 at 10:16:32AM +0200, Tejun Heo wrote: > >> Michal Piotrowski wrote: > >>> On 01/05/07, Mark Lord <[EMAIL PROTECTED]> wrote: > Forwarding to linux-scsi and linux-ide mailing lists.

Re: libata /dev/scd0 problem: mount after burn fails without eject

2007-05-04 Thread Frank van Maarseveen
On Fri, May 04, 2007 at 10:16:32AM +0200, Tejun Heo wrote: > Michal Piotrowski wrote: > > On 01/05/07, Mark Lord <[EMAIL PROTECTED]> wrote: > >> Forwarding to linux-scsi and linux-ide mailing lists. > >> > >> Frank van Maarseveen wrote: > >> > Tested on 2.6.20.6 and 2.6.21.1 > >> > > >> > I decided

Re: [PATCH] SCSI: Remove redundant GFP_KERNEL type flag in kmalloc().

2007-05-04 Thread Satyam Sharma
On 5/4/07, Andrew Morton <[EMAIL PROTECTED]> wrote: [...] > > - aic_dev = kmalloc(sizeof(struct aic_dev_data), GFP_ATOMIC | GFP_KERNEL); > + aic_dev = kmalloc(sizeof(struct aic_dev_data), GFP_ATOMIC); No, this converts the allocation from a robust one which can sleep into a flakey one which ca

[PATCH] drivers/scsi/aic7xxx_old.c: remove redundant GFP_ATOMIC from kmalloc

2007-05-04 Thread Satyam Sharma
drivers/scsi/aic7xxx_old.c:aic7xxx_slave_alloc() unnecessarily passes GFP_ATOMIC (along with GFP_KERNEL) to kmalloc() from a context that is not atomic. Remove the pointless GFP_ATOMIC. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- diff -ruNp linux-2.6.21.1/drivers/scsi/aic7xxx

Re: [PATCH 4/4] bidi support: bidirectional request

2007-05-04 Thread FUJITA Tomonori
From: Boaz Harrosh <[EMAIL PROTECTED]> Subject: Re: [PATCH 4/4] bidi support: bidirectional request Date: Thu, 03 May 2007 20:42:44 +0300 > FUJITA Tomonori wrote: > > From: Jens Axboe <[EMAIL PROTECTED]> > > Subject: Re: [PATCH 4/4] bidi support: bidirectional request > > Date: Mon, 30 Apr 2007 13

[patch 0/7] Asynchronous Notification for ATAPI devices (v2) - resend

2007-05-04 Thread Kristen Carlson Accardi
This patch series implements Asynchronous Notification (AN) for SATA ATAPI devices as defined in SATA 2.5 and AHCI 1.1 and higher. Drives which support this feature will send a notification when new media is inserted and removed, preventing the need for user space to poll for new media. This supp

[patch 1/7] libata: check for AN support - resend

2007-05-04 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Changes from last version: * use parens around id in ata.h Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-core.c ===

[patch 2/7] genhd: expose AN to user space - resend

2007-05-04 Thread Kristen Carlson Accardi
Allow user space to determine if a disk supports Asynchronous Notification of media changes. This is done by adding a new sysfs file "capability_flags", which is documented in (insert file name). This sysfs file will export all disk capabilities flags to user space. We also define a new flag to

[patch 3/7] scsi: expose AN to user space - resend

2007-05-04 Thread Kristen Carlson Accardi
Get media change notification capability from disk and pass this information to genhd by setting appropriate flag. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/scsi/sr.c === --- 2.6-git.orig/drive

[patch 4/7] libata: expose AN to user space - resend

2007-05-04 Thread Kristen Carlson Accardi
If Asynchronous Notification of media change events is supported, pass that information up to the SCSI layer. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-scsi.c === --- 2.6-git.orig/dr

Re: [patch 5/7] genhd: send async notification on media change

2007-05-04 Thread Kristen Carlson Accardi
Send an uevent to user space to indicate that a media change event has occurred. Changes from last version: * use get/put_device to increment reference count on the device struct Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/block/genhd.c =

[patch 6/7] SCSI: save disk in scsi_device - resend

2007-05-04 Thread Kristen Carlson Accardi
Give anyone who has access to scsi_device access to the genhd struct as well. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/scsi/sd.c === --- 2.6-git.orig/drivers/scsi/sd.c +++ 2.6-git/drivers/scsi/

[patch 7/7] libata: send event when AN received - resend

2007-05-04 Thread Kristen Carlson Accardi
When we get an SDB FIS with the 'N' bit set, we should send an event to user space to indicate that there has been a media change. This will be done via the block device. changed from last version: * Make sure that port_addr is within ATA_MAX_DEVICES Signed-off-by: Kristen Carlson Accardi <[EMA

Re: [patch 0/7] Asynchronous Notification for ATAPI devices (v2) - resend

2007-05-04 Thread James Bottomley
On Fri, 2007-05-04 at 11:12 -0700, Kristen Carlson Accardi wrote: > This patch series implements Asynchronous Notification (AN) for SATA > ATAPI devices as defined in SATA 2.5 and AHCI 1.1 and higher. Drives > which support this feature will send a notification when new media is > inserted and rem

Re: [patch 6/7] SCSI: save disk in scsi_device - resend

2007-05-04 Thread James Bottomley
On Fri, 2007-05-04 at 11:17 -0700, Kristen Carlson Accardi wrote: > Give anyone who has access to scsi_device access to the genhd struct as well. > > Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> > Index: 2.6-git/drivers/scsi/sd.c >

RE: [Bugme-new] [Bug 8426] New: massive slowdown on SCSI CD/DVDdrive connected to mptspi driver

2007-05-04 Thread Moore, Eric
On Thursday, May 03, 2007 9:50 PM, Doug Chapman wrote: > > ACK, tested this on my system where I originally found the problem and > all is well with this. > > Ignore my earlier comment about the original patch adding the new > function mptspi_initTarget. After looking at what is going > on I r

Re: [patch 0/7] Asynchronous Notification for ATAPI devices (v2) - resend

2007-05-04 Thread Kristen Carlson Accardi
On Fri, 04 May 2007 15:30:03 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Fri, 2007-05-04 at 11:12 -0700, Kristen Carlson Accardi wrote: > > This patch series implements Asynchronous Notification (AN) for SATA > > ATAPI devices as defined in SATA 2.5 and AHCI 1.1 and higher. Drives > > w

[PATCH 1/3] remove long dead DMA_INT

2007-05-04 Thread Guennadi Liakhovetski
DMA_INT code is disabled since 1998, remove it to prepare for further cleanup. Signed-off-by: G. Liakhovetski <[EMAIL PROTECTED]> diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c index a583e89..d0e171c 100644 --- a/drivers/scsi/tmscsim.c +++ b/drivers/scsi/tmscsim.c @@ -625,70 +625,6

[PATCH 2/3] tmscsim: remove bogus endianness conversions

2007-05-04 Thread Guennadi Liakhovetski
cpu_to_le32 endianness conversions in tmscsim.c, followed by arithmetic operations don't look correct. Besides, {in,out}[wl] already perform the necessary conversions. Further, bus addresses of request buffers are guaranteed to be (mapped) under 4G by current scsi- and block-layer defaults. This co

[PATCH 3/3] tmscsim: Remove the last bus_to_virt()

2007-05-04 Thread Guennadi Liakhovetski
Dynamically map the buffer for PIO for the residue byte. Signed-off-by: G. Liakhovetski <[EMAIL PROTECTED]> diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c index be869d0..aec63ef 100644 --- a/drivers/scsi/tmscsim.c +++ b/drivers/scsi/tmscsim.c @@ -351,6 +351,27 @@ static u8 dc390_cl

RE: [Bugme-new] [Bug 8426] New: massive slowdown on SCSI CD/DVDdrive connected to mptspi driver

2007-05-04 Thread Doug Chapman
On Fri, 2007-05-04 at 14:34 -0600, Moore, Eric wrote: > On Thursday, May 03, 2007 9:50 PM, Doug Chapman wrote: > > > > ACK, tested this on my system where I originally found the problem and > > all is well with this. > > > > Ignore my earlier comment about the original patch adding the new > > f

[PATCH 1/1] ipr: Fix ipr ata_do_eh API compile warning

2007-05-04 Thread Brian King
This patch fixes the following compile warning: drivers/scsi/ipr.c: In function '__ipr_eh_dev_reset': drivers/scsi/ipr.c:3955: warning: passing argument 4 of 'ata_do_eh' from incompatible pointer type This patch reverts the following commit, which looks to have been pushed before the ata_do_eh

RE: [Bugme-new] [Bug 8426] New: massive slowdown on SCSI CD/DVDdrive connected to mptspi driver

2007-05-04 Thread James Bottomley
On Fri, 2007-05-04 at 17:56 -0400, Doug Chapman wrote: > I am applying/removing _only_ your patch and the problem goes away with > just removing it. What id and channel is this DVD drive on? There is a potential bug in the move: -mptscsih_writeIOCPage4(MPT_SCSI_HOST *hd, int channel, int id) +mp