[patch 01/30] aacraid: 2.6.21-rc6-mm1 aacraid not finding device

2007-04-26 Thread akpm
From: "Salyzyn, Mark" <[EMAIL PROTECTED]> Thanks for the help from Steve Fox and Duane Cox investigating this issue, I'd like to report that we found the problem. The issue is with the patch Steve Fox isolated below, by not accommodating older adapters properly and issuing a command they do not su

[patch 06/30] pci_module_init() convertion in tmscsim.c

2007-04-26 Thread akpm
From: Henrik Kretzschmar <[EMAIL PROTECTED]> pci_module_init() convertion in tmscsim.c Signed-off-by: Henrik Kretzschmar <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/tmscsim.c |6 -- 1 file changed, 4 insert

[patch 02/30] drivers/scsi/: small cleanups

2007-04-26 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> This patch contains the following cleanups: - make needlessly global functions static - every file should #include the headers containing the prototypes for it's global functions Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PRO

[patch 03/30] drivers/scsi/advansys.c: cleanups

2007-04-26 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - remove the unneeded advansys.h - remove the unused advansys_setup() - make needlessly global functions static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/advansys.c | 101 +++---

[patch 07/30] drivers/scsi/NCR5380.c: Replacing yield() with a better alternative

2007-04-26 Thread akpm
From: Amol Lad <[EMAIL PROTECTED]> Replaced yield() with cond_resched() Signed-off-by: Amol Lad <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/NCR5380.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[patch 05/30] scsi: remove unnecessary check in drivers/scsi/sg.c

2007-04-26 Thread akpm
From: Eric Sesterhenn <[EMAIL PROTECTED]> coverity spotted this (cid #758). All callers dereference sfp, so we dont need this check. In addition to this, we dereference it earlier in the function. Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]> Cc: Douglas Gilbert <[EMAIL PROTECTED]> Cc: Jam

[patch 08/30] drivers/scsi/megaraid.c: Replacing yield() with a better alternative

2007-04-26 Thread akpm
From: Amol Lad <[EMAIL PROTECTED]> For this driver cond_resched() seems to be a better alternative Signed-off-by: Amol Lad <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN drive

[patch 04/30] megaraid: fix warnings when CONFIG_PROC_FS=n

2007-04-26 Thread akpm
From: walter harms <[EMAIL PROTECTED]> Signed-off-by: walter harms <[EMAIL PROTECTED]> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Cc: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c | 17 +++-- drivers/scsi/megara

[patch 27/30] sas_scsi_host: partially convert to use the kthread API

2007-04-26 Thread akpm
From: Eric W. Biederman <[EMAIL PROTECTED]> This patch modifies the sas scsi host thread startup to use kthread_run not kernel_thread and deamonize. kthread_run is slightly simpler and more maintainable. akpm: the driver should also be converted to use kthread_should_stop() and kthread_stop().

[patch 25/30] scsi: fix CONFIG_SCSI_WAIT_SCAN=m

2007-04-26 Thread akpm
From: Hugh Dickins <[EMAIL PROTECTED]> CONFIG_MODULES=y CONFIG_SCSI=y CONFIG_SCSI_SCAN_ASYNC=y CONFIG_SCSI_WAIT_SCAN=m 2.6.21-rc5-mm2 VFS panics unable to find my root on /dev/sda2, but boots okay if I change drivers/scsi/Kconfig to "default y" instead of "default m" for SCSI_WAIT_SCAN. Make sur

[patch 22/30] fdomain.c: get rid of unused stuff

2007-04-26 Thread akpm
From: Parag Warudkar <[EMAIL PROTECTED]> fdomain.c uses the below stuff only if PCMCIA is not defined. This causes unused variables to be defined when PCMCIA is not defined. Wrap variables and functions around #ifndef PCMCIA appropriately to avoid this. 4 less compiler warnings. Signed-off-by:

[patch 26/30] Fix BusLogic to stop using check_region

2007-04-26 Thread akpm
From: Zachary Amsden <[EMAIL PROTECTED]> I got so sick of seing the check_region warnings from BusLogic.c I actually fixed it properly. Never use check region, reserve it before the probe with request region instead and check the error result; free region if setup fails. Should be functionally i

[patch 17/30] cleanup variable usage in mesh interrupt handler

2007-04-26 Thread akpm
From: Olaf Hering <[EMAIL PROTECTED]> _ convert void* to struct mesh_state* - remove unused irq argument from mesh_interrupt() Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/mesh.c | 14

[patch 24/30] scsi: megaraid_sas - intercepts cmd timeout and throttle io

2007-04-26 Thread akpm
From: Sumant Patro <[EMAIL PROTECTED]> eh_timed_out call back (megasas_reset_timer) is used to throttle io to the adapter when it is called the first time for a scmd. The MEGASAS_FW_BUSY flag is set and can_queue reduced to 16. The can_queue is restored from completion routine in following two c

[patch 18/30] Fix |/|| confusion in fusion driver

2007-04-26 Thread akpm
From: Dirk Mueller <[EMAIL PROTECTED]> This patch corrects a |/|| confusion in mptscsih_copy_sense_data. Using || means that the data that ends up being written is (almost always) 1, instead of being bit-wise or'ed. Cc: Eric Moore <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signe

[patch 14/30] make seagate_st0x_detect() static

2007-04-26 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> seagate_st0x_detect() can become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/seagate.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/scsi/seagate.c~ma

[patch 09/30] drivers/scsi/mca_53c9x.c : save_flags()/cli() removal

2007-04-26 Thread akpm
From: Amol Lad <[EMAIL PROTECTED]> Replaced save_flags()/cli() with spin_lock alternatives [EMAIL PROTECTED]: no longer BROKEN_ON_SMP] Signed-off-by: Amol Lad <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTE

[patch 28/30] qla1280: use DMA_64BIT_MASK instead of ~0ULL

2007-04-26 Thread akpm
From: Matthias Kaehlcke <[EMAIL PROTECTED]> QLA1280: call pci_set_dma_mask with DMA_64BIT_MASK instead of ~0ULL Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/qla1280.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

[patch 15/30] SCSI: Fix obvious typo "spin_lock_irqrestore()" in gdth.c

2007-04-26 Thread akpm
From: "Robert P. J. Day" <[EMAIL PROTECTED]> Fix misspelled "spin_lock_irqrestore" to read "spin_unlock_irqrestore" instead. Presumably, GDTH_RTC doesn't get used a lot. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off

[patch 11/30] drivers/scsi/wd33c93.c: cleanups

2007-04-26 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - #include for getting the prototypes of {dis,en}able_irq() - make the needlessly global wd33c93_setup() static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/wd33c93.c |4 +++- 1 file

[patch 21/30] Use unchecked_isa_dma in sd_revalidate_disk()

2007-04-26 Thread akpm
From: Bernhard Walle <[EMAIL PROTECTED]> In sd_revalidate_disk(), the SCSI Disk driver needs a few bytes DMA memory, allocated by kmalloc() and __GFP_DMA. This patch uses __GFP_DMA only if the corresponding host structure has unchecked_isa_dma set. Signed-off-by: Bernhard Walle <[EMAIL PROTECTED

[patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-04-26 Thread akpm
From: Richard Knutsson <[EMAIL PROTECTED]> Convert: FALSE -> false TRUE -> true Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/aic7xxx_old.c | 242 ++ drivers/scsi/aic7xxx_old/aic7xxx_proc.

[patch 19/30] mpt-fusion: reprogram spi state after host reset

2007-04-26 Thread akpm
From: Eric Moore <[EMAIL PROTECTED]> After host reset, the device are programmed to default asyn narrow nego. We need to reprogram the parameter back to previous values. If the host reset is called as a result of spi_dv_device() commands timing out, its possible to get into an infinite loop of d

[patch 13/30] drivers/scsi/qla4xxx/: possible cleanups

2007-04-26 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - make needlessly global code static - #if 0 unused functions Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Ravi Anand <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/qla4xxx/ql4_dbg.c |4 drivers/s

[patch 20/30] SCSI newstyle hotplug/coldplug support

2007-04-26 Thread akpm
From: David Brownell <[EMAIL PROTECTED]> This teaches scsi devices how to support "new style" hotplug/coldplug: using a modalias sysfs attribute for coldplug, and MODALIAS environment variable for hotplug. It also updates the CH, SD, SR, and ST drivers with the aliases needed to drive them by tha

[patch 30/30] PCI Error Recovery: Symbios SCSI First Failure

2007-04-26 Thread akpm
From: Linas Vepstas <[EMAIL PROTECTED]> Implement the so-called "first failure data capture" (FFDC) for the symbios PCI error recovery. After a PCI error event is reported, the driver requests that MMIO be enabled. Once enabled, it then reads and dumps assorted status registers, and concludes by

[patch 10/30] sym53c8xx_2 claims cpqarray device

2007-04-26 Thread akpm
From: Chip Coldwell <[EMAIL PROTECTED]> Apropos this thread http://marc.theaimsgroup.com/?l=linux-scsi&m=115591706804045&w=2 which led to this patch http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-rc-fixes-2.6.git;a=commit;h=b2b3c121076961333977f485f0d54c22121df920 do we not also need

Re: [patch 01/30] aacraid: 2.6.21-rc6-mm1 aacraid not finding device

2007-04-26 Thread Andrew Morton
James, I've been maintaining some of these patches for one and a half years, which is probably enough testing. Could you please review all the patches and either merge them, or nack them with reasons or describe what modifications are needed. Emphasis on "all". Please no longer cherrypick a cou

[patch 12/30] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver

2007-04-26 Thread akpm
From: Martin Bligh <[EMAIL PROTECTED]> Fix up compiler warnings in megaraid driver [EMAIL PROTECTED]: build fix] Signed-off-by: Martin J. Bligh <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c | 22 +++

[patch 29/30] PCI Error Recovery: Symbios SCSI base support

2007-04-26 Thread akpm
From: Linas Vepstas <[EMAIL PROTECTED]> Various PCI bus errors can be signaled by newer PCI controllers. This patch adds the PCI error recovery callbacks to the Symbios SCSI device driver. The patch has been tested, and appears to work well. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc:

Re: Kernel crash with AIC94xx (one step forward, hope it's lucky)

2007-04-26 Thread Luben Tuikov
--- James Bottomley <[EMAIL PROTECTED]> wrote: > Please don't cut linux-scsi from the cc list > > On Tue, 2007-04-24 at 22:14 +0300, Constantin Teodorescu wrote: > > James Bottomley wrote: > > > This configuration doesn't work on the vanilla linux kernel ... you need > > > the scsi-aic94xxx-sas-2

Re: Kernel crash with AIC94xx (one step forward, hope it's lucky)

2007-04-26 Thread Constantin Teodorescu
Luben Tuikov wrote: Having said that, I still support the original version of the aic94xx and the SAS stack, which now includes SAT-1 conformant SATL. It has allowed some people to upgrade their kernels to the latest kernel version (as in from git repo), and reported that it is more stable (i.e.

[Fwd: Re: [PATCH] sas_scsi_host: Convert to use the kthread API]

2007-04-26 Thread James Bottomley
Forwarded Message From: Christoph Hellwig <[EMAIL PROTECTED]> To: Andrew Morton <[EMAIL PROTECTED]> Cc: Eric W. Biederman <[EMAIL PROTECTED]>, [EMAIL PROTECTED], Oleg Nesterov <[EMAIL PROTECTED]>, Christoph Hellwig <[EMAIL PROTECTED]>, [EMAIL PROTECTED], Darrick J. Wong <[EMAIL PR

clarifications needed on scsi_scan_target() and some more...

2007-04-26 Thread Hari Hara Kumar M
Hello I'm fairly new to the linux scsi landscape and had a couple of questions on the subsystem api exported to LLDs: 1. How can a host rescan be done after initially calling scsi_scan_host () ? 2. If scsi_scan_target() is used, can the a ptr to shost_gendev be used without having to explicitly

Re: [PATCH] scsi: megaraid_sas - intercepts cmd timeout and throttle io

2007-04-26 Thread James Bottomley
On Wed, 2007-03-28 at 10:43 -0700, Sumant Patro wrote: > eh_timed_out call back (megasas_reset_timer) is used to throttle io to the > adapter > when it is called the first time for a scmd. > The MEGASAS_FW_BUSY flag is set and can_queue reduced to 16. The can_queue is > restored > from completi

RE: [PATCH] scsi: megaraid_sas - intercepts cmd timeout andthrottle io

2007-04-26 Thread Patro, Sumant
Hello James, The rsvd[3] is reserved for future use. If you have objection to the definition I will take it out in a future patch submission. Regards, Sumant -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Thursday, April 26, 2007 10:39 AM To: Patro, S

filesystem corruption with md raid6

2007-04-26 Thread Clem Pryke
I have a system with 12 SATA disks attached via SAS. When copying into the array during re-sync I get filesystem errors and corruption for raid6 but not for raid5. This problem is repeatable. I actually have 2 separate 12 disk arrays and get the same behavior on both. Does this sound familiar t

RE: [PATCH] scsi: megaraid_sas - intercepts cmd timeout andthrottle io

2007-04-26 Thread James Bottomley
On Thu, 2007-04-26 at 11:52 -0600, Patro, Sumant wrote: > The rsvd[3] is reserved for future use. If you have objection to > the definition I will take it out in a future patch submission. But this is a structure that's internal to the driver isn't it? It's not shared with the card, so th

Re: Kernel crash with AIC94xx (one step forward, hope it's lucky)

2007-04-26 Thread Darrick J. Wong
Constantin Teodorescu wrote: > So ... should I ask for other controller quotation ? > Could you recommend me a good SAS controller, with 8 internal ports, > supporting Linux , with 99.% reliability ? :-) > > I have the following options : IntelĀ® RAID Controller SRCSAS18E > (Parowan) and LS

Re: filesystem corruption with md raid6

2007-04-26 Thread James Bottomley
On Thu, 2007-04-26 at 13:27 -0500, Clem Pryke wrote: > I have a system with 12 SATA disks attached via SAS. When copying into the > array during re-sync I get filesystem errors and corruption for raid6 but not > for raid5. This problem is repeatable. I actually have 2 separate 12 disk > arrays a

[PATCH 1/8] ipr: Prevent overlapped adapter resets

2007-04-26 Thread Brian King
This patch fixes some scenarios where an ipr adapter could get reset overlapped, which could cause very long timeouts to occur, or PCI bus errors. Signed-off-by: Brian King <[EMAIL PROTECTED]> --- drivers/scsi/ipr.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-

[PATCH 2/8] ipr: Allow driver_data to be passed for dynamic ids

2007-04-26 Thread Brian King
Since driver_data for pci ids in the ipr driver is now just flags, we can allow these to be passed in from userspace for dynamic ids. Signed-off-by: Brian King <[EMAIL PROTECTED]> --- drivers/scsi/ipr.c |1 + 1 file changed, 1 insertion(+) diff -puN drivers/scsi/ipr.c~ipr_dynids_driver_dat

[PATCH 3/8] ipr: Handle UA on disk array following an adapter reset

2007-04-26 Thread Brian King
On certain ipr RAID adapters, which are capable of multi-initiator configurations, the disk array, or VSET, resources will be in a POR Unit Attention state following an adapter reset. In order for the midlayer to handle the UA, I must report a bus reset to the logical disk array bus at the end of

[PATCH 4/8] ipr: Handle check condition status from disk array device

2007-04-26 Thread Brian King
On newer levels of microcode for ipr RAID adapters supporting multi-initiator configurations, the disk array, or VSET, resources are capable of generating a check condition. This patch prevents ipr from generating sense data in this scenario and retrieving it from the logical device instead. Sign

[PATCH 5/8] ipr: Handle IOA reset request

2007-04-26 Thread Brian King
In ipr dual adapter configurations, the ipr adapter firmware may require an adapter reset for various reasons. The reset is requested by the adapter firmware logging an error with an IOASC of 0x02048000. Add support to log this error, and reset the adapter. Signed-off-by: Brian King <[EMAIL PROTE

[PATCH 6/8] ipr: Increase adapter operational timeout

2007-04-26 Thread Brian King
Increases the adapter operational timeout for some adapters that support dual controller configurations, since they may take longer to come ready. Signed-off-by: Brian King <[EMAIL PROTECTED]> --- drivers/scsi/ipr.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff -puN dr

[PATCH 7/8] ipr: Improved dual adapter errors

2007-04-26 Thread Brian King
Formats ipr dual adapter errors so that they are more compact. Signed-off-by: Brian King <[EMAIL PROTECTED]> --- drivers/scsi/ipr.c | 78 - 1 file changed, 72 insertions(+), 6 deletions(-) diff -puN drivers/scsi/ipr.c~ipr_improved_dual_adap

[PATCH 8/8] ipr: Enable multi-initator RAID support

2007-04-26 Thread Brian King
Enables multi-initiator support on ipr RAID adapters that support it. Signed-off-by: Brian King <[EMAIL PROTECTED]> --- drivers/scsi/ipr.c | 140 +++-- drivers/scsi/ipr.h | 26 + 2 files changed, 159 insertions(+), 7 deletions(-) diff

[PATCH] aacraid: Initialize rx/rkt function pointers before calling them

2007-04-26 Thread Darrick J. Wong
Commit 8418852d11f0bbaeebeedd4243560d8fdc85410d to scsi-misc resulted in the substitution of calls to rx_sync_cmd with a function pointer abstraction. aac_rx_restart_adapter requires a pointer to a sync_cmd function, which is not set up before its first invocation. That causes the driver to crash

[2.6 patch] drivers/scsi/pcmcia/nsp_cs.c: remove kernel 2.4 code

2007-04-26 Thread Adrian Bunk
This patch removes kernel 2.4 code and some ancient CVS tags. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 26 Mar 2007 drivers/scsi/pcmcia/nsp_cs.c | 159 +-- drivers/scsi/pcmcia/nsp_cs.h |8 - 2 files changed, 5 inserti

[RFC: 2.6 patch] drivers/scsi/ips.c: remove kernel 2.4 code

2007-04-26 Thread Adrian Bunk
This patch removes some kernel 2.4 code. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 26 Mar 2007 drivers/scsi/ips.c | 145 + drivers/scsi/ips.h | 44 - 2 files changed, 20 insertions(+), 169 deleti

[2.6 patch] drivers/scsi/nsp32.c: remove kernel 2.4 code

2007-04-26 Thread Adrian Bunk
This patch removes kernel 2.4 code. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 26 Mar 2007 drivers/scsi/nsp32.c | 109 +-- 1 file changed, 13 insertions(+), 96 deletions(-) --- linux-2.6.21-rc4-mm1/drivers/scsi/ns

Re: [2.6 patch] drivers/scsi/nsp32.c: remove kernel 2.4 code

2007-04-26 Thread Robert P. J. Day
On Fri, 27 Apr 2007, Adrian Bunk wrote: > This patch removes kernel 2.4 code. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > > This patch has been sent on: > - 26 Mar 2007 > > drivers/scsi/nsp32.c | 109 +-- > 1 file changed, 13 insertions(+)

Re: [2.6 patch] drivers/scsi/nsp32.c: remove kernel 2.4 code

2007-04-26 Thread Adrian Bunk
On Thu, Apr 26, 2007 at 07:59:57PM -0400, Robert P. J. Day wrote: > On Fri, 27 Apr 2007, Adrian Bunk wrote: > > > This patch removes kernel 2.4 code. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > > --- > > > > This patch has been sent on: > > - 26 Mar 2007 > > > > drivers/scsi/nsp3

Re: [2.6 patch] drivers/scsi/nsp32.c: remove kernel 2.4 code

2007-04-26 Thread James Bottomley
On Fri, 2007-04-27 at 02:13 +0200, Adrian Bunk wrote: > On Thu, Apr 26, 2007 at 07:59:57PM -0400, Robert P. J. Day wrote: > > On Fri, 27 Apr 2007, Adrian Bunk wrote: > > > > > This patch removes kernel 2.4 code. > > > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > > > > --- > > > > > >

Re: [2.6 patch] drivers/scsi/nsp32.c: remove kernel 2.4 code

2007-04-26 Thread GOTO Masanori
At Thu, 26 Apr 2007 20:30:54 -0400, James Bottomley wrote: > On Fri, 2007-04-27 at 02:13 +0200, Adrian Bunk wrote: > > On Thu, Apr 26, 2007 at 07:59:57PM -0400, Robert P. J. Day wrote: > > > On Fri, 27 Apr 2007, Adrian Bunk wrote: > > > > > > > This patch removes kernel 2.4 code. > > > > > > > > S