Hello,
Kristen Carlson Accardi wrote:
> static unsigned int ata_print_id = 1;
> @@ -1744,6 +1745,23 @@ int ata_dev_configure(struct ata_device
> }
> dev->cdb_len = (unsigned int) rc;
>
> + /*
> + * check to see if this ATAPI device supports
> + /*
> + * check to see if this ATAPI device supports
> + * Asynchronous Notification
> + */
> + if ((ap->flags & ATA_FLAG_AN) && ata_id_has_AN(id))
> + {
Bracketing police ^^^
> + /* issue SET featur
Kristen Carlson Accardi wrote:
> +static struct disk_attribute disk_attr_capability = {
> + .attr = {.name = "capability_flags", .mode = S_IRUGO },
> + .show = disk_capability_read
> +};
How about just "capability"? I think that would be more consistent with
other attributes.
--
tejun
> + /* check the 'N' bit in word 0 of the FIS */
> + if (f[0] & (1 << 15)) {
> + int port_addr = ((f[0] & 0x0f00) >> 8);
> + struct ata_device *adev = &ap->device[port_addr];
You can't be sure that the port_addr returned will be
Kristen Carlson Accardi wrote:
> Send an uevent to user space to indicate that a media change event has
> occurred.
>
> Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
>
> Index: 2.6-git/block/genhd.c
> ===
> --- 2.6-git.
On Mon, Apr 23, 2007 at 01:20:32PM -0400, Salyzyn, Mark wrote:
> That is a failure to route the interrupts and is possibly an issue with
> the kernel and the hardware, and not the driver directly (since there is
> an expectation that request_irq will connect the interrupt to the
> interrupt service
Hello, I hope I can get a little help from you regarding this kind of
crash !
Hardware:
- server, TYAN Tempest i5000VS S5372 BIOS v1.0.4
- 8 SATA drives Seagate 136 Gb attached on a AIC-9410 controller
- one IDE (boot disk and system)
- 8 Gb RAM
Software:
- OpenSUSE 10.2 x86_64 (tried also with
On Tue, Apr 24, 2007 at 02:14:44PM +0530, Vivek Goyal wrote:
>
> In second attempt, it mounted the file system but it found some issue
> with "resize" inode and asked me to run fsck manually. Which in turn
> deleted whole lot of inodes.
>
> In third attemt it panics later when it finds ext3 to b
Sorry for replying to Alan's reply, I missed the original mail.
> > +#define ata_id_has_AN(id) \
> > + ((id[76] && (~id[76])) & ((id)[78] & (1 << 5)))
(a && ~a) & (b & 32)
I don't think that does what you think it does, because at that point
it's a funny way to write 0 ((0 or 1) binary-and (0
Overall the driver looks really nice, thanks a lot!
some comments:
> +#define esp_log_intr(f, a...) \
> +do { if (esp_debug & ESP_DEBUG_INTR) \
> + printk(f, ## a); \
> +} while (0)
would be nice to have dev_printk here, but sbus still seems to
lack driver model integration.
> +stat
Oh, btw - there is a problem with the generic code beeing esp.ko -
we already have drivers/char/esp.c which buids into esp.ko for
ISA platforms, which have a bit of overlap with ESP-using platforms.
Maybe the driver should become esp_scsi.c/.ko or ncr_esp or
ncr53x9x?
-
To unsubscribe from this lis
Copying linux-scsi...
-Brian
Constantin Teodorescu wrote:
> Hello, I hope I can get a little help from you regarding this kind of
> crash !
>
> Hardware:
> - server, TYAN Tempest i5000VS S5372 BIOS v1.0.4
> - 8 SATA drives Seagate 136 Gb attached on a AIC-9410 controller
> - one IDE (boot di
The system BIOS sets up the card's PCI configuration and there is code
in the kernel that is capable of picking up some of the BIOS'
information from the BIOS Data Space (not sure if it is actively
collected in your configuration, you need a kernel flag to pick this
up). On kexec this BIOS Data Spa
On Tue, Apr 24, 2007 at 01:22:35PM +0100, Christoph Hellwig wrote:
> > +static void esp_build_sync_msg(struct esp *esp, u8 period, u8 offset)
> > {
> > + esp->msg_out[0] = EXTENDED_MESSAGE;
> > + esp->msg_out[1] = 3;
> > + esp->msg_out[2] = EXTENDED_SDTR;
> > + esp->msg_out[3] = period;
>
On Tue, 2007-04-24 at 13:22 +0100, Christoph Hellwig wrote:
> > +static void esp_build_sync_msg(struct esp *esp, u8 period, u8
> offset)
> > {
> > + esp->msg_out[0] = EXTENDED_MESSAGE;
> > + esp->msg_out[1] = 3;
> > + esp->msg_out[2] = EXTENDED_SDTR;
> > + esp->msg_out[3] = period;
On Tue, 24 Apr 2007, renuka apte wrote:
> I am using a QLA2460 card. I was experiencing a problem with port
> entries not appearing under /sys/class/fc_hosts/. Through the dmesgs
> I realised it was happening as the firmware image could not be
> found, and I could get around the problem by disabli
On Tue, 24 Apr 2007 12:23:04 +0200
Olivier Galibert <[EMAIL PROTECTED]> wrote:
> Sorry for replying to Alan's reply, I missed the original mail.
>
> > > +#define ata_id_has_AN(id)\
> > > + ((id[76] && (~id[76])) & ((id)[78] & (1 << 5)))
>
> (a && ~a) & (b & 32)
>
> I don't think that do
On Tue, 24 Apr 2007 17:03:29 +0900
Tejun Heo <[EMAIL PROTECTED]> wrote:
> Hello,
>
> Kristen Carlson Accardi wrote:
> > static unsigned int ata_print_id = 1;
> > @@ -1744,6 +1745,23 @@ int ata_dev_configure(struct ata_device
> > }
> > dev->cdb_len = (unsigned int) rc;
>
Use the status codes from the spec, not the shifted-by-one codes
that are marked deprecated in scsi.h This makes bsg v4 status
report the same value as sg v3 status too.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
Acked-by: Douglas Gilbert <[EMAIL PROTECTED]>
---
block/bsg.c |2 +-
1 fil
Changes required to make bsg patches work on top of bidi patches. Adds
capability to bsg to handle bidirectional commands and extended CDBs.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
block/bsg.c| 106 ++--
block/ll_rw_blk.c
Fixes to common functions added with bsg so that they compile in
a kernel that has the bidi patches.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
block/bsg.c|6 +++---
block/scsi_ioctl.c |6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/block/bsg.c b
[EMAIL PROTECTED] wrote on Tue, 24 Apr 2007 13:27 -0400:
> Changes required to make bsg patches work on top of bidi patches. Adds
> capability to bsg to handle bidirectional commands and extended CDBs.
Oops. This is 2/2. Apply the "compile with bidi" one first.
-- Pete
-
To uns
On Tue, Apr 24, 2007 at 08:49:04AM -0700, Kristen Carlson Accardi wrote:
> On Tue, 24 Apr 2007 12:23:04 +0200
> Olivier Galibert <[EMAIL PROTECTED]> wrote:
>
> > Sorry for replying to Alan's reply, I missed the original mail.
> >
> > > > +#define ata_id_has_AN(id) \
> > > > + ((id[76]
On Tue, 24 Apr 2007 20:05:52 +0200
Olivier Galibert <[EMAIL PROTECTED]> wrote:
> On Tue, Apr 24, 2007 at 08:49:04AM -0700, Kristen Carlson Accardi wrote:
> > On Tue, 24 Apr 2007 12:23:04 +0200
> > Olivier Galibert <[EMAIL PROTECTED]> wrote:
> >
> > > Sorry for replying to Alan's reply, I missed t
On Tue, 2007-04-24 at 11:52 +0300, Constantin Teodorescu wrote:
> Hello, I hope I can get a little help from you regarding this kind of
> crash !
>
> Hardware:
> - server, TYAN Tempest i5000VS S5372 BIOS v1.0.4
> - 8 SATA drives Seagate 136 Gb attached on a AIC-9410 controller
> - one IDE (boot d
On Thu, Apr 19, 2007 at 12:10:24PM -0500, David Milburn wrote:
> Update the driver version reported by MEGAIOC_QDRVRVER to
> match LSI_COMMON_MOD_VERSION.
Why does this matter?
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
Mo
Please don't cut linux-scsi from the cc list
On Tue, 2007-04-24 at 22:14 +0300, Constantin Teodorescu wrote:
> James Bottomley wrote:
> > This configuration doesn't work on the vanilla linux kernel ... you need
> > the scsi-aic94xxx-sas-2.6 tree as well for this; is that what you're
> > running wi
From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Tue, 24 Apr 2007 13:22:35 +0100
> Overall the driver looks really nice, thanks a lot!
Thanks.
> would be nice to have dev_printk here, but sbus still seems to
> lack driver model integration.
There is only partial integration at the moment, but
Christoph Hellwig wrote:
On Thu, Apr 19, 2007 at 12:10:24PM -0500, David Milburn wrote:
Update the driver version reported by MEGAIOC_QDRVRVER to
match LSI_COMMON_MOD_VERSION.
Why does this matter?
It is needed so that the correct driver version is reported
by user-space tools that use th
Check to see if an ATAPI device supports Asynchronous Notification.
If so, enable it.
changes from last version:
* fix typo in ata_id_has_AN and make word 76 test more clear
* If we fail to set the AN feature, just print a warning and continue
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROT
From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Tue, 24 Apr 2007 13:45:27 +0100
> Oh, btw - there is a problem with the generic code beeing esp.ko -
> we already have drivers/char/esp.c which buids into esp.ko for
> ISA platforms, which have a bit of overlap with ESP-using platforms.
> Maybe the
Allow user space to determine if a disk supports Asynchronous Notification
of media changes. This is done by adding a new sysfs file "capability_flags",
which is documented in (insert file name). This sysfs file will export all
disk capabilities flags to user space. We also define a new flag to
Send an uevent to user space to indicate that a media change event has occurred.
Changes from last version:
* use get/put_device to increment reference count on the device struct
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
Index: 2.6-git/block/genhd.c
=
When we get an SDB FIS with the 'N' bit set, we should send
an event to user space to indicate that there has been a
media change. This will be done via the block device.
changed from last version:
* Make sure that port_addr is within ATA_MAX_DEVICES
Signed-off-by: Kristen Carlson Accardi <[EMA
I was enjoying yet another session of beating my head against the wall
trying to do useful things with old hardware :-), and managed to cause a
kernel panic by simply trying to mount a cdrom in the context of a DSL-N
installation.
The SCSI host adapter is an Adaptec AHA-1542B, and when I try to mo
On Tue, Apr 24, 2007 at 01:53:27PM -0700, Kristen Carlson Accardi wrote:
> Check to see if an ATAPI device supports Asynchronous Notification.
> If so, enable it.
>
> changes from last version:
> * fix typo in ata_id_has_AN and make word 76 test more clear
> * If we fail to set the AN feature, ju
36 matches
Mail list logo
