Thanks Arjan for the comments, much appreciated. I have removed the
superfluous braces and limited the usage of the likely and unlikely to
runtime code. Sorry for the delay, took a four day vacation ...
Add some likely() and unlikely() compiler hints in some of the aacraid
hardware interface layer
On 3/25/2007 7:59 PM, Robert P. J. Day wrote:
> Remove the Kconfig requirement that the PCMCIA SCSI drivers be built
> only as modules, and allow them to be built into the kernel.
>
> Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
>
> ---
>
> i imagine there's a historical reason for these
Robert P. J. Day wrote at LKML:
> drivers/scsi/pcmcia/Kconfig:
> ...
> config PCMCIA_AHA152X
> tristate "Adaptec AHA152X PCMCIA support"
> depends on m && !64BIT
> select SCSI_SPI_ATTRS
> help
> Say Y here if you intend to attach this type of PCMCIA SCSI ho
Hello!
I had a question about disabling the block layer for SCSI devices. We
have an embedded device, and it runs 2.4.30. We need to be able to
support a lot of SCSI devices (in the thousands) for our device, and we
talk to the devices via SG. We are facing a memory allocation problem
after discov
On Mon, 26 Mar 2007, Christoph Hellwig wrote:
> > > it would seem to make no sense that the "depends on" clause
> > > for this option includes "m", forcing this (and all other four
> > > entries in that Kconfig file, by the way) to be built as
> > > modules, while the help text for all five entr
On 26 Mar, Robert P. J. Day wrote:
> On Mon, 26 Mar 2007, Christoph Hellwig wrote:
>> In the old days pcmcia drivers had to be modular because pcmcia
>> required a lot of userspace setup. It's not needed anymore these
>> days and the dependencies can go.
>
> i'd suspected something along those li
Mark Lobo wrote:
> Hello!
>
> I had a question about disabling the block layer for SCSI devices. We
> have an embedded device, and it runs 2.4.30. We need to be able to
> support a lot of SCSI devices (in the thousands) for our device, and we
> talk to the devices via SG. We are facing a memory al
On Mon, 2007-03-26 at 17:23 -0400, Douglas Gilbert wrote:
> Mark Lobo wrote:
> > I had a question about disabling the block layer for SCSI devices. We
> > have an embedded device, and it runs 2.4.30. We need to be able to
> > support a lot of SCSI devices (in the thousands) for our device, and we
>
On Mon, 26 Mar 2007 14:50:51 -0700
[EMAIL PROTECTED] wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=8266
>
>Summary: Exabyte 1x10 autoloader breaks on upgrade
> Kernel Version: 2.6.20.4
> Status: NEW
> Severity: high
> Owner: [EMAIL PROTECTE
On Mon, Mar 26, 2007 at 03:33:46PM -0700, Andrew Morton wrote:
> On Mon, 26 Mar 2007 14:50:51 -0700
> [EMAIL PROTECTED] wrote:
>
> > http://bugzilla.kernel.org/show_bug.cgi?id=8266
> >
> >Summary: Exabyte 1x10 autoloader breaks on upgrade
> > Kernel Version: 2.6.20.4
> >
Mark Lobo wrote:
> I had a question about disabling the block layer for SCSI devices. We
> have an embedded device, and it runs 2.4.30. We need to be able to
> support a lot of SCSI devices (in the thousands) for our device, and we
> talk to the devices via SG. We are facing a memory allocation pro
> > it would seem to make no sense that the "depends on" clause for this
> > option includes "m", forcing this (and all other four entries in that
> > Kconfig file, by the way) to be built as modules, while the help text
> > for all five entries suggests you can select "y".
In the old days pcmci
On Mon, 2007-03-26 at 21:02 +0100, Christoph Hellwig wrote:
> > > it would seem to make no sense that the "depends on" clause for this
> > > option includes "m", forcing this (and all other four entries in that
> > > Kconfig file, by the way) to be built as modules, while the help text
> > > for
On Mon, Mar 26, 2007 at 03:35:47PM -0500, James Bottomley wrote:
> I agree the non-legacy (CardBus and beyond) ones can be built in. I
> thought the legacy 8 and 16 bit type I and II still had to be modular
> because they still need setting up.
nope. While I don't have a pcmcia scsi card my 16 b
On Mon, 2007-03-26 at 21:38 +0100, Christoph Hellwig wrote:
> On Mon, Mar 26, 2007 at 03:35:47PM -0500, James Bottomley wrote:
> > I agree the non-legacy (CardBus and beyond) ones can be built in. I
> > thought the legacy 8 and 16 bit type I and II still had to be modular
> > because they still ne
From: Eric Sesterhenn <[EMAIL PROTECTED]>
coverity spotted this (cid #758). All callers dereference sfp, so we dont
need this check. In addition to this, we dereference it earlier in the
function.
Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]>
Cc: Douglas Gilbert <[EMAIL PROTECTED]>
Cc: Jam
From: Henne <[EMAIL PROTECTED]>
Remove some trailing whitespaces and some replace whitespaces with tabs.
Signed-off-by: Henrik Kretzschmar <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/dpt/dpti_i2o.h | 48
drivers/scsi
From: Martin Bligh <[EMAIL PROTECTED]>
Fix up compiler warnings in megaraid driver
[EMAIL PROTECTED]: build fix]
Signed-off-by: Martin J. Bligh <[EMAIL PROTECTED]>
Cc: James Bottomley <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/megaraid.c | 22 +++
From: Amol Lad <[EMAIL PROTECTED]>
For this driver cond_resched() seems to be a better alternative
Signed-off-by: Amol Lad <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/megaraid.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN drive
From: "Robert P. J. Day" <[EMAIL PROTECTED]>
Fix misspelled "spin_lock_irqrestore" to read "spin_unlock_irqrestore"
instead.
Presumably, GDTH_RTC doesn't get used a lot.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Cc: James Bottomley <[EMAIL PROTECTED]>
Signed-off
From: Olaf Hering <[EMAIL PROTECTED]>
_ convert void* to struct mesh_state*
- remove unused irq argument from mesh_interrupt()
Signed-off-by: Olaf Hering <[EMAIL PROTECTED]>
Cc: James Bottomley <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/mesh.c | 14
From: Eric Moore <[EMAIL PROTECTED]>
After host reset, the device are programmed to default asyn narrow nego.
We need to reprogram the parameter back to previous values. If the host
reset is called as a result of spi_dv_device() commands timing out, its
possible to get into an infinite loop of d
From: Dirk Mueller <[EMAIL PROTECTED]>
This patch corrects a |/|| confusion in mptscsih_copy_sense_data. Using ||
means that the data that ends up being written is (almost always) 1,
instead of being bit-wise or'ed.
Cc: Eric Moore <[EMAIL PROTECTED]>
Cc: James Bottomley <[EMAIL PROTECTED]>
Signe
From: Richard Knutsson <[EMAIL PROTECTED]>
Convert:
FALSE -> false
TRUE -> true
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/aic7xxx_old.c | 242 ++
drivers/scsi/aic7xxx_old/aic7xxx_proc.
From: Amol Lad <[EMAIL PROTECTED]>
Replaced save_flags()/cli() with spin_lock alternatives
[EMAIL PROTECTED]: no longer BROKEN_ON_SMP]
Signed-off-by: Amol Lad <[EMAIL PROTECTED]>
Cc: James Bottomley <[EMAIL PROTECTED]>
Cc: Alan Cox <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTE
From: Amol Lad <[EMAIL PROTECTED]>
Replaced yield() with cond_resched()
Signed-off-by: Amol Lad <[EMAIL PROTECTED]>
Acked-by: Alan Cox <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/NCR5380.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
From: Bernhard Walle <[EMAIL PROTECTED]>
In sd_revalidate_disk(), the SCSI Disk driver needs a few bytes DMA memory,
allocated by kmalloc() and __GFP_DMA. This patch uses __GFP_DMA only if
the corresponding host structure has unchecked_isa_dma set.
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED
From: Chip Coldwell <[EMAIL PROTECTED]>
Apropos this thread
http://marc.theaimsgroup.com/?l=linux-scsi&m=115591706804045&w=2
which led to this patch
http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-rc-fixes-2.6.git;a=commit;h=b2b3c121076961333977f485f0d54c22121df920
do we not also need
From: Henrik Kretzschmar <[EMAIL PROTECTED]>
pci_module_init() convertion in tmscsim.c
Signed-off-by: Henrik Kretzschmar <[EMAIL PROTECTED]>
Acked-by: Alan Cox <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/tmscsim.c |6 --
1 file changed, 4 insert
From: "Robert P. J. Day" <[EMAIL PROTECTED]>
Remove the unused SCSI-related kernel config variables
SCSI_NCR53C8XX_PROFILE_SUPPORT
SCSI_NCR53C8XX_PROFILE
53C700_IO_MAPPED
AIC79XX_ENABLE_RD_STRM
AIC7XXX_PROBE_EISA_VL
Signed-off-by: Robert P. J. Day <[EMAIL
From: Parag Warudkar <[EMAIL PROTECTED]>
fdomain.c uses the below stuff only if PCMCIA is not defined. This causes
unused variables to be defined when PCMCIA is not defined. Wrap variables
and functions around #ifndef PCMCIA appropriately to avoid this.
4 less compiler warnings.
Signed-off-by:
From: David Brownell <[EMAIL PROTECTED]>
This teaches scsi devices how to support "new style" hotplug/coldplug:
using a modalias sysfs attribute for coldplug, and MODALIAS environment
variable for hotplug.
It also updates the CH, SD, SR, and ST drivers with the aliases needed to
drive them by tha
From: Adrian Bunk <[EMAIL PROTECTED]>
This patch contains the following cleanups:
- make needlessly global functions static
- every file should #include the headers containing the prototypes for
it's global functions
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Cc: James Bottomley <[EMAIL PRO
From: Adrian Bunk <[EMAIL PROTECTED]>
- remove the unneeded advansys.h
- remove the unused advansys_setup()
- make needlessly global functions static
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 101 +++---
From: Adrian Bunk <[EMAIL PROTECTED]>
The Coverity checker spotted this dead code introduced by
commit a07f353701acae77e023f6270e8af353b37af7c4.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/dpt_i2o.c |2 --
1 file changed,
From: walter harms <[EMAIL PROTECTED]>
Signed-off-by: walter harms <[EMAIL PROTECTED]>
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
Cc: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/megaraid.c | 17 +++--
drivers/scsi/megara
From: Adrian Bunk <[EMAIL PROTECTED]>
- #include for getting the prototypes of {dis,en}able_irq()
- make the needlessly global wd33c93_setup() static
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/wd33c93.c |4 +++-
1 file
From: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Hannes Reinecke <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/aic7xxx/aic79xx_osm.c |6 --
drivers/scsi/aic7xxx/aic79xx_osm.h |2 --
drivers/scsi/a
From: Adrian Bunk <[EMAIL PROTECTED]>
seagate_st0x_detect() can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/seagate.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/scsi/seagate.c~ma
From: Adrian Bunk <[EMAIL PROTECTED]>
- proper prototypes for global code in aacraid.h
- aac_rx_start_adapter() can now become static
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Cc: James Bottomley <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/aacraid/
From: Adrian Bunk <[EMAIL PROTECTED]>
- make needlessly global code static
- #if 0 unused functions
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Ravi Anand <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/scsi/qla4xxx/ql4_dbg.c |4
drivers/s
From: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Eric Moore <[EMAIL PROTECTED]>
Cc: James Bottomley <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/message/fusion/mptspi.c |2 +-
1 file changed, 1 insertion(+), 1
thomas schorpp wrote:
thomas schorpp wrote:
James Bottomley wrote:
On Sat, 2007-03-24 at 01:51 +0100, thomas schorpp wrote:
no. so the pci layer reports wrong start:
nonsense. it succeeds, confused function return with the error flag:
// u_long start;
// u_long start = 0xFFEFF000
43 matches
Mail list logo
