RE: Possible bug in scsi_lib.c:scsi_req_map_sg()

2007-03-02 Thread Dachepalli, Sudhir
Hello All, I am noticing the following panic on SLES 10 ( as well as Redhat 5 ). I modified "scsi_lib.c" to print some debugging information. Our driver is a Multipath failover module and we are using "scsi_execute_async" API for routing IO's. In earlier kernels we used "scsi_do_req" API. Messag

Re: Possible bug in scsi_lib.c:scsi_req_map_sg()

2007-03-02 Thread Mike Christie
Dachepalli, Sudhir wrote: > scsi_req_map_sg::i=2,len=1024,data_len=3072,off=2048,PAGE_SIZE=4096,byte > s=1024,nr_vecs=0, nr_pages=0 > if (bio_add_pc_page(q, bio, page, bytes, off) != > bytes) { > printk("scsi_req_

Re: Possible bug in scsi_lib.c:scsi_req_map_sg()

2007-03-02 Thread Mike Christie
Mike Christie wrote: > Dachepalli, Sudhir wrote: >> scsi_req_map_sg::i=2,len=1024,data_len=3072,off=2048,PAGE_SIZE=4096,byte >> s=1024,nr_vecs=0, nr_pages=0 > > >> if (bio_add_pc_page(q, bio, page, bytes, off) != >> bytes) { >>

Re: [PATCH] iscsi tcp set queue dma alignment to zero

2007-03-02 Thread Mike Christie
Pete Wyckoff wrote: > Add a slave_configure function to iSCSI TCP to remove any DMA > alignment restriction. This permits the use of direct IO from > arbitrary addresses. > > Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]> > --- > drivers/scsi/iscsi_tcp.c | 11 +++ > 1 files changed, 1

RE: Possible bug in scsi_lib.c:scsi_req_map_sg()

2007-03-02 Thread Dachepalli, Sudhir
Mike, I applied "patch 1" posted by Boaz Harrosh to my SLES 10 kernel. So far IO's are running for 45 minutes which is the longest in my numerous re-tries. We were not aware that "scsi_execute_async" was temperory workaround. Where is the depricated warning that you mentioned about ? I tried to

[PATCH 0/3] tgt fixes

2007-03-02 Thread FUJITA Tomonori
This patchset fixes sense buffer handling bugs and scsi command leak with cleanups to remove bio hacks. The patchset are made over scsi-rc-fixes tree. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:

[PATCH 1/3] tgt: rm bio hacks in scsi tgt

2007-03-02 Thread FUJITA Tomonori
From: Mike Christie <[EMAIL PROTECTED]> scsi tgt breaks up a command into multple scatterlists if we cannot fit all the data in one. This was because the block rq helpers did not support large requests and because we can get a command of any old size so it is hard to preallocate pages for scatterl

[PATCH 3/3] tgt: fix scsi command leak

2007-03-02 Thread FUJITA Tomonori
The failure to map user-space pages leads to scsi command leak. It can happens mostly because of user-space daemon bugs (or OOM). This patch makes tgt just notify a LLD of the failure with sense when blk_rq_map_user() fails. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> Signed-off-by: Mike Ch

[PATCH 2/3] tgt: fix sesnse buffer problems

2007-03-02 Thread FUJITA Tomonori
This patch simplify the way to notify LLDs of the command completion and addresses the following sense buffer problems: - can't handle both data and sense. - forces user-space to use aligned sense buffer tgt copies sense_data from userspace to cmnd->sense_buffer (if necessary), maps user-space pa