[PATCH] Add VPD support to aacraid

2007-01-25 Thread Hannes Reinecke
Hi Mark, I found to my surprise that the aacraid driver does not support VPD pages at all. I'm somewhat used to modern SCSI HBAs export SCSI-2 disks, but not supporting VPD pages at all is really a bit .. hmm .. SCSI-1-ish. And it makes it really impossible to assign a persistent device ID to thos

Re: [PATCH] Add VPD support to aacraid

2007-01-25 Thread Hannes Reinecke
Hannes Reinecke wrote: > Hi Mark, > > I found to my surprise that the aacraid driver does not support VPD > pages at all. I'm somewhat used to modern SCSI HBAs export SCSI-2 disks, > but not supporting VPD pages at all is really a bit .. hmm .. SCSI-1-ish. > And it makes it really impossible to as

Re: [PATCH] Add VPD support to aacraid

2007-01-25 Thread Randy Dunlap
On Thu, 25 Jan 2007 10:47:35 +0100 Hannes Reinecke wrote: +/* Function: setinqserial + * + * Arguments: [1] pointer to void [1] int Hi-- What does that notation mean? (I know, you copied it. :) Parts of this source file use kernel-doc and parts don't. Would be nice to see it converted to all ke

RE: [PATCH] Add VPD support to aacraid

2007-01-25 Thread Salyzyn, Mark
Hannes, I am working the firmware and management software folks to find out how to mine for this information. In your patch, the controller serial number may be helpful, but not necessarily compliant? Besides persistent device id, what else is gained? The controller ensures persistent device id

Re: [PATCH RFC 0/2] imu-scsi for iop13xx

2007-01-25 Thread James Bottomley
On Wed, 2007-01-24 at 11:22 -0700, [EMAIL PROTECTED] wrote: > The imu (inter-processor messaging unit) on the iop13xx enables mailbox > style communication between the two cores on iop13xx. Greg Tucker has > has wrapped this capability in a scsi driver which allows Linux to > interface with the ot

Re: [PATCH RFC 2/2] iop13xx: imu scsi driver

2007-01-25 Thread James Bottomley
There are quite a few commented out debugging statements and deprecated C++ style comments dotted throughout this driver ... could these be corrected? (move to C style comments and either implement a debugging strategy or pull out the statements). Another thing that strikes me is on the ARM side,

Re: [PATCH] ieee1394: sbp2: lower block queue alignment requirement

2007-01-25 Thread Stefan Richter
On 14 Jan, James Bottomley wrote: > The block layer currently provides sector (512) byte alignment > guarantees. However, there has been talk in SCSI of reducing that to > word (4) since that's what most intelligent PCI controllers can cope > with. If you have any alignment constraints, they shou

Re: Linux Virtual SCSI HBAs and Virtual disks

2007-01-25 Thread Aboo Valappil
Hi Doug Gilbert, I am not sure if my previous email was received or not. # ./start_target.sh id=3 -files ../../zz_lun0 -v # lsscsi [0:0:0:0]diskLinuxscsi_debug 0004 /dev/sda [1:0:0:0]diskVirtualH VHD 0 /dev/sdb So "id=3" doesn't look the target identi

Re: Linux Virtual SCSI HBAs and Virtual disks

2007-01-25 Thread Stefan Richter
Aboo Valappil wrote: > What would i do if the SCSI target does not return any sense code? I > make some thing up or just return no-sense? I guess it depends on whether the in-kernel part of your software stack actually knows enough details to generate correct sense codes. > In the new version, I

Linux Virtual SCSI HBAs and Virtual disks

2007-01-25 Thread Aboo Valappil
Hi All, Thanks for all your encouragement and help on this project. I like to take this project one step ahead. I hope you can help me on this. As you may have noticed, I am doing a copy of buffers ( request_buffer) between user space and kernel space. What are my options these days to make

why no cmd_flags parameter for scsi_execute_async?

2007-01-25 Thread Edward Goggin
Looks like a simple oversight, but does anyone know why there a cmd_flags parameter for scsi_execute but not for scsi_execute_async? Seems like this is lost functionality when scsi_execute_async replaced scsi_do_req. Previously, the caller of scsi_do_req could set the flags field of the sr_reques

Re: why no cmd_flags parameter for scsi_execute_async?

2007-01-25 Thread Mike Christie
Edward Goggin wrote: > Looks like a simple oversight, but does anyone know why there a > cmd_flags parameter for scsi_execute but not for scsi_execute_async? > > Seems like this is lost functionality when scsi_execute_async replaced > scsi_do_req. Previously, the caller of scsi_do_req could set t

Re: [Bugme-new] [Bug 7864] New: A MTIOCTOP/MTWEOF within the early warning will cause the file number to be incorrect

2007-01-25 Thread Kai Makisara
On Wed, 24 Jan 2007, Andrew Morton wrote: > On Mon, 22 Jan 2007 13:07:20 -0800 > [EMAIL PROTECTED] wrote: > > > http://bugzilla.kernel.org/show_bug.cgi?id=7864 > > > >Summary: A MTIOCTOP/MTWEOF within the early warning will cause > > the file number to be incorrec

[PATCH] remove duplicate device id from IPR driver

2007-01-25 Thread Greg KH
From: Greg Kroah-Hartman <[EMAIL PROTECTED]> This patch removes a duplicate device id from the IPR driver. Based on the ipr.h file, I'm not so sure this was intended to be a duplicate, and if so, the .h file should be modified to use the proper sub-device id instead. This was pointed out to me b

Re: [patch] scsi: use lock per host instead of per device for shared queue tag host

2007-01-25 Thread Jens Axboe
On Wed, Jan 24 2007, Ed Lin wrote: > > > > -Original Message- > > From: David Somayajulu [mailto:[EMAIL PROTECTED] > > Sent: Wednesday, January 24, 2007 5:03 PM > > To: Ed Lin; Michael Reed > > Cc: linux-scsi; linux-kernel; james.Bottomley; jeff; > > Promise_Linux; Jens Axboe > > Subjec

Re: [patch] scsi: use lock per host instead of per device for shared queue tag host

2007-01-25 Thread Jens Axboe
On Thu, Jan 25 2007, Jens Axboe wrote: > On Wed, Jan 24 2007, Ed Lin wrote: > > > > > > > -Original Message- > > > From: David Somayajulu [mailto:[EMAIL PROTECTED] > > > Sent: Wednesday, January 24, 2007 5:03 PM > > > To: Ed Lin; Michael Reed > > > Cc: linux-scsi; linux-kernel; james.Bot

lsscsi-0.19 released

2007-01-25 Thread Douglas Gilbert
lsscsi is a utility that uses sysfs in linux 2.6 series kernels to list information about SCSI devices and SCSI hosts. Both a compact format (default) which is one line per device and a "classic" format (like the output of 'cat /proc/scsi/scsi') are supported. Version 0.19 is available at http://w

RE: [patch] scsi: use lock per host instead of per device for shared queue tag host

2007-01-25 Thread Ed Lin
> -Original Message- > From: Jens Axboe [mailto:[EMAIL PROTECTED] > Sent: Thursday, January 25, 2007 7:48 AM > To: Ed Lin > Cc: David Somayajulu; Michael Reed; linux-scsi; linux-kernel; > james.Bottomley; jeff; Promise_Linux > Subject: Re: [patch] scsi: use lock per host instead of per

Re: [patch] scsi: use lock per host instead of per device for shared queue tag host

2007-01-25 Thread Jeff Garzik
Ed Lin wrote: There may possibly be some other errors. So we need a lock here. I think the simple but reliable way to do it is just to replace queue lock with a host lock. James pointed out that there may be performance slow down when many devices are accessed at the same time. But I think the ma

RE: [PATCH RFC 2/2] iop13xx: imu scsi driver

2007-01-25 Thread Tucker, Greg B
James, thank you for the corrections. I think I can fix all of these as suggested and resubmit a new patch shortly. >Another thing that strikes me is on the ARM side, it looks like this is >effectively vectoring up to a user space target ... is that true? And >if so, would the existing in-kernel