Re: Possible bug in scsi_lib.c:scsi_req_map_sg()

2006-11-29 Thread Benny Halevy
Jens Axboe wrote: On Mon, Nov 27 2006, Mike Christie wrote: Mike Christie wrote: Boaz Harrosh wrote: Playing with some tests which I admit are not 100% orthodox I have stumbled upon a bug that raises a serious question: In the call to scsi_execute_async() in the use_sg case, must the scatterl

[2.6 patch] drivers/scsi/scsi_error.c should #include "scsi_transport_api.h"

2006-11-29 Thread Adrian Bunk
Every file should #include the headers containing the prototypes for its global functions. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.19-rc6-mm2/drivers/scsi/scsi_error.c.old 2006-11-29 09:58:41.0 +0100 +++ linux-2.6.19-rc6-mm2/drivers/scsi/scsi_error.c 2006-11-2

Re: aic94xx panic on module load

2006-11-29 Thread Mark Haverkamp
On Tue, 2006-11-28 at 20:52 -0500, Douglas Gilbert wrote: > Mark Haverkamp wrote: > > On Tue, 2006-11-28 at 13:46 -0800, Mark Haverkamp wrote: > >> On Tue, 2006-11-28 at 13:44 -0500, Douglas Gilbert wrote: > >> > >> [ ... ] > >> > > > > I don't know if this helps, but I found the verbose option.

Re: aic94xx panic on module load

2006-11-29 Thread Douglas Gilbert
Mark Haverkamp wrote: > On Tue, 2006-11-28 at 20:52 -0500, Douglas Gilbert wrote: >> Mark Haverkamp wrote: >>> On Tue, 2006-11-28 at 13:46 -0800, Mark Haverkamp wrote: On Tue, 2006-11-28 at 13:44 -0500, Douglas Gilbert wrote: [ ... ] >>> I don't know if this helps, but I found t

[2.6 PATCH] sym53c8xx_2 claims cpqarray device

2006-11-29 Thread Chip Coldwell
Apropos this thread http://marc.theaimsgroup.com/?l=linux-scsi&m=115591706804045&w=2 which led to this patch http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-rc-fixes-2.6.git;a=commit;h=b2b3c121076961333977f485f0d54c22121df920 do we not also need the following patch, nine lines lower in

Re: [2.6 patch] drivers/scsi/scsi_error.c should #include "scsi_transport_api.h"

2006-11-29 Thread Matthew Wilcox
On Wed, Nov 29, 2006 at 11:04:22AM +0100, Adrian Bunk wrote: > +#include "scsi_transport_api.h" scsi_transport_api.h is a weird little file. It's not included by anything in the drivers/scsi directory, only drivers/scsi/libsas/sas_scsi_host.c:#include "../scsi_transport_api.h" drivers/ata/libata-

Re: [2.6 patch] drivers/scsi/scsi_error.c should #include "scsi_transport_api.h"

2006-11-29 Thread James Smart
Matthew Wilcox wrote: On Wed, Nov 29, 2006 at 11:04:22AM +0100, Adrian Bunk wrote: +#include "scsi_transport_api.h" scsi_transport_api.h is a weird little file. It's not included by anything in the drivers/scsi directory, only drivers/scsi/libsas/sas_scsi_host.c:#include "../scsi_transport_

Re: [2.6 patch] drivers/scsi/scsi_error.c should #include "scsi_transport_api.h"

2006-11-29 Thread Matthew Wilcox
On Wed, Nov 29, 2006 at 09:13:35AM -0500, James Smart wrote: > would it only go in include/scsi if it intends to be an exported > api for LLDD's and/or user apps ? and stay in drivers/scsi if its > an internal api within the scsi subsystem itself ? It isn't clear to me that's the intended use of

Re: aic94xx panic on module load

2006-11-29 Thread Mark Haverkamp
On Tue, 2006-11-28 at 10:01 -0800, Darrick J. Wong wrote: > Mark Haverkamp wrote: > > I got this panic when loading the aic94xx module. The adapter is > > connected to an HP MSA50 SAS enclosure with 3 72GB SAS disks. > > > > Kernel 2.6.19-rc6-scsi-misc on an x86_64 > > > sas: task finished with

problems to expect with >2TB volumes

2006-11-29 Thread Bernd Schubert
Hi, we have not bought the device yet, but presently in the process to do so. Before we buy it, I want to know about problems in advance... I'm somewhat worried about this problem report http://lists.freebsd.org/pipermail/aic7xxx/2006-January/thread.html#4280 Especially as I don't see a final sol

Re: problems to expect with >2TB volumes

2006-11-29 Thread Douglas Gilbert
Bernd Schubert wrote: > Hi, > > we have not bought the device yet, but presently in the process to do so. > Before we buy it, I want to know about problems in advance... None that I'm aware of from the point of view of the Linux SCSI subsystem (starting at about half way through the lk 2.4 series

Infinite retries reading the partition table

2006-11-29 Thread Luben Tuikov
Suppose reading sector 0 always reports an error, sense key HARDWARE ERROR. What I'm observing is that the request to read sector 0, reading partition information, is retried forever, ad infinitum. Does anyone have a patch to resolve this? (2.6.19-rc6) Thanks, Luben - To unsubscribe from th

Re: Infinite retries reading the partition table

2006-11-29 Thread Luben Tuikov
--- Luben Tuikov <[EMAIL PROTECTED]> wrote: > Suppose reading sector 0 always reports an error, > sense key HARDWARE ERROR. > > What I'm observing is that the request to read sector 0, > reading partition information, is retried forever, ad infinitum. > > Does anyone have a patch to resolve this

[PATCH] [SCSI] Fix sense key MEDIUM ERROR processing and retry

2006-11-29 Thread Luben Tuikov
1) If the device reports an uncorrectable MEDIUM ERROR, such as SK MEDIUM ERROR, ASC UNRECOVERED READ ERR, AMNF DATA FIELD or RECORD NOT FOUND, then: In scsi_check_sense() return SUCCESS so as to not retry -- the error is uncorrectable -- this speeds up total processing time. 2) In scsi_io_complet

Re: aic94xx panic on module load

2006-11-29 Thread Luben Tuikov
--- Douglas Gilbert <[EMAIL PROTECTED]> wrote: > Mark Haverkamp wrote: > > On Tue, 2006-11-28 at 20:52 -0500, Douglas Gilbert wrote: > >> Mark Haverkamp wrote: > >>> On Tue, 2006-11-28 at 13:46 -0800, Mark Haverkamp wrote: > On Tue, 2006-11-28 at 13:44 -0500, Douglas Gilbert wrote: > > >>