Re: slave_configure for qlogicpti

2007-10-01 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Sun, 30 Sep 2007 20:52:45 -0400 David Miller wrote: It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}() so you can kill those off too. Seeing as how they are exact duplicates of libata's ata_scsi_rbuf_{get,put},

Re: slave_configure for qlogicpti

2007-09-30 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Sun, 30 Sep 2007 20:52:45 -0400 > David Miller wrote: > > It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}() > > so you can kill those off too. > > > Seeing as how they are exact duplicates of libata's > ata_scsi_rbuf_{get,put}, I won

Re: slave_configure for qlogicpti

2007-09-30 Thread Jeff Garzik
David Miller wrote: It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}() so you can kill those off too. Seeing as how they are exact duplicates of libata's ata_scsi_rbuf_{get,put}, I wonder how they got there in the first place (rather than becoming common code), and I wonder

Re: slave_configure for qlogicpti

2007-09-30 Thread David Miller
From: Matthew Wilcox <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 06:46:37 -0600 > > I haven't even compile-tested this. But look how much ugly code it > deletes if it works! It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}() so you can kill those off too. I don't have the time

slave_configure for qlogicpti

2007-09-19 Thread Matthew Wilcox
I haven't even compile-tested this. But look how much ugly code it deletes if it works! diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c index 5948872..346bed6 100644 --- a/drivers/scsi/qlogicpti.c +++ b/drivers/scsi/qlogicpti.c @@ -310,8 +310,6 @@ static inline void qlogicpti_se