Re: scsi: ufs: Problem at init on msm8998

2019-01-15 Thread Marc Gonzalez
On 15/01/2019 13:37, Marc Gonzalez wrote: > After adding the "regulator-allow-set-load" property to the vreg DT nodes, > the UFSHC driver was finally able to talk to the Flash chip! > > However, all is not well yet :-) > > First, I had to turn ufshcd_set_vccq_rail_unused() into a NOP, otherwise

Re: scsi: ufs: Problem at init on msm8998

2019-01-15 Thread Marc Gonzalez
On 15/01/2019 13:37, Marc Gonzalez wrote: > I had a look at "[8998] How to check PMIC PON reason" but I'm not sure how to > read > PM0=0x42420020:0x40 PM1=0x48480020:0x800 > PM2=0x48480020:0x800 AFAIU, the PM0 format is [8c7][8c6][8c5][8c4][8c3][8c2][8c1][8c0]:[8cb][8ca

Re: scsi: ufs: Problem at init on msm8998

2019-01-15 Thread Marc Gonzalez
On 14/01/2019 13:18, Marc Gonzalez wrote: > On 14/01/2019 12:57, Marc Gonzalez wrote: > >> On 13/12/2018 15:24, Marc Gonzalez wrote: >> >>> I'm having trouble getting UFS working on an APQ8098 MEDIABOX dev board. >>> (I'm running v4.20-rc4 with a few UFS patches taken off the MSM list.) >>> >>> I

Re: scsi: ufs: Problem at init on msm8998

2019-01-14 Thread Marc Gonzalez
On 14/01/2019 12:57, Marc Gonzalez wrote: > On 13/12/2018 15:24, Marc Gonzalez wrote: > >> I'm having trouble getting UFS working on an APQ8098 MEDIABOX dev board. >> (I'm running v4.20-rc4 with a few UFS patches taken off the MSM list.) >> >> I'm hoping someone with experience with the UFSHC wil

Re: scsi: ufs: Problem at init on msm8998

2019-01-14 Thread Marc Gonzalez
On 13/12/2018 15:24, Marc Gonzalez wrote: > I'm having trouble getting UFS working on an APQ8098 MEDIABOX dev board. > (I'm running v4.20-rc4 with a few UFS patches taken off the MSM list.) > > I'm hoping someone with experience with the UFSHC will spot the one thing > missing that will make ever

Re: scsi: ufs: Problem at init on msm8998

2019-01-11 Thread Marc Gonzalez
On 13/12/2018 15:24, Marc Gonzalez wrote: > I'm having trouble getting UFS working on an APQ8098 MEDIABOX dev board. > (I'm running v4.20-rc4 with a few UFS patches taken off the MSM list.) > > I'm hoping someone with experience with the UFSHC will spot the one thing > missing that will make ever

Re: scsi: ufs: Problem at init on msm8998

2018-12-28 Thread Marc Gonzalez
On 21/12/2018 21:08, Marc Gonzalez wrote: > I think I've checked every low-level thingamajig: > clocks, regulators, power domains, gdsc, voltage spec I'm printing all but a few writel's but I'm not seeing anything when the regulators are being set up... Something to investigate. https://pastebin

Re: scsi: ufs: Problem at init on msm8998

2018-12-21 Thread Marc Gonzalez
[ Dropping large CC list ] On 20/12/2018 15:43, Marc Gonzalez wrote: > I think I've checked every low-level thingamajig: > clocks, regulators, power domains, gdsc, voltage spec I found something else, by comparing the writes to the PHY and HC, downstream vs upstream: ufs_qcom_link_startup_post_

Re: scsi: ufs: Problem at init on msm8998

2018-12-20 Thread Jeffrey Hugo
On 12/20/2018 5:38 AM, Marc Gonzalez wrote: On 19/12/2018 18:27, Marc Gonzalez wrote: On 18/12/2018 17:54, Marc Gonzalez wrote: Now the fun begins, to find the tiny difference that makes/breaks everything :-) I thought I had found the problem: "clk_set_rate: ufs_unipro_core_clk_src" was not

Re: scsi: ufs: Problem at init on msm8998

2018-12-20 Thread Marc Gonzalez
On 20/12/2018 13:38, Marc Gonzalez wrote: > Found something fishy... [ufs_phy_aux_clk rate returned 0] Even with that "fixed" [or rather hacked around, since the syntax of drivers/clk/qcom/gcc-msm8998.c remains nebulous, even after staring at it, literally, for hours] the UFSHC refuses to functio

Re: scsi: ufs: Problem at init on msm8998

2018-12-20 Thread Marc Gonzalez
On 19/12/2018 18:27, Marc Gonzalez wrote: > On 18/12/2018 17:54, Marc Gonzalez wrote: > >> Now the fun begins, to find the tiny difference that makes/breaks everything >> :-) > I thought I had found the problem: > "clk_set_rate: ufs_unipro_core_clk_src" was not occurring. > But, in fact, I think

Re: scsi: ufs: Problem at init on msm8998

2018-12-19 Thread Marc Gonzalez
On 18/12/2018 17:54, Marc Gonzalez wrote: > Now the fun begins, to find the tiny difference that makes/breaks everything > :-) I thought I had found the problem: "clk_set_rate: ufs_unipro_core_clk_src" was not occurring. But, in fact, I think the bootloader already set the proper rate. I'll hav

Re: scsi: ufs: Problem at init on msm8998

2018-12-18 Thread Marc Gonzalez
On 17/12/2018 10:28, Marc Gonzalez wrote: > On 17/12/2018 08:14, Kyuho Choi wrote: > >> On Thursday, December 13, 2018, Marc Gonzalez wrote: >> >> I'm having trouble getting UFS working on an APQ8098 MEDIABOX dev board. >> (I'm running v4.20-rc4 with a few UFS patches taken off the MSM li

Re: scsi: ufs: Problem at init on msm8998

2018-12-17 Thread Marc Gonzalez
Hello Kyuho, On 17/12/2018 08:14, Kyuho Choi wrote: > On Thursday, December 13, 2018, Marc Gonzalez wrote: > > Hello everyone, > > I'm having trouble getting UFS working on an APQ8098 MEDIABOX dev board. > (I'm running v4.20-rc4 with a few UFS patches taken off the MSM list.) > >

Re: scsi: ufs: Problem at init on msm8998

2018-12-16 Thread Kyuho Choi
Hi Marc, I'm not sure, but please check below comment. On 12/13/18, Marc Gonzalez wrote: > Hello everyone, > > I'm having trouble getting UFS working on an APQ8098 MEDIABOX dev board. > (I'm running v4.20-rc4 with a few UFS patches taken off the MSM list.) > > I'm hoping someone with experience

scsi: ufs: Problem at init on msm8998

2018-12-13 Thread Marc Gonzalez
Hello everyone, I'm having trouble getting UFS working on an APQ8098 MEDIABOX dev board. (I'm running v4.20-rc4 with a few UFS patches taken off the MSM list.) I'm hoping someone with experience with the UFSHC will spot the one thing missing that will make everything work! Below is the full boot