Re: scsi: add support for a blk-mq based I/O path.

2014-09-16 Thread Webb Scales
On 9/16/14 10:41 AM, Daniel Gryniewicz wrote: Hi, Chris. I'm working with the OSD Initiator, which does bi-directional requests, and this commit (d285203 scsi: add support for a blk-mq based I/O path.) causes a use-after free panic for me. The panic itself follows, but the cause is

Re: scsi: add support for a blk-mq based I/O path.

2014-09-16 Thread Christoph Hellwig
On Tue, Sep 16, 2014 at 01:17:55PM -0400, Daniel Gryniewicz wrote: >> this should also be fixed with my patch "scsi: clean up S/G table freeing", >> can you test if that fixes the issue for you as well? >> > > > Yeah, that fixes it, thanks. Thanks. Looking at the impact of that I suspect we're bet

Re: scsi: add support for a blk-mq based I/O path.

2014-09-16 Thread Daniel Gryniewicz
On 09/16/2014 12:19 PM, Christoph Hellwig wrote: Hi Daniel, this should also be fixed with my patch "scsi: clean up S/G table freeing", can you test if that fixes the issue for you as well? Yeah, that fixes it, thanks. Daniel -- To unsubscribe from this list: send the line "unsubscribe linu

Re: scsi: add support for a blk-mq based I/O path.

2014-09-16 Thread Christoph Hellwig
Hi Daniel, this should also be fixed with my patch "scsi: clean up S/G table freeing", can you test if that fixes the issue for you as well? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http:

Re: scsi: add support for a blk-mq based I/O path.

2014-09-16 Thread Daniel Gryniewicz
Hi, Chris. I'm working with the OSD Initiator, which does bi-directional requests, and this commit (d285203 scsi: add support for a blk-mq based I/O path.) causes a use-after free panic for me. The panic itself follows, but the cause is that scsi_end_request() calls blk_finish_re

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-08-19 Thread Kashyap Desai
On Tue, Aug 19, 2014 at 9:36 PM, Christoph Hellwig wrote: > On Tue, Aug 19, 2014 at 03:51:42AM +0530, Kashyap Desai wrote: >> I read this comment and find that very few drivers are using this >> cmd_list. I think if we remove this cmd_list, performance will scale as I >> am seeing major contenti

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-08-19 Thread Christoph Hellwig
On Tue, Aug 19, 2014 at 03:51:42AM +0530, Kashyap Desai wrote: > I read this comment and find that very few drivers are using this > cmd_list. I think if we remove this cmd_list, performance will scale as I > am seeing major contention in this lock. > Just thought to ping you to see if this is kn

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-08-19 Thread Kashyap Desai
; To: James Bottomley; linux-scsi@vger.kernel.org > > Cc: Jens Axboe; Bart Van Assche; Mike Christie; Martin K. Petersen; > Robert > > Elliott; Webb Scales; linux-ker...@vger.kernel.org > > Subject: [PATCH 13/14] scsi: add support for a blk-mq based I/O path. > > > > This patch a

RE: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-08-18 Thread Kashyap Desai
Christie; Martin K. Petersen; Robert > Elliott; Webb Scales; linux-ker...@vger.kernel.org > Subject: [PATCH 13/14] scsi: add support for a blk-mq based I/O path. > > This patch adds support for an alternate I/O path in the scsi midlayer which > uses the blk-mq infrastructure instead of th

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-07-25 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> This patch adds support for an alternate I/O path in the scsi Christoph> midlayer which uses the blk-mq infrastructure instead of the Christoph> legacy request code. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Lin

[PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-07-18 Thread Christoph Hellwig
This patch adds support for an alternate I/O path in the scsi midlayer which uses the blk-mq infrastructure instead of the legacy request code. Use of blk-mq is fully transparent to drivers, although for now a host template field is provided to opt out of blk-mq usage in case any unforseen incompa

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-07-16 Thread Christoph Hellwig
On Wed, Jul 16, 2014 at 06:13:21AM -0500, Mike Christie wrote: > I see the request timer is started before calling queue_rq, but I could > not figure out what the cancel_delayed_work here is for exactly. It > seems if the request were to time out and the eh started while queue_rq > was running we c

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-07-16 Thread Mike Christie
On 06/25/2014 11:52 AM, Christoph Hellwig wrote: > +static int scsi_queue_rq(struct blk_mq_hw_ctx *hctx, struct request *req) > +{ > + struct request_queue *q = req->q; > + struct scsi_device *sdev = q->queuedata; > + struct Scsi_Host *shost = sdev->host; > + struct scsi_cmnd *cmd =

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-07-09 Thread Hannes Reinecke
On 06/25/2014 06:52 PM, Christoph Hellwig wrote: This patch adds support for an alternate I/O path in the scsi midlayer which uses the blk-mq infrastructure instead of the legacy request code. Use of blk-mq is fully transparent to drivers, although for now a host template field is provided to op

[PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-06-25 Thread Christoph Hellwig
This patch adds support for an alternate I/O path in the scsi midlayer which uses the blk-mq infrastructure instead of the legacy request code. Use of blk-mq is fully transparent to drivers, although for now a host template field is provided to opt out of blk-mq usage in case any unforseen incompa

[PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-06-12 Thread Christoph Hellwig
This patch adds support for an alternate I/O path in the scsi midlayer which uses the blk-mq infrastructure instead of the legacy request code. Use of blk-mq is fully transparent to drivers, although for now a host template field is provided to opt out of blk-mq usage in case any unforseen incompa