Re: aha1542: rework locking

2015-04-21 Thread Dan Carpenter
On Tue, Apr 21, 2015 at 12:39:40PM +0200, Ondrej Zary wrote: > Thanks, I missed that as it was already wrong before (since at least when > DEF_SCSI_QCMD was introduced). And it worked despite that. If you turn on CONFIG_DEBUG_ATOMIC_SLEEP=y it will generate a warning splat. Otherwise you probably

Re: aha1542: rework locking

2015-04-21 Thread Ondrej Zary
On Tuesday 21 April 2015, Dan Carpenter wrote: > Hello Ondrej Zary, > > The patch 1b0224b0ec60: "aha1542: rework locking" from Feb 6, 2015, > leads to the following static checker warning: > > drivers/scsi/aha1542.c:448 aha1542_queuecommand() > error: scheduling with locks held: 'spin

re: aha1542: rework locking

2015-04-21 Thread Dan Carpenter
Hello Ondrej Zary, The patch 1b0224b0ec60: "aha1542: rework locking" from Feb 6, 2015, leads to the following static checker warning: drivers/scsi/aha1542.c:448 aha1542_queuecommand() error: scheduling with locks held: 'spin_lock:host_lock' drivers/scsi/aha1542.c 400