Re: [PATCH] Block/iopoll: Remove redundant export variable blk_iopoll_enabled

2014-03-28 Thread sagi grimberg
On 3/28/2014 11:05 PM, Jens Axboe wrote: On 03/28/2014 02:01 PM, Sagi Grimberg wrote: No need for this variable anymore - blk_iopoll should always be enabled. Also remove the user references to it. I just removed the blk_iopoll_enabled condition from the user logic but I don't hav

Re: [PATCH] Block/iopoll: Remove redundant export variable blk_iopoll_enabled

2014-03-28 Thread Jens Axboe
On 03/28/2014 02:01 PM, Sagi Grimberg wrote: No need for this variable anymore - blk_iopoll should always be enabled. Also remove the user references to it. I just removed the blk_iopoll_enabled condition from the user logic but I don't have the facilities to test that I didn't brea

[PATCH] Block/iopoll: Remove redundant export variable blk_iopoll_enabled

2014-03-28 Thread Sagi Grimberg
No need for this variable anymore - blk_iopoll should always be enabled. Also remove the user references to it. I just removed the blk_iopoll_enabled condition from the user logic but I don't have the facilities to test that I didn't break be2iscsi or ipr users, So I was hoping that

Re: blk_iopoll_enabled

2014-03-13 Thread Sagi Grimberg
On 3/13/2014 5:34 PM, Jens Axboe wrote: On 03/12/2014 09:40 PM, Jens Axboe wrote: On 2014-03-12 11:35, Sagi Grimberg wrote: Hey Jens, So I'm looking at blk_iopoll for iSER & SRP and I have one gap I would like to get your input on. In blk-iopoll.c I see: int blk_iopoll_en

Re: blk_iopoll_enabled

2014-03-13 Thread Jens Axboe
On 03/12/2014 09:40 PM, Jens Axboe wrote: On 2014-03-12 11:35, Sagi Grimberg wrote: Hey Jens, So I'm looking at blk_iopoll for iSER & SRP and I have one gap I would like to get your input on. In blk-iopoll.c I see: int blk_iopoll_enabled = 1; EXPORT_SYMBOL(blk_iopoll_enabled); This

Re: blk_iopoll_enabled

2014-03-12 Thread Jens Axboe
On 2014-03-12 11:35, Sagi Grimberg wrote: Hey Jens, So I'm looking at blk_iopoll for iSER & SRP and I have one gap I would like to get your input on. In blk-iopoll.c I see: int blk_iopoll_enabled = 1; EXPORT_SYMBOL(blk_iopoll_enabled); This is set to 1 and exported for everyone to

blk_iopoll_enabled

2014-03-12 Thread Sagi Grimberg
Hey Jens, So I'm looking at blk_iopoll for iSER & SRP and I have one gap I would like to get your input on. In blk-iopoll.c I see: int blk_iopoll_enabled = 1; EXPORT_SYMBOL(blk_iopoll_enabled); This is set to 1 and exported for everyone to condition and *modify* it. The documenta