Re: bio_integrity_verify() bug causing READ verify to be silently skipped

2014-01-21 Thread Jens Axboe
On Tue, Jan 21 2014, Nicholas A. Bellinger wrote: > On Fri, 2014-01-17 at 16:58 -0500, Martin K. Petersen wrote: > > > "nab" == Nicholas A Bellinger writes: > > > > >> That breaks partial completion, though. I'll take a look at Kent's > > >> changes... > > > > nab> Ping..? Any updates on a

Re: bio_integrity_verify() bug causing READ verify to be silently skipped

2014-01-21 Thread Nicholas A. Bellinger
On Fri, 2014-01-17 at 16:58 -0500, Martin K. Petersen wrote: > > "nab" == Nicholas A Bellinger writes: > > >> That breaks partial completion, though. I'll take a look at Kent's > >> changes... > > nab> Ping..? Any updates on a proper bugfix for this..? > > I did put your patch in my queue

Re: bio_integrity_verify() bug causing READ verify to be silently skipped

2014-01-17 Thread Martin K. Petersen
> "nab" == Nicholas A Bellinger writes: >> That breaks partial completion, though. I'll take a look at Kent's >> changes... nab> Ping..? Any updates on a proper bugfix for this..? I did put your patch in my queue and have been working on a fix for the partial completion case. The latter re

Re: bio_integrity_verify() bug causing READ verify to be silently skipped

2014-01-16 Thread Nicholas A. Bellinger
On Fri, 2014-01-03 at 15:09 -0500, Martin K. Petersen wrote: > > "nab" == Nicholas A Bellinger writes: > > nab> Given that bio_integrity_verify() is using bio_for_each_segment(), > nab> the loop starts from the updated bio->bi_idx, and not a zero value, > nab> which ends up skipping individua

Re: bio_integrity_verify() bug causing READ verify to be silently skipped

2014-01-03 Thread Martin K. Petersen
> "nab" == Nicholas A Bellinger writes: nab> Given that bio_integrity_verify() is using bio_for_each_segment(), nab> the loop starts from the updated bio->bi_idx, and not a zero value, nab> which ends up skipping individual bio segment calls to nab> bi->verify_fn(). That's botched. Verify is

Re: bio_integrity_verify() bug causing READ verify to be silently skipped

2013-12-24 Thread Nicholas A. Bellinger
On Mon, 2013-12-23 at 20:20 -0800, Nicholas A. Bellinger wrote: > Hi Martin & Co, > > So after playing with the mainline DIF client against an initial WIP > target DIF support patch, I've started hitting a bug in > bio_integrity_verify() that causes READ verify logic to be silently > skipped for b

bio_integrity_verify() bug causing READ verify to be silently skipped

2013-12-23 Thread Nicholas A. Bellinger
Hi Martin & Co, So after playing with the mainline DIF client against an initial WIP target DIF support patch, I've started hitting a bug in bio_integrity_verify() that causes READ verify logic to be silently skipped for both WIP target and existing scsi_debug DIF code. The issue is with the scsi