Re: Sparc ESP problem with blk-mq

2014-10-19 Thread Christoph Hellwig
On Sun, Oct 19, 2014 at 03:10:00PM +0300, mr...@linux.ee wrote: > > > Christoph, I don't see how the new tagging code with blk-mq can > > > be providing compatible behavior for existing SCSI drivers. > > > > It doesn't, and that's my fault. > > > > Please try the patch below: > > Seems to have w

Re: Sparc ESP problem with blk-mq

2014-10-19 Thread mroos
> > Christoph, I don't see how the new tagging code with blk-mq can > > be providing compatible behavior for existing SCSI drivers. > > It doesn't, and that's my fault. > > Please try the patch below: Seems to have worked - the machine booted up with scsi blk mq enabled, I just can not log in s

Re: Sparc ESP problem with blk-mq

2014-10-18 Thread Christoph Hellwig
On Sat, Oct 18, 2014 at 01:31:32PM -0400, David Miller wrote: > > Christoph, I don't see how the new tagging code with blk-mq can > be providing compatible behavior for existing SCSI drivers. It doesn't, and that's my fault. Please try the patch below: diff --git a/Documentation/block/biodoc.tx

Re: Sparc ESP problem with blk-mq

2014-10-18 Thread David Miller
Christoph, I don't see how the new tagging code with blk-mq can be providing compatible behavior for existing SCSI drivers. Do you know that scsi_populate_tag_msg() is always going to provide a tag? Unconditionally, every time, when using blk-mq? This is because the test: if (blk_rq_ta

Re: Sparc ESP problem with blk-mq

2014-10-17 Thread David Miller
From: mr...@linux.ee Date: Thu, 16 Oct 2014 09:43:34 +0300 (EEST) > [ 158.730919] ESP: tgt[6] lun[0] scsi_cmd [ 12 00 00 00 24 00 ] > [ 158.799397] ESP: intr sreg[87] seqreg[00] sreg2[00] ireg[18] Target 6 responds, Bus Service + Function Done interrupt. Status register 1 indicates interrupt p

Re: Sparc ESP problem with blk-mq

2014-10-16 Thread mroos
> >> Christoph, any idea on this? The command just times out, for some reason. > >> Only thing I could think of was related to perhaps missing bouncing or > >> similar, but I don't think that's the case. But the hba must not like the > >> request somehow. Or perhaps it sets up the wrong number of s

Re: Sparc ESP problem with blk-mq

2014-10-15 Thread David Miller
From: Christoph Hellwig Date: Wed, 15 Oct 2014 06:35:51 -0700 > On Tue, Oct 14, 2014 at 08:38:18AM -0600, Jens Axboe wrote: >> Christoph, any idea on this? The command just times out, for some reason. >> Only thing I could think of was related to perhaps missing bouncing or >> similar, but I don'

Re: Sparc ESP problem with blk-mq

2014-10-15 Thread Christoph Hellwig
On Tue, Oct 14, 2014 at 08:38:18AM -0600, Jens Axboe wrote: > Christoph, any idea on this? The command just times out, for some reason. > Only thing I could think of was related to perhaps missing bouncing or > similar, but I don't think that's the case. But the hba must not like the > request some

Re: Sparc ESP problem with blk-mq

2014-10-14 Thread Jens Axboe
(resent with correct linux-scsi address) On 2014-10-13 16:07, Meelis Roos wrote: I turned on blk-mq for all my test machines today and got a failure from Sun Ultra 1 with Sparc ESP SCSI (dmesg below). Booting with scsi_mod.use_blk_mq=0 fixes the problem. The problem is reproducible. [snip] [