Re: SCSI LLDs, the SCSI error handler and host resource lifetime

2012-11-27 Thread Hannes Reinecke
On 11/26/2012 06:23 PM, Bart Van Assche wrote: On 11/21/12 08:19, Hannes Reinecke wrote: Hmm. This would still mean that the eh thread will run until finished. Which can take _A LOT_ of time (we're speaking hours here). I would rather have an additional return code in the various scsi_try_XXX fu

Re: SCSI LLDs, the SCSI error handler and host resource lifetime

2012-11-26 Thread Bart Van Assche
On 11/21/12 08:19, Hannes Reinecke wrote: > Hmm. > This would still mean that the eh thread will run until finished. > Which can take _A LOT_ of time (we're speaking hours here). > I would rather have an additional return code in the various > scsi_try_XXX functions to terminate the loop quickly.

Re: SCSI LLDs, the SCSI error handler and host resource lifetime

2012-11-21 Thread Bart Van Assche
On 11/21/12 08:19, Hannes Reinecke wrote: On 11/20/2012 03:24 PM, Bart Van Assche wrote: If I interpret the SCSI error handler source code correctly then scsi_unjam_host() may proceed concurrently with scsi_remove_host(). This means that the LLD eh_abort_handler callback may get invoked after sc

Re: SCSI LLDs, the SCSI error handler and host resource lifetime

2012-11-20 Thread Hannes Reinecke
On 11/20/2012 03:24 PM, Bart Van Assche wrote: Hello, If I interpret the SCSI error handler source code correctly then scsi_unjam_host() may proceed concurrently with scsi_remove_host(). This means that the LLD eh_abort_handler callback may get invoked after scsi_remove_host() finished. At least

SCSI LLDs, the SCSI error handler and host resource lifetime

2012-11-20 Thread Bart Van Assche
Hello, If I interpret the SCSI error handler source code correctly then scsi_unjam_host() may proceed concurrently with scsi_remove_host(). This means that the LLD eh_abort_handler callback may get invoked after scsi_remove_host() finished. At least the SRP initiator (ib_srp) cleans up resources n