Re: twa generates WARNING upon boot

2015-09-30 Thread Tóth Attila
2015.Szeptember 30.(Sze) 18:44 időpontban Christoph Hellwig ezt írta: > On Wed, Sep 30, 2015 at 09:43:28AM -0700, James Bottomley wrote: >> OK, post a compilable version of the patch and lets get the reporter to >> try it out. Not resurrecting esoteric flags suits me. No WARNINGs upon reboot usin

Re: twa generates WARNING upon boot

2015-09-30 Thread Christoph Hellwig
On Wed, Sep 30, 2015 at 09:43:28AM -0700, James Bottomley wrote: > OK, post a compilable version of the patch and lets get the reporter to > try it out. Not resurrecting esoteric flags suits me. Right here: diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c index add419d..a56a7b2 10064

Re: twa generates WARNING upon boot

2015-09-30 Thread James Bottomley
On Wed, 2015-09-30 at 09:41 -0700, Christoph Hellwig wrote: > On Wed, Sep 30, 2015 at 09:36:24AM -0700, James Bottomley wrote: > > Are you sure? The init trace that kicked all this off still has > > twa_init in it. I was figuring the most likely suspect is > > twa_get_param(). > > That one doesn

Re: twa generates WARNING upon boot

2015-09-30 Thread Christoph Hellwig
On Wed, Sep 30, 2015 at 09:36:24AM -0700, James Bottomley wrote: > Are you sure? The init trace that kicked all this off still has > twa_init in it. I was figuring the most likely suspect is > twa_get_param(). That one doesnt set ->srb at all, but given that it's called before any SCSI commands

Re: twa generates WARNING upon boot

2015-09-30 Thread James Bottomley
On Wed, 2015-09-30 at 09:31 -0700, Christoph Hellwig wrote: > On Wed, Sep 30, 2015 at 09:15:30AM -0700, James Bottomley wrote: > > I already thought of this. Unfortunately, it fails if the internally > > posted command is a single sector (the size of TW_MIN_SGL_LENGTH), which > > is true for most

Re: twa generates WARNING upon boot

2015-09-30 Thread Christoph Hellwig
On Wed, Sep 30, 2015 at 09:15:30AM -0700, James Bottomley wrote: > I already thought of this. Unfortunately, it fails if the internally > posted command is a single sector (the size of TW_MIN_SGL_LENGTH), which > is true for most of them. Which internally posted command? All the usual suspects s

Re: Re: twa generates WARNING upon boot

2015-09-30 Thread kbuild test robot
Hi Christoph, [auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore] config: x86_64-allmodconfig (attached as .config) reproduce: git checkout 6e392493504e88ec3b44596c22f08acf4eed11ee # save the attached .config to linux build tree make ARCH=x86_64 All error/w

Re: twa generates WARNING upon boot

2015-09-30 Thread James Bottomley
On Wed, 2015-09-30 at 09:08 -0700, Christoph Hellwig wrote: > Hi all, > > I'd like to propose the following patch intead. It uses a helper > to check the conditions for the copied commands, and also fixes another > place to use it which uses a different and I think buggy check: > > This avoids t

Re: twa generates WARNING upon boot

2015-09-30 Thread Christoph Hellwig
Hi all, I'd like to propose the following patch intead. It uses a helper to check the conditions for the copied commands, and also fixes another place to use it which uses a different and I think buggy check: This avoids the usage of scsi_cmnd.SCp which I'd like to get rid of mid-term. diff --g

Re: twa generates WARNING upon boot

2015-09-29 Thread Tóth Attila
2015.Szeptember 29.(K) 20:33 időpontban James Bottomley ezt írta: > On Tue, 2015-09-29 at 20:25 +0200, "Tóth Attila" wrote: >> 2015.Szeptember 29.(K) 20:02 időpontban James Bottomley ezt írta: >> > On Tue, 2015-09-29 at 10:37 -0700, James Bottomley wrote: >> >> On Tue, 2015-09-29 at 18:49 +0200, "T

Re: twa generates WARNING upon boot

2015-09-29 Thread James Bottomley
On Tue, 2015-09-29 at 20:25 +0200, "Tóth Attila" wrote: > 2015.Szeptember 29.(K) 20:02 időpontban James Bottomley ezt írta: > > On Tue, 2015-09-29 at 10:37 -0700, James Bottomley wrote: > >> On Tue, 2015-09-29 at 18:49 +0200, "Tóth Attila" wrote: > >> > 2015.Szeptember 27.(V) 23:19 időpontban adam

Re: twa generates WARNING upon boot

2015-09-29 Thread Tóth Attila
2015.Szeptember 29.(K) 20:02 időpontban James Bottomley ezt írta: > On Tue, 2015-09-29 at 10:37 -0700, James Bottomley wrote: >> On Tue, 2015-09-29 at 18:49 +0200, "Tóth Attila" wrote: >> > 2015.Szeptember 27.(V) 23:19 időpontban adam radford ezt írta: >> > > On Sun, Sep 27, 2015 at 4:56 AM, "Tóth

Re: twa generates WARNING upon boot

2015-09-29 Thread James Bottomley
On Tue, 2015-09-29 at 10:37 -0700, James Bottomley wrote: > On Tue, 2015-09-29 at 18:49 +0200, "Tóth Attila" wrote: > > 2015.Szeptember 27.(V) 23:19 időpontban adam radford ezt írta: > > > On Sun, Sep 27, 2015 at 4:56 AM, "Tóth Attila" > > > wrote: > > >> Here is a current trace I see after bootin

Re: twa generates WARNING upon boot

2015-09-29 Thread James Bottomley
On Tue, 2015-09-29 at 18:49 +0200, "Tóth Attila" wrote: > 2015.Szeptember 27.(V) 23:19 időpontban adam radford ezt írta: > > On Sun, Sep 27, 2015 at 4:56 AM, "Tóth Attila" > > wrote: > >> Here is a current trace I see after booting that kernel: > >> [ cut here ] > >> WARNIN

Re: twa generates WARNING upon boot

2015-09-29 Thread Tóth Attila
2015.Szeptember 27.(V) 23:19 időpontban adam radford ezt írta: > On Sun, Sep 27, 2015 at 4:56 AM, "Tóth Attila" > wrote: >> Here is a current trace I see after booting that kernel: >> [ cut here ] >> WARNING: CPU: 0 PID: 1 at drivers/iommu/intel-iommu.c:3214 >> intel_unmap+

Re: twa generates WARNING upon boot

2015-09-27 Thread Tóth Attila
2015.Szeptember 27.(V) 23:19 időpontban adam radford ezt írta: > On Sun, Sep 27, 2015 at 4:56 AM, "Tóth Attila" wrote: >> The 3ware card is a 9650SE-12ML running in a Asus Z8PE-D12X motherboard. >> >> I don't know the exact command I have to type to get a meaningful output for addr2line... >> >> P

Re: twa generates WARNING upon boot

2015-09-27 Thread adam radford
On Sun, Sep 27, 2015 at 4:56 AM, "Tóth Attila" wrote: > After an unsuccessful attempt to contact linuxr...@lsi.com, I'm trying to > seek assistance on this list. > > I've been seeing WARNINGs upon boot for a while now, without any obvious > symptoms. I got some advice to report it upstream on the