Re: DISABLE_CLUSTERING in scsi drivers

2018-12-05 Thread Lee Duncan
On 11/21/18 1:41 AM, Christoph Hellwig wrote: > Hi all, > > you in the To list maintain or wrote SCSI drivers that set the > DISABLE_CLUSTERING flag, which basically disable merges of any > bio segments. We already have the actual max_segment size limit > to say which length a segment should have

Re: DISABLE_CLUSTERING in scsi drivers

2018-12-03 Thread Finn Thain
On Mon, 3 Dec 2018, Hannes Reinecke wrote: > As I said: I need to do PIO for the last two bytes of the data buffer. > For everything else DMA works nicely, it's just the last two bytes which > might be left over in the FIFO buffer under certain circumstances. I read the driver a few times alrea

Re: DISABLE_CLUSTERING in scsi drivers

2018-12-03 Thread Hannes Reinecke
On 12/2/18 11:13 PM, Finn Thain wrote: On Sun, 2 Dec 2018, Hannes Reinecke wrote: On 12/2/18 10:21 PM, Finn Thain wrote: On Sun, 2 Dec 2018, Hannes Reinecke wrote: Well, that lone 'kmap' is due to a quirk/errata in the datasheet; essentially we have to PIO a lone byte out of the FIFO to clea

Re: DISABLE_CLUSTERING in scsi drivers

2018-12-02 Thread Finn Thain
On Sun, 2 Dec 2018, Hannes Reinecke wrote: > On 12/2/18 10:21 PM, Finn Thain wrote: > > On Sun, 2 Dec 2018, Hannes Reinecke wrote: > > > > > Well, that lone 'kmap' is due to a quirk/errata in the datasheet; > > > essentially > > > we have to PIO a lone byte out of the FIFO to clear it up. > > > A

Re: DISABLE_CLUSTERING in scsi drivers

2018-12-02 Thread Hannes Reinecke
On 12/2/18 10:21 PM, Finn Thain wrote: On Sun, 2 Dec 2018, Hannes Reinecke wrote: Well, that lone 'kmap' is due to a quirk/errata in the datasheet; essentially we have to PIO a lone byte out of the FIFO to clear it up. And this byte is technically still part of the SCSI data, so we need to stuf

Re: DISABLE_CLUSTERING in scsi drivers

2018-12-02 Thread Finn Thain
On Sun, 2 Dec 2018, Hannes Reinecke wrote: > Well, that lone 'kmap' is due to a quirk/errata in the datasheet; essentially > we have to PIO a lone byte out of the FIFO to clear it up. > And this byte is technically still part of the SCSI data, so we need to > stuff it onto the end of the actual da

Re: DISABLE_CLUSTERING in scsi drivers

2018-12-02 Thread Hannes Reinecke
On 11/26/18 10:46 AM, Finn Thain wrote: On Mon, 26 Nov 2018, Christoph Hellwig wrote: On Thu, Nov 22, 2018 at 09:02:13AM +1100, Finn Thain wrote: you in the To list maintain or wrote SCSI drivers that set the DISABLE_CLUSTERING flag, which basically disable merges of any bio segments. We alre

Re: DISABLE_CLUSTERING in scsi drivers

2018-11-27 Thread Sam Creasey
On Mon, Nov 26, 2018 at 08:46:39PM +1100, Finn Thain wrote: > On Mon, 26 Nov 2018, Christoph Hellwig wrote: > > > On Thu, Nov 22, 2018 at 09:02:13AM +1100, Finn Thain wrote: > > > > you in the To list maintain or wrote SCSI drivers that set the > > > > DISABLE_CLUSTERING flag, which basically disa

Re: DISABLE_CLUSTERING in scsi drivers

2018-11-26 Thread Finn Thain
On Mon, 26 Nov 2018, Christoph Hellwig wrote: > On Thu, Nov 22, 2018 at 09:02:13AM +1100, Finn Thain wrote: > > > you in the To list maintain or wrote SCSI drivers that set the > > > DISABLE_CLUSTERING flag, which basically disable merges of any > > > bio segments. We already have the actual max_

Re: DISABLE_CLUSTERING in scsi drivers

2018-11-26 Thread Michael Schmitz
Am 26.11.2018 um 20:50 schrieb Christoph Hellwig: On Thu, Nov 22, 2018 at 10:11:33AM +1300, Michael Schmitz wrote: Christoph, for Atari SCSI, commands can only be merged if the physical addresses of all buffers are contiguous (limitation of the Falcon DMA engine). Documentation/scsi/scsi_mid_

Re: DISABLE_CLUSTERING in scsi drivers

2018-11-25 Thread Christoph Hellwig
On Thu, Nov 22, 2018 at 10:11:33AM +1300, Michael Schmitz wrote: > Christoph, > for Atari SCSI, commands can only be merged if the physical addresses > of all buffers are contiguous (limitation of the Falcon DMA engine). > Documentation/scsi/scsi_mid_low_api.tx does not spell out whether that > is

Re: DISABLE_CLUSTERING in scsi drivers

2018-11-25 Thread Christoph Hellwig
On Thu, Nov 22, 2018 at 09:02:13AM +1100, Finn Thain wrote: > > you in the To list maintain or wrote SCSI drivers that set the > > DISABLE_CLUSTERING flag, which basically disable merges of any > > bio segments. We already have the actual max_segment size limit > > to say which length a segment sh

Re: DISABLE_CLUSTERING in scsi drivers

2018-11-25 Thread Christoph Hellwig
On Fri, Nov 23, 2018 at 09:09:49AM +0100, Juergen Gross wrote: > On 21/11/2018 10:41, Christoph Hellwig wrote: > > Hi all, > > > > you in the To list maintain or wrote SCSI drivers that set the > > DISABLE_CLUSTERING flag, which basically disable merges of any > > bio segments. We already have th

Re: DISABLE_CLUSTERING in scsi drivers

2018-11-23 Thread Juergen Gross
On 21/11/2018 10:41, Christoph Hellwig wrote: > Hi all, > > you in the To list maintain or wrote SCSI drivers that set the > DISABLE_CLUSTERING flag, which basically disable merges of any > bio segments. We already have the actual max_segment size limit > to say which length a segment should have

Re: DISABLE_CLUSTERING in scsi drivers

2018-11-21 Thread Finn Thain
On Wed, 21 Nov 2018, Christoph Hellwig wrote: > Hi all, > > you in the To list maintain or wrote SCSI drivers that set the > DISABLE_CLUSTERING flag, which basically disable merges of any > bio segments. We already have the actual max_segment size limit > to say which length a segment should h

Re: DISABLE_CLUSTERING in scsi drivers

2018-11-21 Thread Michael Schmitz
Christoph, for Atari SCSI, commands can only be merged if the physical addresses of all buffers are contiguous (limitation of the Falcon DMA engine). Documentation/scsi/scsi_mid_low_api.tx does not spell out whether that is the case. Atari SCSI disables scatter/gather, so if that's sufficient to c