Re: [patch] qla2xxx: fix a timeout loop

2015-12-17 Thread Martin K. Petersen
> "Dan" == Dan Carpenter writes: Dan> The qlogic devs asked me to redo this patch but you have already Dan> applied it. Should I resend or redo it on top of the earlier Dan> patch. (James's tree was rebaseable for a day after a patch was Dan> "applied".) I dropped it for now. -- Martin K

Re: [patch] qla2xxx: fix a timeout loop

2015-12-17 Thread Dan Carpenter
On Wed, Dec 16, 2015 at 05:50:17PM -0500, Martin K. Petersen wrote: > > "Dan" == Dan Carpenter writes: > > Dan> After the loop we test for "if (!retries) " as a failure, but > Dan> actually the post-op here will end with retries set to -1. I have > Dan> fixed this by using a pre-op instead.

Re: [patch] qla2xxx: fix a timeout loop

2015-12-16 Thread Himanshu Madhani
Hi Dan, On 12/16/15, 3:07 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Dan Carpenter" wrote: >After the loop we test for "if (!retries) " as a failure, but actually >the post-op here will end with retries set to -1. I have fixed this by >using a pre-op instead. > >Fixes: 7ec0effd30bb ('

Re: [patch] qla2xxx: fix a timeout loop

2015-12-16 Thread Martin K. Petersen
> "Dan" == Dan Carpenter writes: Dan> After the loop we test for "if (!retries) " as a failure, but Dan> actually the post-op here will end with retries set to -1. I have Dan> fixed this by using a pre-op instead. Applied to 4.4/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineer

Re: [patch] qla2xxx: fix a timeout loop

2015-12-16 Thread Johannes Thumshirn
On Wed, Dec 16, 2015 at 02:07:46PM +0300, Dan Carpenter wrote: > After the loop we test for "if (!retries) " as a failure, but actually > the post-op here will end with retries set to -1. I have fixed this by > using a pre-op instead. > > Fixes: 7ec0effd30bb ('[SCSI] qla2xxx: Add support for ISP8