Re: [patch] SCSI: early detection of medium not present, updated

2007-12-07 Thread Alan Stern
On Wed, 5 Dec 2007, James Bottomley wrote: > > For one thing, you've using retries to control both an outer loop and > > an inner loop -- meaning the total number of attempts could be on the > > order of retries**2. > > Sort of; however, there should only really be one cc/ua before the TUR > go

Re: [patch] SCSI: early detection of medium not present, updated

2007-12-05 Thread James Bottomley
On Sun, 2007-12-02 at 15:02 -0500, Alan Stern wrote: > On Sun, 2 Dec 2007, James Bottomley wrote: > > > Actually, the night train is a good place to do coding. I know this > > compiles, but could someone check it out? It's the form I think we > > should do, since the ASC/ASCQ codes for esoteric

Re: [patch] SCSI: early detection of medium not present, updated

2007-12-02 Thread Alan Stern
On Sun, 2 Dec 2007, James Bottomley wrote: > Actually, the night train is a good place to do coding. I know this > compiles, but could someone check it out? It's the form I think we > should do, since the ASC/ASCQ codes for esoteric conditions which we > might eventually check for are different

Re: [patch] SCSI: early detection of medium not present, updated

2007-12-02 Thread James Bottomley
On Sat, 2007-12-01 at 16:25 +0200, James Bottomley wrote: > On Thu, 2007-11-29 at 15:18 -0800, Andrew Morton wrote: > > Guys, I have this marked as needed-in-2.6.24? > > Could you wait on this a bit ... since it's such an old bug. The code > in question needs to be reworked (as the comment says).

Re: [patch] SCSI: early detection of medium not present, updated

2007-12-01 Thread Alan Stern
On Sat, 1 Dec 2007, James Bottomley wrote: > On Thu, 2007-11-29 at 15:18 -0800, Andrew Morton wrote: > > Guys, I have this marked as needed-in-2.6.24? > > Could you wait on this a bit ... since it's such an old bug. The code > in question needs to be reworked (as the comment says). I think the

Re: [patch] SCSI: early detection of medium not present, updated

2007-12-01 Thread James Bottomley
On Thu, 2007-11-29 at 15:18 -0800, Andrew Morton wrote: > Guys, I have this marked as needed-in-2.6.24? Could you wait on this a bit ... since it's such an old bug. The code in question needs to be reworked (as the comment says). I think the best rework is to have the caller pass in an optional

Re: [patch] SCSI: early detection of medium not present, updated

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Andrew Morton wrote: > Guys, I have this marked as needed-in-2.6.24? > From: Alan Stern <[EMAIL PROTECTED]> > > Taken from http://bugzilla.kernel.org/show_bug.cgi?id=8904 > > An updated (by Albert, I assume) version of the fourteen-month-old patch here: > > http://marc.inf

Re: [patch] SCSI: early detection of medium not present, updated

2007-11-29 Thread Tejun Heo
Andrew Morton wrote: > From: Alan Stern <[EMAIL PROTECTED]> > > Taken from http://bugzilla.kernel.org/show_bug.cgi?id=8904 > > An updated (by Albert, I assume) version of the fourteen-month-old patch here: > > http://marc.info/?l=linux-kernel&m=115412002912837&w=2 > > Apparently fixes the bug d