On Fri, Apr 27, 2007 at 01:28:38PM -0700, David Miller wrote:
> From: Christoph Hellwig <[EMAIL PROTECTED]>
> Date: Fri, 27 Apr 2007 16:16:58 +0100
>
> > aic7xxx might not be the best driver to look at either :) In practice
> > a softirq has short enough latency so this doesn't matter, but you
>
From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Fri, 27 Apr 2007 16:16:58 +0100
> aic7xxx might not be the best driver to look at either :) In practice
> a softirq has short enough latency so this doesn't matter, but you
> should probably benchmark it on your hardware. 53x700.c which is
> the
Sorry for the late reply. I'll stay in this thead despite the
new version beeing posted to not lose the context.
On Tue, Apr 24, 2007 at 01:44:40PM -0700, David Miller wrote:
> I did all of this, and it's fine, but there is one site which is much
> less pleasant, device reconnect.
>
> With the e
From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Tue, 24 Apr 2007 13:45:27 +0100
> Oh, btw - there is a problem with the generic code beeing esp.ko -
> we already have drivers/char/esp.c which buids into esp.ko for
> ISA platforms, which have a bit of overlap with ESP-using platforms.
> Maybe the
From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Tue, 24 Apr 2007 13:22:35 +0100
> Overall the driver looks really nice, thanks a lot!
Thanks.
> would be nice to have dev_printk here, but sbus still seems to
> lack driver model integration.
There is only partial integration at the moment, but
On Tue, 2007-04-24 at 13:22 +0100, Christoph Hellwig wrote:
> > +static void esp_build_sync_msg(struct esp *esp, u8 period, u8
> offset)
> > {
> > + esp->msg_out[0] = EXTENDED_MESSAGE;
> > + esp->msg_out[1] = 3;
> > + esp->msg_out[2] = EXTENDED_SDTR;
> > + esp->msg_out[3] = period;
On Tue, Apr 24, 2007 at 01:22:35PM +0100, Christoph Hellwig wrote:
> > +static void esp_build_sync_msg(struct esp *esp, u8 period, u8 offset)
> > {
> > + esp->msg_out[0] = EXTENDED_MESSAGE;
> > + esp->msg_out[1] = 3;
> > + esp->msg_out[2] = EXTENDED_SDTR;
> > + esp->msg_out[3] = period;
>
Oh, btw - there is a problem with the generic code beeing esp.ko -
we already have drivers/char/esp.c which buids into esp.ko for
ISA platforms, which have a bit of overlap with ESP-using platforms.
Maybe the driver should become esp_scsi.c/.ko or ncr_esp or
ncr53x9x?
-
To unsubscribe from this lis
Overall the driver looks really nice, thanks a lot!
some comments:
> +#define esp_log_intr(f, a...) \
> +do { if (esp_debug & ESP_DEBUG_INTR) \
> + printk(f, ## a); \
> +} while (0)
would be nice to have dev_printk here, but sbus still seems to
lack driver model integration.
> +stat
9 matches
Mail list logo
