Re: [RFC] scsi: generate uevent for SCSI sense code

2017-05-16 Thread Song Liu
> On May 16, 2017, at 10:00 AM, Benjamin Block > wrote: > > Hello, > > On Wed, May 03, 2017 at 05:50:13PM -0700, Song Liu wrote: >> This patch adds capability for SCSI layer to generate uevent for SCSI >> sense code. The feature is gated by CONFIG_SCSI_SENSE_UEVENT. >> >> We can configure whi

Re: [RFC] scsi: generate uevent for SCSI sense code

2017-05-16 Thread Benjamin Block
Hello, On Wed, May 03, 2017 at 05:50:13PM -0700, Song Liu wrote: > This patch adds capability for SCSI layer to generate uevent for SCSI > sense code. The feature is gated by CONFIG_SCSI_SENSE_UEVENT. > > We can configure which sense keys generate uevent for each device > through sysfs entry sense

Re: [RFC] scsi: generate uevent for SCSI sense code

2017-05-15 Thread Song Liu
> On May 15, 2017, at 5:31 AM, Ewan D. Milne wrote: > > On Mon, 2017-05-15 at 08:04 +0200, Hannes Reinecke wrote: >> In general I like the idea; however, the 'filter' thingie is somewhat >> odd. I could somewhat buy into the idea of filtering for sense keys, but >> then I would have expected to

Re: [RFC] scsi: generate uevent for SCSI sense code

2017-05-15 Thread Song Liu
> On May 14, 2017, at 11:04 PM, Hannes Reinecke wrote: > > On 05/12/2017 09:02 PM, Song Liu wrote: >> >>> On May 3, 2017, at 5:50 PM, Song Liu wrote: >>> >>> This patch adds capability for SCSI layer to generate uevent for SCSI >>> sense code. The feature is gated by CONFIG_SCSI_SENSE_UEVENT.

Re: [RFC] scsi: generate uevent for SCSI sense code

2017-05-15 Thread Ewan D. Milne
On Mon, 2017-05-15 at 08:04 +0200, Hannes Reinecke wrote: > In general I like the idea; however, the 'filter' thingie is somewhat > odd. I could somewhat buy into the idea of filtering for sense keys, but > then I would have expected to use the 'sense_event_filter' as a bitmap > of allowed sense ke

Re: [RFC] scsi: generate uevent for SCSI sense code

2017-05-14 Thread Hannes Reinecke
On 05/12/2017 09:02 PM, Song Liu wrote: > >> On May 3, 2017, at 5:50 PM, Song Liu wrote: >> >> This patch adds capability for SCSI layer to generate uevent for SCSI >> sense code. The feature is gated by CONFIG_SCSI_SENSE_UEVENT. >> >> We can configure which sense keys generate uevent for each de

Re: [RFC] scsi: generate uevent for SCSI sense code

2017-05-12 Thread Song Liu
> On May 3, 2017, at 5:50 PM, Song Liu wrote: > > This patch adds capability for SCSI layer to generate uevent for SCSI > sense code. The feature is gated by CONFIG_SCSI_SENSE_UEVENT. > > We can configure which sense keys generate uevent for each device > through sysfs entry sense_event_filter.