Re: [PATCH v9 05/10] libata: separate ATAPI code

2012-11-19 Thread Tejun Heo
On Mon, Nov 19, 2012 at 10:21:15AM +0800, Aaron Lu wrote: > My thought is that, the 2 functions are for ATAPI and can be used by > libata-eh, libata-zpodd and maybe others in the future, so it deserves > a separate place. But if this is regarded as unnecessary, I will drop > this patch. Yeah, plea

Re: [PATCH v9 05/10] libata: separate ATAPI code

2012-11-18 Thread Aaron Lu
On 11/18/2012 11:01 PM, Tejun Heo wrote: > On Tue, Nov 13, 2012 at 08:49:24PM +0800, Aaron Lu wrote: >> On Mon, Nov 12, 2012 at 10:57:10AM -0800, Tejun Heo wrote: >>> On Fri, Nov 09, 2012 at 02:51:57PM +0800, Aaron Lu wrote: The atapi_eh_tur and atapi_eh_request_sense can be reused by ZPODD >>

Re: [PATCH v9 05/10] libata: separate ATAPI code

2012-11-18 Thread Tejun Heo
On Tue, Nov 13, 2012 at 08:49:24PM +0800, Aaron Lu wrote: > On Mon, Nov 12, 2012 at 10:57:10AM -0800, Tejun Heo wrote: > > On Fri, Nov 09, 2012 at 02:51:57PM +0800, Aaron Lu wrote: > > > The atapi_eh_tur and atapi_eh_request_sense can be reused by ZPODD > > > code, so separate them out to a file na

Re: [PATCH v9 05/10] libata: separate ATAPI code

2012-11-13 Thread Aaron Lu
On Mon, Nov 12, 2012 at 10:57:10AM -0800, Tejun Heo wrote: > On Fri, Nov 09, 2012 at 02:51:57PM +0800, Aaron Lu wrote: > > The atapi_eh_tur and atapi_eh_request_sense can be reused by ZPODD > > code, so separate them out to a file named libata-atapi.c, and the > > Makefile is modified accordingly.

Re: [PATCH v9 05/10] libata: separate ATAPI code

2012-11-12 Thread Tejun Heo
On Fri, Nov 09, 2012 at 02:51:57PM +0800, Aaron Lu wrote: > The atapi_eh_tur and atapi_eh_request_sense can be reused by ZPODD > code, so separate them out to a file named libata-atapi.c, and the > Makefile is modified accordingly. No functional changes should result > from this commit. Why is thi