Re: [PATCH v9 03/10] ata: zpodd: identify and init ZPODD devices

2012-11-18 Thread Aaron Lu
On 11/18/2012 10:38 PM, Tejun Heo wrote: > Hello, Aaron. Hi, > > On Wed, Nov 14, 2012 at 09:32:27AM +0800, Aaron Lu wrote: >>> I don't think you're supposed to use dev->private_data from libata >>> core layer. Just add a new field. Nobody cares about adding 8 more >>> bytes to struct ata_device

Re: [PATCH v9 03/10] ata: zpodd: identify and init ZPODD devices

2012-11-18 Thread Tejun Heo
Hello, Aaron. On Wed, Nov 14, 2012 at 09:32:27AM +0800, Aaron Lu wrote: > > I don't think you're supposed to use dev->private_data from libata > > core layer. Just add a new field. Nobody cares about adding 8 more > > bytes to struct ata_device and spending 8 more bytes is way better > > than mu

Re: [PATCH v9 03/10] ata: zpodd: identify and init ZPODD devices

2012-11-13 Thread Aaron Lu
On 11/13/2012 02:53 AM, Tejun Heo wrote: > Hello, > > On Fri, Nov 09, 2012 at 02:51:55PM +0800, Aaron Lu wrote: >> void ata_acpi_unbind(struct ata_device *dev) >> { >> +if (zpodd_dev_enabled(dev)) >> +zpodd_deinit(dev); > > Maybe zpodd_exit() instead? OK. > >> +void zpodd_ini

Re: [PATCH v9 03/10] ata: zpodd: identify and init ZPODD devices

2012-11-12 Thread Tejun Heo
Hello, On Fri, Nov 09, 2012 at 02:51:55PM +0800, Aaron Lu wrote: > void ata_acpi_unbind(struct ata_device *dev) > { > + if (zpodd_dev_enabled(dev)) > + zpodd_deinit(dev); Maybe zpodd_exit() instead? > +void zpodd_init(struct ata_device *dev) > +{ > + int ret; > + struct