Re: [PATCH v8 4/4] sd: change to auto suspend mode

2013-02-01 Thread Alan Stern
On Fri, 1 Feb 2013, Aaron Lu wrote: > On Thu, Jan 31, 2013 at 10:13:05AM -0500, Alan Stern wrote: > > On Thu, 31 Jan 2013, Aaron Lu wrote: > > > > > > > +static int scsi_blk_runtime_suspend(struct device *dev) > > > > > +{ > > > > > + struct scsi_device *sdev = to_scsi_device(dev); > > > > >

Re: [PATCH v8 4/4] sd: change to auto suspend mode

2013-01-31 Thread Aaron Lu
On Thu, Jan 31, 2013 at 10:13:05AM -0500, Alan Stern wrote: > On Thu, 31 Jan 2013, Aaron Lu wrote: > > > > > +static int scsi_blk_runtime_suspend(struct device *dev) > > > > +{ > > > > + struct scsi_device *sdev = to_scsi_device(dev); > > > > > > For this routine and the other new ones, it

Re: [PATCH v8 4/4] sd: change to auto suspend mode

2013-01-31 Thread Alan Stern
On Thu, 31 Jan 2013, Aaron Lu wrote: > > > +static int scsi_blk_runtime_suspend(struct device *dev) > > > +{ > > > + struct scsi_device *sdev = to_scsi_device(dev); > > > > For this routine and the other new ones, it may be slightly more > > efficient to pass both dev and sdev as arguments (this

Re: [PATCH v8 4/4] sd: change to auto suspend mode

2013-01-30 Thread Aaron Lu
On Wed, Jan 30, 2013 at 10:38:26AM -0500, Alan Stern wrote: > On Wed, 30 Jan 2013, Aaron Lu wrote: > > > From: Lin Ming > > > > Uses block layer runtime pm helper functions in > > scsi_runtime_suspend/resume for devices that take advantage of it. > > > > Remove scsi_autopm_* from sd open/releas

Re: [PATCH v8 4/4] sd: change to auto suspend mode

2013-01-30 Thread Alan Stern
On Wed, 30 Jan 2013, Aaron Lu wrote: > From: Lin Ming > > Uses block layer runtime pm helper functions in > scsi_runtime_suspend/resume for devices that take advantage of it. > > Remove scsi_autopm_* from sd open/release path and check_events path. > > Signed-off-by: Lin Ming > Signed-off-by: