Re: [PATCH v6 04/13] block: Avoid scheduling delayed work on a dead queue

2012-12-02 Thread Tejun Heo
Hello, Bart. On Sun, Dec 02, 2012 at 02:41:20PM +0100, Bart Van Assche wrote: > I agree. There is a reason though I have not yet added a > lockdep_assert_held() statement in these functions: there are still > unprotected calls of blk_run_queue_async() in drivers/md/dm.c and > drivers/scsi/scsi_tra

Re: [PATCH v6 04/13] block: Avoid scheduling delayed work on a dead queue

2012-12-02 Thread Bart Van Assche
On 12/02/12 14:26, Tejun Heo wrote: On Wed, Nov 28, 2012 at 01:45:56PM +0100, Bart Van Assche wrote: Running a queue must continue after it has been marked dying until it has been marked dead. So the function blk_run_queue_async() must not schedule delayed work after blk_cleanup_queue() has mark

Re: [PATCH v6 04/13] block: Avoid scheduling delayed work on a dead queue

2012-12-02 Thread Tejun Heo
On Wed, Nov 28, 2012 at 01:45:56PM +0100, Bart Van Assche wrote: > Running a queue must continue after it has been marked dying until > it has been marked dead. So the function blk_run_queue_async() must > not schedule delayed work after blk_cleanup_queue() has marked a queue > dead. Hence add a te