Re: [PATCH v4 4/9] snic:Add snic target discovery

2015-04-14 Thread Narsimhulu Musini (nmusini)
Hi Hannes, Thank you for reviewing patches. Please find responses inline. On 13/04/15 7:59 pm, "Hannes Reinecke" wrote: >On 04/13/2015 07:25 AM, Narsimhulu Musini (nmusini) wrote: >> Hi Hannes, >> >> Thank you for reviewing patches. Please find responses inline. >> >> >> >> On 09/04/15

Re: [PATCH v4 4/9] snic:Add snic target discovery

2015-04-13 Thread Hannes Reinecke
On 04/13/2015 07:25 AM, Narsimhulu Musini (nmusini) wrote: > Hi Hannes, > > Thank you for reviewing patches. Please find responses inline. > > > > On 09/04/15 6:29 pm, "Hannes Reinecke" wrote: > >> >> On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: [ .. ] >>> +/* snic_tgt_create: checks fo

Re: [PATCH v4 4/9] snic:Add snic target discovery

2015-04-12 Thread Narsimhulu Musini (nmusini)
Hi Hannes, Thank you for reviewing patches. Please find responses inline. On 09/04/15 6:29 pm, "Hannes Reinecke" wrote: >Hi Narsimhulu, > >please find some comments inline. > >On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: >> snic_disc.h contains snic target structure definition. >> >> s

Re: [PATCH v4 4/9] snic:Add snic target discovery

2015-04-09 Thread Hannes Reinecke
Hi Narsimhulu, please find some comments inline. On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: > snic_disc.h contains snic target structure definition. > > snic_disc.c contains target discovery, setup, lookup, and cleanup > > snic_ctl.c contains retrieval of snic capabilities includes > max