Re: [PATCH v4 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-10-07 Thread Suganath Prabu Subramani
Hi Bjorn, We tried to recreate the issue with latest kernel multiple times.(Without including this patch,) but we were not able to recreate it. On 4.4 kernel we hit this issue time long back. So we are not sure that this issue is really fixed with latest kernel or not. We prefer to keep this patch

Re: [PATCH v4 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-10-01 Thread Bjorn Helgaas
[+cc LKML] On Mon, Oct 01, 2018 at 12:57:01PM +0530, Suganath Prabu Subramani wrote: > On Thu, Sep 27, 2018 at 2:39 AM Bjorn Helgaas wrote: > > On Wed, Sep 26, 2018 at 09:52:36AM +0530, Suganath Prabu S wrote: > > > The code for getting shost and IOC is redundant so > > > moved that to function "

Re: [PATCH v4 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-10-01 Thread Suganath Prabu Subramani
On Thu, Sep 27, 2018 at 2:39 AM Bjorn Helgaas wrote: > > On Wed, Sep 26, 2018 at 09:52:36AM +0530, Suganath Prabu S wrote: > > The code for getting shost and IOC is redundant so > > moved that to function "scsih_get_shost_and_ioc". > > Also checks for NULL are added to IOC and shost. > > > > Signe

Re: [PATCH v4 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-09-26 Thread Bjorn Helgaas
Trivial nits/questions. In subject: s/Introdude/Introduce/ s/ / / (remove double space) s/\.//(remove trailing period, also appears in patches 4, 5, 6) On Wed, Sep 26, 2018 at 09:52:36AM +0530, Suganath Prabu S wrote: > The code for getting shost and IOC is redundant so > moved that

Re: [PATCH v4 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-09-26 Thread Bjorn Helgaas
On Wed, Sep 26, 2018 at 09:52:36AM +0530, Suganath Prabu S wrote: > The code for getting shost and IOC is redundant so > moved that to function "scsih_get_shost_and_ioc". > Also checks for NULL are added to IOC and shost. > > Signed-off-by: Suganath Prabu S > --- > drivers/scsi/mpt3sas/mpt3sas_s