Re: [PATCH v4 3/3] cxlflash: Virtual LUN support

2015-08-12 Thread Manoj Kumar
Mikey: Comments inline below. - Manoj Kumar On 8/11/2015 10:24 PM, Michael Neuling wrote: The ioctls have a standard header structure, with version etc. that are sanity checked before we get here. The other fields are sanity checked where they are used, i.e. in get_context(). That was my po

Re: [PATCH v4 3/3] cxlflash: Virtual LUN support

2015-08-11 Thread Michael Neuling
> > Be good to do some clear sanity check the "struct dk_cxlflash_resize > > *resize" > > here. It's passed from userspace but then gets propogated to a bunch of > > other > > things here like nsectors, get_context etc who will all now be responsible > > for > > handling any dodgy data passed

Re: [PATCH v4 3/3] cxlflash: Virtual LUN support

2015-08-11 Thread Manoj Kumar
Mikey: Thanks for your review. Comments inline below. On 8/11/2015 5:54 AM, Michael Neuling wrote: I'm not keen on the numerous pr_err() in here. I think it'll make the driver chatty especially with a badly behaving userspace. Will look at all the pr_err() and limit them to errors that are

Re: [PATCH v4 3/3] cxlflash: Virtual LUN support

2015-08-11 Thread Michael Neuling
Comments inline. I'm not keen on the numerous pr_err() in here. I think it'll make the driver chatty especially with a badly behaving userspace. On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote: > Add support for physical LUN segmentation (virtual LUNs) to device > driver supporting the