Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity

2018-12-07 Thread Johannes Thumshirn
On 07/12/2018 11:07, John Garry wrote: > On 06/12/2018 16:20, Johannes Thumshirn wrote: >> On 06/12/2018 16:37, John Garry wrote: >>> which is important. Let me know if you disagree and I can change it. >> >> Sure, it's your driver. It was just because the patch is even titled >> "Relocate some cod

Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity

2018-12-07 Thread John Garry
On 06/12/2018 16:20, Johannes Thumshirn wrote: On 06/12/2018 16:37, John Garry wrote: which is important. Let me know if you disagree and I can change it. Sure, it's your driver. It was just because the patch is even titled "Relocate some code to reduce complexity", so I thought of reducing th

Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity

2018-12-06 Thread Johannes Thumshirn
On 06/12/2018 16:37, John Garry wrote: > which is important. Let me know if you disagree and I can change it. Sure, it's your driver. It was just because the patch is even titled "Relocate some code to reduce complexity", so I thought of reducing the complexity for readers even further (like you d

Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity

2018-12-06 Thread John Garry
On 06/12/2018 14:17, Johannes Thumshirn wrote: On 06/12/2018 14:34, John Garry wrote: [...] +static void hisi_sas_dma_unmap(struct hisi_hba *hisi_hba, + struct sas_task *task, int n_elem, + int n_elem_req, int n_elem_resp) +{ + stru

Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity

2018-12-06 Thread Johannes Thumshirn
On 06/12/2018 14:34, John Garry wrote: [...] > +static void hisi_sas_dma_unmap(struct hisi_hba *hisi_hba, > +struct sas_task *task, int n_elem, > +int n_elem_req, int n_elem_resp) > +{ > + struct device *dev = hisi_hba->dev; > + > + if